* [PATCH] btsdio: fix tx error path
@ 2008-10-06 9:05 Tomas Winkler
2008-10-06 9:22 ` Marcel Holtmann
2008-10-06 10:54 ` Marcel Holtmann
0 siblings, 2 replies; 4+ messages in thread
From: Tomas Winkler @ 2008-10-06 9:05 UTC (permalink / raw)
To: marcel; +Cc: linux-bluetooth, linux-kernel, Tomas Winkler
This patch fixes accumulating of the header
in case packet was requeued in the error path.
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Cc: Marcel Holtmann <marcel@holtmann.org>
---
drivers/bluetooth/btsdio.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/bluetooth/btsdio.c b/drivers/bluetooth/btsdio.c
index 58630cc..e4724b8 100644
--- a/drivers/bluetooth/btsdio.c
+++ b/drivers/bluetooth/btsdio.c
@@ -91,6 +91,7 @@ static int btsdio_tx_packet(struct btsdio_data *data, struct sk_buff *skb)
err = sdio_writesb(data->func, REG_TDAT, skb->data, skb->len);
if (err < 0) {
+ skb_pop(skb, 4);
sdio_writeb(data->func, 0x01, REG_PC_WRT, NULL);
return err;
}
--
1.5.4.3
---------------------------------------------------------------------
Intel Israel (74) Limited
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] btsdio: fix tx error path
2008-10-06 9:05 [PATCH] btsdio: fix tx error path Tomas Winkler
@ 2008-10-06 9:22 ` Marcel Holtmann
2008-10-06 10:54 ` Marcel Holtmann
1 sibling, 0 replies; 4+ messages in thread
From: Marcel Holtmann @ 2008-10-06 9:22 UTC (permalink / raw)
To: Tomas Winkler; +Cc: linux-bluetooth, linux-kernel
Hi Tomas,
> This patch fixes accumulating of the header
> in case packet was requeued in the error path.
>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> Cc: Marcel Holtmann <marcel@holtmann.org>
> ---
> drivers/bluetooth/btsdio.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/bluetooth/btsdio.c b/drivers/bluetooth/btsdio.c
> index 58630cc..e4724b8 100644
> --- a/drivers/bluetooth/btsdio.c
> +++ b/drivers/bluetooth/btsdio.c
> @@ -91,6 +91,7 @@ static int btsdio_tx_packet(struct btsdio_data *data, struct sk_buff *skb)
>
> err = sdio_writesb(data->func, REG_TDAT, skb->data, skb->len);
> if (err < 0) {
> + skb_pop(skb, 4);
> sdio_writeb(data->func, 0x01, REG_PC_WRT, NULL);
> return err;
> }
good catch. Applied to my tree. Thanks.
Regards
Marcel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] btsdio: fix tx error path
2008-10-06 9:05 [PATCH] btsdio: fix tx error path Tomas Winkler
2008-10-06 9:22 ` Marcel Holtmann
@ 2008-10-06 10:54 ` Marcel Holtmann
2008-10-06 11:20 ` Winkler, Tomas
1 sibling, 1 reply; 4+ messages in thread
From: Marcel Holtmann @ 2008-10-06 10:54 UTC (permalink / raw)
To: Tomas Winkler; +Cc: linux-bluetooth, linux-kernel
Hi Tomas,
> This patch fixes accumulating of the header
> in case packet was requeued in the error path.
>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> Cc: Marcel Holtmann <marcel@holtmann.org>
> ---
> drivers/bluetooth/btsdio.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/bluetooth/btsdio.c b/drivers/bluetooth/btsdio.c
> index 58630cc..e4724b8 100644
> --- a/drivers/bluetooth/btsdio.c
> +++ b/drivers/bluetooth/btsdio.c
> @@ -91,6 +91,7 @@ static int btsdio_tx_packet(struct btsdio_data *data, struct sk_buff *skb)
>
> err = sdio_writesb(data->func, REG_TDAT, skb->data, skb->len);
> if (err < 0) {
> + skb_pop(skb, 4);
> sdio_writeb(data->func, 0x01, REG_PC_WRT, NULL);
> return err;
> }
please do at least a compile test. It is skb_pull() and not skb_pop().
Regards
Marcel
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] btsdio: fix tx error path
2008-10-06 10:54 ` Marcel Holtmann
@ 2008-10-06 11:20 ` Winkler, Tomas
0 siblings, 0 replies; 4+ messages in thread
From: Winkler, Tomas @ 2008-10-06 11:20 UTC (permalink / raw)
To: Marcel Holtmann; +Cc: linux-bluetooth, linux-kernel
>-----Original Message-----
>From: Marcel Holtmann [mailto:marcel@holtmann.org]
>Sent: Monday, October 06, 2008 12:55 PM
>To: Winkler, Tomas
>Cc: linux-bluetooth@vger.kernel.org; linux-kernel@vger.kernel.org
>Subject: Re: [PATCH] btsdio: fix tx error path
>
>Hi Tomas,
>
>> This patch fixes accumulating of the header
>> in case packet was requeued in the error path.
>>
>> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
>> Cc: Marcel Holtmann <marcel@holtmann.org>
>> ---
>> drivers/bluetooth/btsdio.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/bluetooth/btsdio.c b/drivers/bluetooth/btsdio.c
>> index 58630cc..e4724b8 100644
>> --- a/drivers/bluetooth/btsdio.c
>> +++ b/drivers/bluetooth/btsdio.c
>> @@ -91,6 +91,7 @@ static int btsdio_tx_packet(struct btsdio_data
*data,
>struct sk_buff *skb)
>>
>> err = sdio_writesb(data->func, REG_TDAT, skb->data, skb->len);
>> if (err < 0) {
>> + skb_pop(skb, 4);
>> sdio_writeb(data->func, 0x01, REG_PC_WRT, NULL);
>> return err;
>> }
>
>please do at least a compile test. It is skb_pull() and not skb_pop().
Sorry, my bad. It was oneliner so I didn't take the patch directly from
the test machine and my server .config was wrong so the file didn't
compile at all :( leading to clean compilation I will resubmit be more
careful next time.
Tomas
---------------------------------------------------------------------
Intel Israel (74) Limited
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-10-06 11:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-10-06 9:05 [PATCH] btsdio: fix tx error path Tomas Winkler
2008-10-06 9:22 ` Marcel Holtmann
2008-10-06 10:54 ` Marcel Holtmann
2008-10-06 11:20 ` Winkler, Tomas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).