linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Do you want warning quashing patches at this point in the cycle?
@ 2021-10-04 10:13 David Howells
  2021-10-04 16:38 ` Linus Torvalds
  0 siblings, 1 reply; 2+ messages in thread
From: David Howells @ 2021-10-04 10:13 UTC (permalink / raw)
  To: torvalds
  Cc: Dominique Martinet, Jeff Layton, Marc Dionne, Trond Myklebust,
	Anna Schumaker, Mauro Carvalho Chehab, v9fs-developer, linux-afs,
	linux-nfs, linux-fsdevel, linux-doc, dhowells, linux-kernel

Hi Linus,

Do you want patches that quash warnings from W=1 (mostly kerneldoc warnings in
comments in this case[1]) at this point in the cycle, or would you rather they
waited till the next merge window?

David

[1] https://lore.kernel.org/r/163281899704.2790286.9177774252843775348.stgit@warthog.procyon.org.uk/


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Do you want warning quashing patches at this point in the cycle?
  2021-10-04 10:13 Do you want warning quashing patches at this point in the cycle? David Howells
@ 2021-10-04 16:38 ` Linus Torvalds
  0 siblings, 0 replies; 2+ messages in thread
From: Linus Torvalds @ 2021-10-04 16:38 UTC (permalink / raw)
  To: David Howells
  Cc: Dominique Martinet, Jeff Layton, Marc Dionne, Trond Myklebust,
	Anna Schumaker, Mauro Carvalho Chehab, v9fs-developer, linux-afs,
	open list:NFS, SUNRPC, AND...,
	linux-fsdevel, open list:DOCUMENTATION,
	Linux Kernel Mailing List

On Mon, Oct 4, 2021 at 3:13 AM David Howells <dhowells@redhat.com> wrote:
>
> Do you want patches that quash warnings from W=1

For W=1? No.

The kerneldoc ones might be ok, but actual code fixes have
historically been problematic because W=1 sometimes warns for
perfectly good code (and then people "fix" it to not warn, and
introduce actual bugs).

           Linus

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-10-04 16:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-04 10:13 Do you want warning quashing patches at this point in the cycle? David Howells
2021-10-04 16:38 ` Linus Torvalds

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).