* [PATCH] dt-bindings: mmc: arasan,sdci: drop unneeded clock-cells dependency
@ 2021-09-28 8:23 Krzysztof Kozlowski
2021-09-30 11:24 ` Ulf Hansson
2021-10-04 14:56 ` Rob Herring
0 siblings, 2 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2021-09-28 8:23 UTC (permalink / raw)
To: Ulf Hansson, Rob Herring, Adrian Hunter, linux-mmc, devicetree,
linux-kernel
Cc: Krzysztof Kozlowski
The meta-schema already defines dependency between clock-cells and
clock-output-names.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml | 4 ----
1 file changed, 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
index 23abb7e8b9d8..dd70431df0b7 100644
--- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
+++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
@@ -158,10 +158,6 @@ properties:
description:
The MIO bank number in which the command and data lines are configured.
-dependencies:
- clock-output-names: [ '#clock-cells' ]
- '#clock-cells': [ clock-output-names ]
-
required:
- compatible
- reg
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: mmc: arasan,sdci: drop unneeded clock-cells dependency
2021-09-28 8:23 [PATCH] dt-bindings: mmc: arasan,sdci: drop unneeded clock-cells dependency Krzysztof Kozlowski
@ 2021-09-30 11:24 ` Ulf Hansson
2021-10-04 14:56 ` Rob Herring
1 sibling, 0 replies; 4+ messages in thread
From: Ulf Hansson @ 2021-09-30 11:24 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Adrian Hunter, linux-mmc, DTML, Linux Kernel Mailing List
On Tue, 28 Sept 2021 at 10:23, Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> The meta-schema already defines dependency between clock-cells and
> clock-output-names.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
> index 23abb7e8b9d8..dd70431df0b7 100644
> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
> @@ -158,10 +158,6 @@ properties:
> description:
> The MIO bank number in which the command and data lines are configured.
>
> -dependencies:
> - clock-output-names: [ '#clock-cells' ]
> - '#clock-cells': [ clock-output-names ]
> -
> required:
> - compatible
> - reg
> --
> 2.30.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: mmc: arasan,sdci: drop unneeded clock-cells dependency
2021-09-28 8:23 [PATCH] dt-bindings: mmc: arasan,sdci: drop unneeded clock-cells dependency Krzysztof Kozlowski
2021-09-30 11:24 ` Ulf Hansson
@ 2021-10-04 14:56 ` Rob Herring
2021-10-04 14:59 ` Krzysztof Kozlowski
1 sibling, 1 reply; 4+ messages in thread
From: Rob Herring @ 2021-10-04 14:56 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Ulf Hansson, Adrian Hunter, linux-mmc, devicetree, linux-kernel
On Tue, Sep 28, 2021 at 10:23:46AM +0200, Krzysztof Kozlowski wrote:
> The meta-schema already defines dependency between clock-cells and
You mean the schema already does.
> clock-output-names.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
> Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
> index 23abb7e8b9d8..dd70431df0b7 100644
> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
> @@ -158,10 +158,6 @@ properties:
> description:
> The MIO bank number in which the command and data lines are configured.
>
> -dependencies:
> - clock-output-names: [ '#clock-cells' ]
The schema defines this.
> - '#clock-cells': [ clock-output-names ]
But not this. That's because in the common case, clock-output-names is
optional. But here it is required when '#clock-cells' is present.
Rob
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: mmc: arasan,sdci: drop unneeded clock-cells dependency
2021-10-04 14:56 ` Rob Herring
@ 2021-10-04 14:59 ` Krzysztof Kozlowski
0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2021-10-04 14:59 UTC (permalink / raw)
To: Rob Herring
Cc: Ulf Hansson, Adrian Hunter, linux-mmc, devicetree, linux-kernel
On 04/10/2021 16:56, Rob Herring wrote:
> On Tue, Sep 28, 2021 at 10:23:46AM +0200, Krzysztof Kozlowski wrote:
>> The meta-schema already defines dependency between clock-cells and
>
> You mean the schema already does.
Yes.
>
>> clock-output-names.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>> ---
>> Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml | 4 ----
>> 1 file changed, 4 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
>> index 23abb7e8b9d8..dd70431df0b7 100644
>> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
>> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
>> @@ -158,10 +158,6 @@ properties:
>> description:
>> The MIO bank number in which the command and data lines are configured.
>>
>> -dependencies:
>> - clock-output-names: [ '#clock-cells' ]
>
> The schema defines this.
>
>> - '#clock-cells': [ clock-output-names ]
>
> But not this. That's because in the common case, clock-output-names is
> optional. But here it is required when '#clock-cells' is present.
You are right, somehow I missed that part...
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-10-04 15:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-28 8:23 [PATCH] dt-bindings: mmc: arasan,sdci: drop unneeded clock-cells dependency Krzysztof Kozlowski
2021-09-30 11:24 ` Ulf Hansson
2021-10-04 14:56 ` Rob Herring
2021-10-04 14:59 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).