* [PATCH] drm: virtio: fix kconfig dependency warning
@ 2020-08-26 16:47 Randy Dunlap
2020-08-28 11:25 ` Gerd Hoffmann
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2020-08-26 16:47 UTC (permalink / raw)
To: LKML, linux-next, dri-devel, David Airlie, Gerd Hoffmann
From: Randy Dunlap <rdunlap@infradead.org>
Fix kconfig dependency warning by using a different Kconfig symbol.
WARNING: unmet direct dependencies detected for VIRTIO_DMA_SHARED_BUFFER
Depends on [n]: VIRTIO_MENU [=n] && DMA_SHARED_BUFFER [=y]
Selected by [y]:
- DRM_VIRTIO_GPU [=y] && HAS_IOMEM [=y] && DRM [=y] && VIRTIO [=y] && MMU [=y]
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: David Airlie <airlied@linux.ie>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: dri-devel@lists.freedesktop.org
Cc: virtualization@lists.linux-foundation.org
---
Found in linux-next but applies to mainline.
drivers/gpu/drm/virtio/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20200826.orig/drivers/gpu/drm/virtio/Kconfig
+++ linux-next-20200826/drivers/gpu/drm/virtio/Kconfig
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: GPL-2.0-only
config DRM_VIRTIO_GPU
tristate "Virtio GPU driver"
- depends on DRM && VIRTIO && MMU
+ depends on DRM && VIRTIO_MENU && MMU
select DRM_KMS_HELPER
select DRM_GEM_SHMEM_HELPER
select VIRTIO_DMA_SHARED_BUFFER
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm: virtio: fix kconfig dependency warning
2020-08-26 16:47 [PATCH] drm: virtio: fix kconfig dependency warning Randy Dunlap
@ 2020-08-28 11:25 ` Gerd Hoffmann
2020-08-28 14:01 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Gerd Hoffmann @ 2020-08-28 11:25 UTC (permalink / raw)
To: Randy Dunlap; +Cc: LKML, linux-next, dri-devel, David Airlie
Hi,
> config DRM_VIRTIO_GPU
> tristate "Virtio GPU driver"
> - depends on DRM && VIRTIO && MMU
> + depends on DRM && VIRTIO_MENU && MMU
Shouldn't this depend on both VIRTIO and VIRTIO_MENU, simliar to the
other virtio drivers?
take care,
Gerd
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm: virtio: fix kconfig dependency warning
2020-08-28 11:25 ` Gerd Hoffmann
@ 2020-08-28 14:01 ` Randy Dunlap
0 siblings, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2020-08-28 14:01 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: LKML, linux-next, dri-devel, David Airlie
On 8/28/20 4:25 AM, Gerd Hoffmann wrote:
> Hi,
>
>> config DRM_VIRTIO_GPU
>> tristate "Virtio GPU driver"
>> - depends on DRM && VIRTIO && MMU
>> + depends on DRM && VIRTIO_MENU && MMU
>
> Shouldn't this depend on both VIRTIO and VIRTIO_MENU, simliar to the
> other virtio drivers?
OK, I'll send a v2.
thanks.
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-28 14:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-26 16:47 [PATCH] drm: virtio: fix kconfig dependency warning Randy Dunlap
2020-08-28 11:25 ` Gerd Hoffmann
2020-08-28 14:01 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).