From: Reinette Chatre <reinette.chatre@intel.com>
To: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
Fenghua Yu <fenghua.yu@intel.com>, Shuah Khan <shuah@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH 1/3] selftests/resctrl: Make resctrl_tests run using kselftest framework
Date: Mon, 29 Nov 2021 11:27:27 -0800 [thread overview]
Message-ID: <08708d7a-4d34-3817-032f-25698a30551c@intel.com> (raw)
In-Reply-To: <20211110093315.3219191-2-tan.shaopeng@jp.fujitsu.com>
Hi Shaopeng Tan,
On 11/10/2021 1:33 AM, Shaopeng Tan wrote:
> From: "Tan, Shaopeng" <tan.shaopeng@jp.fujitsu.com>
>
> This commit enables kselftest to be built/run in resctrl framework.
> Build/run resctrl_tests by build/run all tests of kselftest, or by using
> the "TARGETS" variable on the make command line to specify resctrl_tests.
> To make resctrl_tests run using kselftest framework, this commit modified
> the Makefile of kernel kselftest set and the Makefile of resctrl_tests.
The above sentence mentions that changes were made to the resctrl
selftest Makefile but it does not describe what the change accomplish or
why they are needed. Could you please elaborate?
> To ensure the resctrl_tests finish in limited time, this commit changed
> the default limited time(45s) to 120 seconds for resctrl_tests by adding
> "setting" file.
How is changing the timeout related to the resctrl framework changes? Is
it not a separate change?
Thank you
Reinette
next prev parent reply other threads:[~2021-11-29 19:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-10 9:33 [PATCH 0/3] selftests/resctrl: Add resctrl_tests into kselftest set Shaopeng Tan
2021-11-10 9:33 ` [PATCH 1/3] selftests/resctrl: Make resctrl_tests run using kselftest framework Shaopeng Tan
2021-11-29 19:27 ` Reinette Chatre [this message]
2021-12-01 2:36 ` tan.shaopeng
2021-12-02 0:18 ` Reinette Chatre
2021-12-03 7:21 ` tan.shaopeng
2021-12-03 23:08 ` Reinette Chatre
2021-12-06 6:57 ` tan.shaopeng
2021-12-06 15:23 ` Reinette Chatre
2021-11-10 9:33 ` [PATCH 2/3] selftests/resctrl: Return KSFT_SKIP(4) if resctrl filessystem is not supported or resctrl is not run as root Shaopeng Tan
2021-11-29 19:27 ` Reinette Chatre
2021-12-01 2:36 ` tan.shaopeng
2021-12-02 0:39 ` Reinette Chatre
2021-11-10 9:33 ` [PATCH 3/3] selftests/resctrl: Kill the child process created by fork() when the SIGTERM signal comes Shaopeng Tan
2021-11-24 11:00 ` [PATCH 0/3] selftests/resctrl: Add resctrl_tests into kselftest set tan.shaopeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08708d7a-4d34-3817-032f-25698a30551c@intel.com \
--to=reinette.chatre@intel.com \
--cc=fenghua.yu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=tan.shaopeng@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).