linux-kselftest.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Hubbard <jhubbard@nvidia.com>
To: Jan Kara <jack@suse.cz>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
	"Al Viro" <viro@zeniv.linux.org.uk>,
	"Christoph Hellwig" <hch@infradead.org>,
	"Dan Williams" <dan.j.williams@intel.com>,
	"Dave Chinner" <david@fromorbit.com>,
	"Ira Weiny" <ira.weiny@intel.com>,
	"Jason Gunthorpe" <jgg@ziepe.ca>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Jérôme Glisse" <jglisse@redhat.com>,
	"Kirill A . Shutemov" <kirill@shutemov.name>,
	"Michal Hocko" <mhocko@suse.com>,
	"Mike Kravetz" <mike.kravetz@oracle.com>,
	"Shuah Khan" <shuah@kernel.org>,
	"Vlastimil Babka" <vbabka@suse.cz>,
	"Matthew Wilcox" <willy@infradead.org>,
	linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-kselftest@vger.kernel.org, linux-rdma@vger.kernel.org,
	linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 10/12] mm/gup: /proc/vmstat: pin_user_pages (FOLL_PIN) reporting
Date: Wed, 5 Feb 2020 15:13:27 -0800	[thread overview]
Message-ID: <09b49b0d-85cc-87b8-9176-0963f6c8c735@nvidia.com> (raw)
In-Reply-To: <20200205093733.GB28058@quack2.suse.cz>

On 2/5/20 1:37 AM, Jan Kara wrote:
> ...
> 
>> @@ -104,6 +106,9 @@ static __maybe_unused struct page *try_grab_compound_head(struct page *page,
>>  		if (hpage_pincount_available(page))
>>  			hpage_pincount_add(page, refs);
>>  
>> +		mod_node_page_state(page_pgdat(page), NR_FOLL_PIN_ACQUIRED,
>> +				    orig_refs);
>> +
>>  		return page;
>>  	}
>>  
> 
> It seems to me you miss mod_node_page_state() in put_compound_head(), don't
> you?


Yes, that was definitely missing. I've added this for the next version:


diff --git a/mm/gup.c b/mm/gup.c
index 7c543849181b..ae503c51bc7f 100644
--- a/mm/gup.c
+++ b/mm/gup.c
@@ -2268,6 +2268,8 @@ static int record_subpages(struct page *page, unsigned long addr,
 
 static void put_compound_head(struct page *page, int refs, unsigned int flags)
 {
+       int orig_refs = refs;
+
        if (flags & FOLL_PIN) {
                if (hpage_pincount_available(page))
                        hpage_pincount_sub(page, refs);
@@ -2283,6 +2285,8 @@ static void put_compound_head(struct page *page, int refs, unsigned int flags)
        if (refs > 1)
                page_ref_sub(page, refs - 1);
        put_page(page);
+
+       mod_node_page_state(page_pgdat(page), NR_FOLL_PIN_RELEASED, orig_refs);
 }
 
 #ifdef CONFIG_ARCH_HAS_HUGEPD



> 
> Otherwise I like the new stat names better :).
> 
> 								Honza
> 

Glad to hear that! :)

thanks,
-- 
John Hubbard
NVIDIA

  reply	other threads:[~2020-02-05 23:13 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-04 23:41 [PATCH v4 00/12] mm/gup: track FOLL_PIN pages John Hubbard
2020-02-04 23:41 ` [PATCH v4 01/12] mm: dump_page(): better diagnostics for compound pages John Hubbard
2020-02-04 23:41 ` [PATCH v4 02/12] mm/gup: split get_user_pages_remote() into two routines John Hubbard
2020-02-04 23:41 ` [PATCH v4 03/12] mm/gup: pass a flags arg to __gup_device_* functions John Hubbard
2020-02-04 23:41 ` [PATCH v4 04/12] mm: introduce page_ref_sub_return() John Hubbard
2020-02-05  9:23   ` Jan Kara
2020-02-05 11:23   ` Kirill A. Shutemov
2020-02-04 23:41 ` [PATCH v4 05/12] mm/gup: pass gup flags to two more routines John Hubbard
2020-02-04 23:41 ` [PATCH v4 06/12] mm/gup: require FOLL_GET for get_user_pages_fast() John Hubbard
2020-02-04 23:41 ` [PATCH v4 07/12] mm/gup: track FOLL_PIN pages John Hubbard
2020-02-05 11:35   ` Kirill A. Shutemov
2020-02-04 23:41 ` [PATCH v4 08/12] mm/gup: page->hpage_pinned_refcount: exact pin counts for huge pages John Hubbard
2020-02-04 23:41 ` [PATCH v4 09/12] mm: dump_page(): better diagnostics for huge pinned pages John Hubbard
2020-02-04 23:41 ` [PATCH v4 10/12] mm/gup: /proc/vmstat: pin_user_pages (FOLL_PIN) reporting John Hubbard
2020-02-05  9:37   ` Jan Kara
2020-02-05 23:13     ` John Hubbard [this message]
2020-02-05 11:43   ` Kirill A. Shutemov
2020-02-05 23:58     ` John Hubbard
2020-02-04 23:41 ` [PATCH v4 11/12] mm/gup_benchmark: support pin_user_pages() and related calls John Hubbard
2020-02-05 11:46   ` Kirill A. Shutemov
2020-02-04 23:41 ` [PATCH v4 12/12] selftests/vm: run_vmtests: invoke gup_benchmark with basic FOLL_PIN coverage John Hubbard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=09b49b0d-85cc-87b8-9176-0963f6c8c735@nvidia.com \
    --to=jhubbard@nvidia.com \
    --cc=akpm@linux-foundation.org \
    --cc=corbet@lwn.net \
    --cc=dan.j.williams@intel.com \
    --cc=david@fromorbit.com \
    --cc=hch@infradead.org \
    --cc=ira.weiny@intel.com \
    --cc=jack@suse.cz \
    --cc=jgg@ziepe.ca \
    --cc=jglisse@redhat.com \
    --cc=kirill@shutemov.name \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=mhocko@suse.com \
    --cc=mike.kravetz@oracle.com \
    --cc=shuah@kernel.org \
    --cc=vbabka@suse.cz \
    --cc=viro@zeniv.linux.org.uk \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).