From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: John Hubbard <jhubbard@nvidia.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
"Al Viro" <viro@zeniv.linux.org.uk>,
"Christoph Hellwig" <hch@infradead.org>,
"Dan Williams" <dan.j.williams@intel.com>,
"Dave Chinner" <david@fromorbit.com>,
"Ira Weiny" <ira.weiny@intel.com>, "Jan Kara" <jack@suse.cz>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"Jonathan Corbet" <corbet@lwn.net>,
"Jérôme Glisse" <jglisse@redhat.com>,
"Michal Hocko" <mhocko@suse.com>,
"Mike Kravetz" <mike.kravetz@oracle.com>,
"Shuah Khan" <shuah@kernel.org>,
"Vlastimil Babka" <vbabka@suse.cz>,
"Matthew Wilcox" <willy@infradead.org>,
linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 11/12] mm/gup_benchmark: support pin_user_pages() and related calls
Date: Wed, 5 Feb 2020 14:46:12 +0300 [thread overview]
Message-ID: <20200205114612.foo7zrcplgxwmylt@box> (raw)
In-Reply-To: <20200204234117.2974687-12-jhubbard@nvidia.com>
On Tue, Feb 04, 2020 at 03:41:16PM -0800, John Hubbard wrote:
> Up until now, gup_benchmark supported testing of the
> following kernel functions:
>
> * get_user_pages(): via the '-U' command line option
> * get_user_pages_longterm(): via the '-L' command line option
> * get_user_pages_fast(): as the default (no options required)
>
> Add test coverage for the new corresponding pin_*() functions:
>
> * pin_user_pages_fast(): via the '-a' command line option
> * pin_user_pages(): via the '-b' command line option
>
> Also, add an option for clarity: '-u' for what is now (still) the
> default choice: get_user_pages_fast().
>
> Also, for the commands that set FOLL_PIN, verify that the pages
> really are dma-pinned, via the new is_dma_pinned() routine.
> Those commands are:
>
> PIN_FAST_BENCHMARK : calls pin_user_pages_fast()
> PIN_BENCHMARK : calls pin_user_pages()
>
> In between the calls to pin_*() and unpin_user_pages(),
> check each page: if page_maybe_dma_pinned() returns false, then
> WARN and return.
>
> Do this outside of the benchmark timestamps, so that it doesn't
> affect reported times.
>
> Reviewed-by: Ira Weiny <ira.weiny@intel.com>
> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
--
Kirill A. Shutemov
next prev parent reply other threads:[~2020-02-05 11:46 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 23:41 [PATCH v4 00/12] mm/gup: track FOLL_PIN pages John Hubbard
2020-02-04 23:41 ` [PATCH v4 01/12] mm: dump_page(): better diagnostics for compound pages John Hubbard
2020-02-04 23:41 ` [PATCH v4 02/12] mm/gup: split get_user_pages_remote() into two routines John Hubbard
2020-02-04 23:41 ` [PATCH v4 03/12] mm/gup: pass a flags arg to __gup_device_* functions John Hubbard
2020-02-04 23:41 ` [PATCH v4 04/12] mm: introduce page_ref_sub_return() John Hubbard
2020-02-05 9:23 ` Jan Kara
2020-02-05 11:23 ` Kirill A. Shutemov
2020-02-04 23:41 ` [PATCH v4 05/12] mm/gup: pass gup flags to two more routines John Hubbard
2020-02-04 23:41 ` [PATCH v4 06/12] mm/gup: require FOLL_GET for get_user_pages_fast() John Hubbard
2020-02-04 23:41 ` [PATCH v4 07/12] mm/gup: track FOLL_PIN pages John Hubbard
2020-02-05 11:35 ` Kirill A. Shutemov
2020-02-04 23:41 ` [PATCH v4 08/12] mm/gup: page->hpage_pinned_refcount: exact pin counts for huge pages John Hubbard
2020-02-04 23:41 ` [PATCH v4 09/12] mm: dump_page(): better diagnostics for huge pinned pages John Hubbard
2020-02-04 23:41 ` [PATCH v4 10/12] mm/gup: /proc/vmstat: pin_user_pages (FOLL_PIN) reporting John Hubbard
2020-02-05 9:37 ` Jan Kara
2020-02-05 23:13 ` John Hubbard
2020-02-05 11:43 ` Kirill A. Shutemov
2020-02-05 23:58 ` John Hubbard
2020-02-04 23:41 ` [PATCH v4 11/12] mm/gup_benchmark: support pin_user_pages() and related calls John Hubbard
2020-02-05 11:46 ` Kirill A. Shutemov [this message]
2020-02-04 23:41 ` [PATCH v4 12/12] selftests/vm: run_vmtests: invoke gup_benchmark with basic FOLL_PIN coverage John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200205114612.foo7zrcplgxwmylt@box \
--to=kirill@shutemov.name \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=ira.weiny@intel.com \
--cc=jack@suse.cz \
--cc=jgg@ziepe.ca \
--cc=jglisse@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=mike.kravetz@oracle.com \
--cc=shuah@kernel.org \
--cc=vbabka@suse.cz \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).