From: john.fastabend at gmail.com (John Fastabend)
Subject: [PATCH bpf-next v4 1/5] selftests/bpf: test_sockmap, check test failure
Date: Fri, 1 Jun 2018 07:04:40 -0700 [thread overview]
Message-ID: <0bc10468-cee4-978d-9f7b-10463a8506ba@gmail.com> (raw)
In-Reply-To: <20180531044240.796-2-bhole_prashant_q7@lab.ntt.co.jp>
On 05/30/2018 09:42 PM, Prashant Bhole wrote:
> Test failures are not identified because exit code of RX/TX threads
> is not checked. Also threads are not returning correct exit code.
>
> - Return exit code from threads depending on test execution status
> - In main thread, check the exit code of RX/TX threads
> - Skip error checking for corked tests as they are expected to timeout
>
> Fixes: 16962b2404ac ("bpf: sockmap, add selftests")
> Signed-off-by: Prashant Bhole <bhole_prashant_q7 at lab.ntt.co.jp>
> ---
Acked-by: John Fastabend <john.fastabend at gmail.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: john.fastabend@gmail.com (John Fastabend)
Subject: [PATCH bpf-next v4 1/5] selftests/bpf: test_sockmap, check test failure
Date: Fri, 1 Jun 2018 07:04:40 -0700 [thread overview]
Message-ID: <0bc10468-cee4-978d-9f7b-10463a8506ba@gmail.com> (raw)
Message-ID: <20180601140440.4rYSF5SqC9yYn-pgjKloxzDvjmFGd_v7X4jOL6dVZlQ@z> (raw)
In-Reply-To: <20180531044240.796-2-bhole_prashant_q7@lab.ntt.co.jp>
On 05/30/2018 09:42 PM, Prashant Bhole wrote:
> Test failures are not identified because exit code of RX/TX threads
> is not checked. Also threads are not returning correct exit code.
>
> - Return exit code from threads depending on test execution status
> - In main thread, check the exit code of RX/TX threads
> - Skip error checking for corked tests as they are expected to timeout
>
> Fixes: 16962b2404ac ("bpf: sockmap, add selftests")
> Signed-off-by: Prashant Bhole <bhole_prashant_q7 at lab.ntt.co.jp>
> ---
Acked-by: John Fastabend <john.fastabend at gmail.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-06-01 14:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-31 4:42 [PATCH bpf-next v4 0/5] fix test_sockmap bhole_prashant_q7
2018-05-31 4:42 ` Prashant Bhole
2018-05-31 4:42 ` [PATCH bpf-next v4 1/5] selftests/bpf: test_sockmap, check test failure bhole_prashant_q7
2018-05-31 4:42 ` Prashant Bhole
2018-06-01 14:04 ` john.fastabend [this message]
2018-06-01 14:04 ` John Fastabend
2018-05-31 4:42 ` [PATCH bpf-next v4 2/5] selftests/bpf: test_sockmap, join cgroup in selftest mode bhole_prashant_q7
2018-05-31 4:42 ` Prashant Bhole
2018-05-31 4:42 ` [PATCH bpf-next v4 3/5] selftests/bpf: test_sockmap, timing improvements bhole_prashant_q7
2018-05-31 4:42 ` Prashant Bhole
2018-06-01 14:11 ` john.fastabend
2018-06-01 14:11 ` John Fastabend
2018-05-31 4:42 ` [PATCH bpf-next v4 4/5] selftests/bpf: test_sockmap, fix data verification bhole_prashant_q7
2018-05-31 4:42 ` Prashant Bhole
2018-05-31 4:42 ` [PATCH bpf-next v4 5/5] selftests/bpf: test_sockmap, print additional test options bhole_prashant_q7
2018-05-31 4:42 ` Prashant Bhole
2018-06-02 4:16 ` [PATCH bpf-next v4 0/5] fix test_sockmap daniel
2018-06-02 4:16 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0bc10468-cee4-978d-9f7b-10463a8506ba@gmail.com \
--to=linux-kselftest@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).