[PATCH] kselftest: arm64: Remove redundant clean target

[PATCH] kselftest: arm64: Remove redundant clean target

[Mark Brown]

The arm64 signal tests generate warnings during build since both they and
the toplevel lib.mk define a clean target:

Makefile:25: warning: overriding recipe for target 'clean'
../../lib.mk:126: warning: ignoring old recipe for target 'clean'

Since the inclusion of lib.mk is in the signal Makefile there is no
situation where this warning could be avoided so just remove the redundant
clean target.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 tools/testing/selftests/arm64/signal/Makefile | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/tools/testing/selftests/arm64/signal/Makefile b/tools/testing/selftests/arm64/signal/Makefile
index b497cfea4643..ac4ad0005715 100644
--- a/tools/testing/selftests/arm64/signal/Makefile
+++ b/tools/testing/selftests/arm64/signal/Makefile
@@ -21,10 +21,6 @@ include ../../lib.mk
 $(TEST_GEN_PROGS): $(PROGS)
 	cp $(PROGS) $(OUTPUT)/
 
-clean:
-	$(CLEAN)
-	rm -f $(PROGS)
-
 # Common test-unit targets to build common-layout test-cases executables
 # Needs secondary expansion to properly include the testcase c-file in pre-reqs
 .SECONDEXPANSION:
-- 
2.20.1

Re: [PATCH] kselftest: arm64: Remove redundant clean target

[Will Deacon]

On Wed, 24 Jun 2020 11:49:33 +0100, Mark Brown wrote:
> The arm64 signal tests generate warnings during build since both they and
> the toplevel lib.mk define a clean target:
> 
> Makefile:25: warning: overriding recipe for target 'clean'
> ../../lib.mk:126: warning: ignoring old recipe for target 'clean'
> 
> Since the inclusion of lib.mk is in the signal Makefile there is no
> situation where this warning could be avoided so just remove the redundant
> clean target.

Applied to arm64 (for-next/fixes), thanks!

[1/1] kselftest: arm64: Remove redundant clean target
      https://git.kernel.org/arm64/c/cb944f02d0d8

Cheers,
-- 
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev