linux-kselftest.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: linuxram@us.ibm.com (Ram Pai)
Subject: [Linux-kselftest-mirror] [PATCH v10 06/24] selftests/vm: fix the wrong assert in pkey_disable_set()
Date: Mon, 22 Jan 2018 10:51:59 -0800	[thread overview]
Message-ID: <1516647137-11174-7-git-send-email-linuxram@us.ibm.com> (raw)
Message-ID: <20180122185159.9iVpnH1xmXx5piTQmG3XYY2xSCYL3yfCuZsXWkDE76Y@z> (raw)
In-Reply-To: <1516647137-11174-1-git-send-email-linuxram@us.ibm.com>

If the flag is 0, no bits will be set. Hence we cant expect
the resulting bitmap to have a higher value than what it
was earlier.

Signed-off-by: Ram Pai <linuxram at us.ibm.com>
---
 tools/testing/selftests/vm/protection_keys.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/testing/selftests/vm/protection_keys.c b/tools/testing/selftests/vm/protection_keys.c
index 83216c5..0109388 100644
--- a/tools/testing/selftests/vm/protection_keys.c
+++ b/tools/testing/selftests/vm/protection_keys.c
@@ -443,7 +443,7 @@ void pkey_disable_set(int pkey, int flags)
 	dprintf1("%s(%d) pkey_reg: 0x%lx\n",
 		__func__, pkey, rdpkey_reg());
 	if (flags)
-		pkey_assert(rdpkey_reg() > orig_pkey_reg);
+		pkey_assert(rdpkey_reg() >= orig_pkey_reg);
 	dprintf1("END<---%s(%d, 0x%x)\n", __func__,
 		pkey, flags);
 }
-- 
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2018-01-22 18:51 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-22 18:51 [Linux-kselftest-mirror] [PATCH v10 00/24] selftests, powerpc, x86 : Memory Protection Keys linuxram
2018-01-22 18:51 ` Ram Pai
2018-01-22 18:51 ` [Linux-kselftest-mirror] [PATCH v10 01/24] selftests/x86: Move protecton key selftest to arch neutral directory linuxram
2018-01-22 18:51   ` Ram Pai
2018-01-22 18:51 ` [Linux-kselftest-mirror] [PATCH v10 02/24] selftests/vm: rename all references to pkru to a generic name linuxram
2018-01-22 18:51   ` Ram Pai
2018-01-22 18:51 ` [Linux-kselftest-mirror] [PATCH v10 03/24] selftests/vm: move generic definitions to header file linuxram
2018-01-22 18:51   ` Ram Pai
2018-01-22 18:51 ` [Linux-kselftest-mirror] [PATCH v10 04/24] selftests/vm: typecast the pkey register linuxram
2018-01-22 18:51   ` Ram Pai
2018-01-22 18:51 ` [Linux-kselftest-mirror] [PATCH v10 05/24] selftests/vm: generic function to handle shadow key register linuxram
2018-01-22 18:51   ` Ram Pai
2018-01-22 18:51 ` linuxram [this message]
2018-01-22 18:51   ` [Linux-kselftest-mirror] [PATCH v10 06/24] selftests/vm: fix the wrong assert in pkey_disable_set() Ram Pai
2018-01-22 18:52 ` [Linux-kselftest-mirror] [PATCH v10 07/24] selftests/vm: fixed bugs in pkey_disable_clear() linuxram
2018-01-22 18:52   ` Ram Pai
2018-01-22 18:52 ` [Linux-kselftest-mirror] [PATCH v10 08/24] selftests/vm: clear the bits in shadow reg when a pkey is freed linuxram
2018-01-22 18:52   ` Ram Pai
2018-01-22 18:52 ` [Linux-kselftest-mirror] [PATCH v10 09/24] selftests/vm: fix alloc_random_pkey() to make it really random linuxram
2018-01-22 18:52   ` Ram Pai
2018-01-22 18:52 ` [Linux-kselftest-mirror] [PATCH v10 10/24] selftests/vm: introduce two arch independent abstraction linuxram
2018-01-22 18:52   ` Ram Pai
2018-01-22 18:52 ` [Linux-kselftest-mirror] [PATCH v10 11/24] selftests/vm: pkey register should match shadow pkey linuxram
2018-01-22 18:52   ` Ram Pai
2018-01-22 18:52 ` [Linux-kselftest-mirror] [PATCH v10 12/24] selftests/vm: generic cleanup linuxram
2018-01-22 18:52   ` Ram Pai
2018-01-22 18:52 ` [Linux-kselftest-mirror] [PATCH v10 13/24] selftests/vm: powerpc implementation for generic abstraction linuxram
2018-01-22 18:52   ` Ram Pai
2018-01-22 18:52 ` [Linux-kselftest-mirror] [PATCH v10 14/24] selftests/vm: clear the bits in shadow reg when a pkey is freed linuxram
2018-01-22 18:52   ` Ram Pai
2018-01-22 18:52 ` [Linux-kselftest-mirror] [PATCH v10 15/24] selftests/vm: powerpc implementation to check support for pkey linuxram
2018-01-22 18:52   ` Ram Pai
2018-01-22 18:52 ` [Linux-kselftest-mirror] [PATCH v10 16/24] selftests/vm: fix an assertion in test_pkey_alloc_exhaust() linuxram
2018-01-22 18:52   ` Ram Pai
2018-01-22 18:52 ` [Linux-kselftest-mirror] [PATCH v10 17/24] selftests/vm: associate key on a mapped page and detect access violation linuxram
2018-01-22 18:52   ` Ram Pai
2018-01-22 18:52 ` [Linux-kselftest-mirror] [PATCH v10 18/24] selftests/vm: associate key on a mapped page and detect write violation linuxram
2018-01-22 18:52   ` Ram Pai
2018-01-22 18:52 ` [Linux-kselftest-mirror] [PATCH v10 19/24] selftests/vm: detect write violation on a mapped access-denied-key page linuxram
2018-01-22 18:52   ` Ram Pai
2018-01-22 18:52 ` [Linux-kselftest-mirror] [PATCH v10 20/24] selftests/vm: testcases must restore pkey-permissions linuxram
2018-01-22 18:52   ` Ram Pai
2018-01-22 18:52 ` [Linux-kselftest-mirror] [PATCH v10 21/24] selftests/vm: sub-page allocator linuxram
2018-01-22 18:52   ` Ram Pai
2018-01-22 18:52 ` [Linux-kselftest-mirror] [PATCH v10 22/24] selftests/vm: Fix deadlock in protection_keys.c linuxram
2018-01-22 18:52   ` Ram Pai
2018-01-22 18:52 ` [Linux-kselftest-mirror] [PATCH v10 23/24] selftests/powerpc: Add ptrace tests for Protection Key register linuxram
2018-01-22 18:52   ` Ram Pai
2018-01-22 18:52 ` [Linux-kselftest-mirror] [PATCH v10 24/24] selftests/powerpc: Add core file test " linuxram
2018-01-22 18:52   ` Ram Pai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1516647137-11174-7-git-send-email-linuxram@us.ibm.com \
    --to=linuxram@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).