* [PATCH] test_firmware: fix setting old custom fw path back on exit, second try
@ 2018-04-03 19:48 ben.hutchings
2018-04-03 19:48 ` Ben Hutchings
2018-04-03 19:54 ` mcgrof
0 siblings, 2 replies; 8+ messages in thread
From: ben.hutchings @ 2018-04-03 19:48 UTC (permalink / raw)
Commit 65c79230576 tried to clear the custom firmware path on exit by
writing a single space to the firmware_class.path parameter. This
doesn't work because nothing strips this space from the value stored
and fw_get_filesystem_firmware() only ignores zero-length paths.
Instead, write a null byte.
Fixes: 0a8adf58475 ("test: add firmware_class loader test")
Fixes: 65c79230576 ("test_firmware: fix setting old custom fw path back on exit")
Signed-off-by: Ben Hutchings <ben.hutchings at codethink.co.uk>
---
tools/testing/selftests/firmware/fw_filesystem.sh | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/firmware/fw_filesystem.sh b/tools/testing/selftests/firmware/fw_filesystem.sh
index f9508e1a4058..6b63b6bf2661 100755
--- a/tools/testing/selftests/firmware/fw_filesystem.sh
+++ b/tools/testing/selftests/firmware/fw_filesystem.sh
@@ -46,9 +46,11 @@ test_finish()
echo "$OLD_TIMEOUT" >/sys/class/firmware/timeout
fi
if [ "$OLD_FWPATH" = "" ]; then
- OLD_FWPATH=" "
+ # A zero-length write won't work; write a null byte
+ printf '\000' >/sys/module/firmware_class/parameters/path
+ else
+ echo -n "$OLD_FWPATH" >/sys/module/firmware_class/parameters/path
fi
- echo -n "$OLD_FWPATH" >/sys/module/firmware_class/parameters/path
rm -f "$FW"
rmdir "$FWPATH"
}
--
2.16.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] test_firmware: fix setting old custom fw path back on exit, second try
2018-04-03 19:48 [PATCH] test_firmware: fix setting old custom fw path back on exit, second try ben.hutchings
@ 2018-04-03 19:48 ` Ben Hutchings
2018-04-03 19:54 ` mcgrof
1 sibling, 0 replies; 8+ messages in thread
From: Ben Hutchings @ 2018-04-03 19:48 UTC (permalink / raw)
Commit 65c79230576 tried to clear the custom firmware path on exit by
writing a single space to the firmware_class.path parameter. This
doesn't work because nothing strips this space from the value stored
and fw_get_filesystem_firmware() only ignores zero-length paths.
Instead, write a null byte.
Fixes: 0a8adf58475 ("test: add firmware_class loader test")
Fixes: 65c79230576 ("test_firmware: fix setting old custom fw path back on exit")
Signed-off-by: Ben Hutchings <ben.hutchings at codethink.co.uk>
---
tools/testing/selftests/firmware/fw_filesystem.sh | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/firmware/fw_filesystem.sh b/tools/testing/selftests/firmware/fw_filesystem.sh
index f9508e1a4058..6b63b6bf2661 100755
--- a/tools/testing/selftests/firmware/fw_filesystem.sh
+++ b/tools/testing/selftests/firmware/fw_filesystem.sh
@@ -46,9 +46,11 @@ test_finish()
echo "$OLD_TIMEOUT" >/sys/class/firmware/timeout
fi
if [ "$OLD_FWPATH" = "" ]; then
- OLD_FWPATH=" "
+ # A zero-length write won't work; write a null byte
+ printf '\000' >/sys/module/firmware_class/parameters/path
+ else
+ echo -n "$OLD_FWPATH" >/sys/module/firmware_class/parameters/path
fi
- echo -n "$OLD_FWPATH" >/sys/module/firmware_class/parameters/path
rm -f "$FW"
rmdir "$FWPATH"
}
--
2.16.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] test_firmware: fix setting old custom fw path back on exit, second try
2018-04-03 19:48 [PATCH] test_firmware: fix setting old custom fw path back on exit, second try ben.hutchings
2018-04-03 19:48 ` Ben Hutchings
@ 2018-04-03 19:54 ` mcgrof
2018-04-03 19:54 ` Luis R. Rodriguez
2018-04-03 20:10 ` ben.hutchings
1 sibling, 2 replies; 8+ messages in thread
From: mcgrof @ 2018-04-03 19:54 UTC (permalink / raw)
On Tue, Apr 3, 2018 at 12:48 PM, Ben Hutchings
<ben.hutchings at codethink.co.uk> wrote:
> Commit 65c79230576 tried to clear the custom firmware path on exit by
> writing a single space to the firmware_class.path parameter. This
> doesn't work because nothing strips this space from the value stored
> and fw_get_filesystem_firmware() only ignores zero-length paths.
>
> Instead, write a null byte.
>
> Fixes: 0a8adf58475 ("test: add firmware_class loader test")
> Fixes: 65c79230576 ("test_firmware: fix setting old custom fw path back on exit")
> Signed-off-by: Ben Hutchings <ben.hutchings at codethink.co.uk>
Thanks for the patch! Also can you re-send and address Greg and
linux-kernel ? There's significant changes to the firmware API on its
way to Linus to I think if we want to merge this it should go through
Greg at this point as he also merged some new changes I made to these
scripts.
> ---
> tools/testing/selftests/firmware/fw_filesystem.sh | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/firmware/fw_filesystem.sh b/tools/testing/selftests/firmware/fw_filesystem.sh
> index f9508e1a4058..6b63b6bf2661 100755
> --- a/tools/testing/selftests/firmware/fw_filesystem.sh
> +++ b/tools/testing/selftests/firmware/fw_filesystem.sh
> @@ -46,9 +46,11 @@ test_finish()
> echo "$OLD_TIMEOUT" >/sys/class/firmware/timeout
> fi
> if [ "$OLD_FWPATH" = "" ]; then
> - OLD_FWPATH=" "
> + # A zero-length write won't work; write a null byte
> + printf '\000' >/sys/module/firmware_class/parameters/path
> + else
> + echo -n "$OLD_FWPATH" >/sys/module/firmware_class/parameters/path
Odd I am pretty sure I tested this and it worked for me. Wonder what
it could have been... What shell are you using? I used bash.
Luis
> fi
> - echo -n "$OLD_FWPATH" >/sys/module/firmware_class/parameters/path
> rm -f "$FW"
> rmdir "$FWPATH"
> }
> --
> 2.16.2
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] test_firmware: fix setting old custom fw path back on exit, second try
2018-04-03 19:54 ` mcgrof
@ 2018-04-03 19:54 ` Luis R. Rodriguez
2018-04-03 20:10 ` ben.hutchings
1 sibling, 0 replies; 8+ messages in thread
From: Luis R. Rodriguez @ 2018-04-03 19:54 UTC (permalink / raw)
On Tue, Apr 3, 2018 at 12:48 PM, Ben Hutchings
<ben.hutchings@codethink.co.uk> wrote:
> Commit 65c79230576 tried to clear the custom firmware path on exit by
> writing a single space to the firmware_class.path parameter. This
> doesn't work because nothing strips this space from the value stored
> and fw_get_filesystem_firmware() only ignores zero-length paths.
>
> Instead, write a null byte.
>
> Fixes: 0a8adf58475 ("test: add firmware_class loader test")
> Fixes: 65c79230576 ("test_firmware: fix setting old custom fw path back on exit")
> Signed-off-by: Ben Hutchings <ben.hutchings at codethink.co.uk>
Thanks for the patch! Also can you re-send and address Greg and
linux-kernel ? There's significant changes to the firmware API on its
way to Linus to I think if we want to merge this it should go through
Greg at this point as he also merged some new changes I made to these
scripts.
> ---
> tools/testing/selftests/firmware/fw_filesystem.sh | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/firmware/fw_filesystem.sh b/tools/testing/selftests/firmware/fw_filesystem.sh
> index f9508e1a4058..6b63b6bf2661 100755
> --- a/tools/testing/selftests/firmware/fw_filesystem.sh
> +++ b/tools/testing/selftests/firmware/fw_filesystem.sh
> @@ -46,9 +46,11 @@ test_finish()
> echo "$OLD_TIMEOUT" >/sys/class/firmware/timeout
> fi
> if [ "$OLD_FWPATH" = "" ]; then
> - OLD_FWPATH=" "
> + # A zero-length write won't work; write a null byte
> + printf '\000' >/sys/module/firmware_class/parameters/path
> + else
> + echo -n "$OLD_FWPATH" >/sys/module/firmware_class/parameters/path
Odd I am pretty sure I tested this and it worked for me. Wonder what
it could have been... What shell are you using? I used bash.
Luis
> fi
> - echo -n "$OLD_FWPATH" >/sys/module/firmware_class/parameters/path
> rm -f "$FW"
> rmdir "$FWPATH"
> }
> --
> 2.16.2
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] test_firmware: fix setting old custom fw path back on exit, second try
2018-04-03 19:54 ` mcgrof
2018-04-03 19:54 ` Luis R. Rodriguez
@ 2018-04-03 20:10 ` ben.hutchings
2018-04-03 20:10 ` Ben Hutchings
2018-04-03 20:12 ` mcgrof
1 sibling, 2 replies; 8+ messages in thread
From: ben.hutchings @ 2018-04-03 20:10 UTC (permalink / raw)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 2827 bytes --]
On Tue, 2018-04-03 at 12:54 -0700, Luis R. Rodriguez wrote:
> On Tue, Apr 3, 2018 at 12:48 PM, Ben Hutchings
> > <ben.hutchings at codethink.co.uk> wrote:
> > Commit 65c79230576 tried to clear the custom firmware path on exit by
> > writing a single space to the firmware_class.path parameter. This
> > doesn't work because nothing strips this space from the value stored
> > and fw_get_filesystem_firmware() only ignores zero-length paths.
> >
> > Instead, write a null byte.
> >
> > Fixes: 0a8adf58475 ("test: add firmware_class loader test")
> > Fixes: 65c79230576 ("test_firmware: fix setting old custom fw path back on exit")
> > Signed-off-by: Ben Hutchings <ben.hutchings at codethink.co.uk>
>
> Thanks for the patch! Also can you re-send and address Greg and
> linux-kernel ? There's significant changes to the firmware API on its
> way to Linus to I think if we want to merge this it should go through
> Greg at this point as he also merged some new changes I made to these
> scripts.
OK.
> > ---
> > tools/testing/selftests/firmware/fw_filesystem.sh | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/tools/testing/selftests/firmware/fw_filesystem.sh b/tools/testing/selftests/firmware/fw_filesystem.sh
> > index f9508e1a4058..6b63b6bf2661 100755
> > --- a/tools/testing/selftests/firmware/fw_filesystem.sh
> > +++ b/tools/testing/selftests/firmware/fw_filesystem.sh
> > @@ -46,9 +46,11 @@ test_finish()
> > echo "$OLD_TIMEOUT" >/sys/class/firmware/timeout
> > fi
> > if [ "$OLD_FWPATH" = "" ]; then
> > - OLD_FWPATH=" "
> > + # A zero-length write won't work; write a null byte
> > + printf '\000' >/sys/module/firmware_class/parameters/path
> > + else
> > + echo -n "$OLD_FWPATH" >/sys/module/firmware_class/parameters/path
>
> Odd I am pretty sure I tested this and it worked for me. Wonder what
> it could have been... What shell are you using? I used bash.
Seems to work the same way for me whether I use bash (interactive) or
dash (script interpreter, /bin/sh). But there's no visual difference
between " \n" and "\n"; that's why I used od to show a hex dump in my
previous mail.
Ben.
> Luis
>
> > fi
> > - echo -n "$OLD_FWPATH" >/sys/module/firmware_class/parameters/path
> > rm -f "$FW"
> > rmdir "$FWPATH"
> > }
> > --
> > 2.16.2
> >
>
>
--
Ben Hutchings
Software Developer, Codethink Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] test_firmware: fix setting old custom fw path back on exit, second try
2018-04-03 20:10 ` ben.hutchings
@ 2018-04-03 20:10 ` Ben Hutchings
2018-04-03 20:12 ` mcgrof
1 sibling, 0 replies; 8+ messages in thread
From: Ben Hutchings @ 2018-04-03 20:10 UTC (permalink / raw)
On Tue, 2018-04-03@12:54 -0700, Luis R. Rodriguez wrote:
> On Tue, Apr 3, 2018 at 12:48 PM, Ben Hutchings
> > <ben.hutchings@codethink.co.uk> wrote:
> > Commit 65c79230576 tried to clear the custom firmware path on exit by
> > writing a single space to the firmware_class.path parameter. This
> > doesn't work because nothing strips this space from the value stored
> > and fw_get_filesystem_firmware() only ignores zero-length paths.
> >
> > Instead, write a null byte.
> >
> > Fixes: 0a8adf58475 ("test: add firmware_class loader test")
> > Fixes: 65c79230576 ("test_firmware: fix setting old custom fw path back on exit")
> > Signed-off-by: Ben Hutchings <ben.hutchings at codethink.co.uk>
>
> Thanks for the patch! Also can you re-send and address Greg and
> linux-kernel ? There's significant changes to the firmware API on its
> way to Linus to I think if we want to merge this it should go through
> Greg at this point as he also merged some new changes I made to these
> scripts.
OK.
> > ---
> > tools/testing/selftests/firmware/fw_filesystem.sh | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/tools/testing/selftests/firmware/fw_filesystem.sh b/tools/testing/selftests/firmware/fw_filesystem.sh
> > index f9508e1a4058..6b63b6bf2661 100755
> > --- a/tools/testing/selftests/firmware/fw_filesystem.sh
> > +++ b/tools/testing/selftests/firmware/fw_filesystem.sh
> > @@ -46,9 +46,11 @@ test_finish()
> > echo "$OLD_TIMEOUT" >/sys/class/firmware/timeout
> > fi
> > if [ "$OLD_FWPATH" = "" ]; then
> > - OLD_FWPATH=" "
> > + # A zero-length write won't work; write a null byte
> > + printf '\000' >/sys/module/firmware_class/parameters/path
> > + else
> > + echo -n "$OLD_FWPATH" >/sys/module/firmware_class/parameters/path
>
> Odd I am pretty sure I tested this and it worked for me. Wonder what
> it could have been... What shell are you using? I used bash.
Seems to work the same way for me whether I use bash (interactive) or
dash (script interpreter, /bin/sh). But there's no visual difference
between " \n" and "\n"; that's why I used od to show a hex dump in my
previous mail.
Ben.
> Luis
>
> > fi
> > - echo -n "$OLD_FWPATH" >/sys/module/firmware_class/parameters/path
> > rm -f "$FW"
> > rmdir "$FWPATH"
> > }
> > --
> > 2.16.2
> >
>
>
--
Ben Hutchings
Software Developer, Codethink Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] test_firmware: fix setting old custom fw path back on exit, second try
2018-04-03 20:10 ` ben.hutchings
2018-04-03 20:10 ` Ben Hutchings
@ 2018-04-03 20:12 ` mcgrof
2018-04-03 20:12 ` Luis R. Rodriguez
1 sibling, 1 reply; 8+ messages in thread
From: mcgrof @ 2018-04-03 20:12 UTC (permalink / raw)
On Tue, Apr 3, 2018 at 1:10 PM, Ben Hutchings
<ben.hutchings at codethink.co.uk> wrote:
> On Tue, 2018-04-03 at 12:54 -0700, Luis R. Rodriguez wrote:
>> On Tue, Apr 3, 2018 at 12:48 PM, Ben Hutchings
>> > <ben.hutchings at codethink.co.uk> wrote:
>> > Commit 65c79230576 tried to clear the custom firmware path on exit by
>> > writing a single space to the firmware_class.path parameter. This
>> > doesn't work because nothing strips this space from the value stored
>> > and fw_get_filesystem_firmware() only ignores zero-length paths.
>> >
>> > Instead, write a null byte.
>> >
>> > Fixes: 0a8adf58475 ("test: add firmware_class loader test")
>> > Fixes: 65c79230576 ("test_firmware: fix setting old custom fw path back on exit")
>> > Signed-off-by: Ben Hutchings <ben.hutchings at codethink.co.uk>
>>
>> Thanks for the patch! Also can you re-send and address Greg and
>> linux-kernel ? There's significant changes to the firmware API on its
>> way to Linus to I think if we want to merge this it should go through
>> Greg at this point as he also merged some new changes I made to these
>> scripts.
>
> OK.
Oh and if you can then base it also on Greg's driver-core tree on the
driver-core-next branch
>> > ---
>> > tools/testing/selftests/firmware/fw_filesystem.sh | 6 ++++--
>> > 1 file changed, 4 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/tools/testing/selftests/firmware/fw_filesystem.sh b/tools/testing/selftests/firmware/fw_filesystem.sh
>> > index f9508e1a4058..6b63b6bf2661 100755
>> > --- a/tools/testing/selftests/firmware/fw_filesystem.sh
>> > +++ b/tools/testing/selftests/firmware/fw_filesystem.sh
>> > @@ -46,9 +46,11 @@ test_finish()
>> > echo "$OLD_TIMEOUT" >/sys/class/firmware/timeout
>> > fi
>> > if [ "$OLD_FWPATH" = "" ]; then
>> > - OLD_FWPATH=" "
>> > + # A zero-length write won't work; write a null byte
>> > + printf '\000' >/sys/module/firmware_class/parameters/path
>> > + else
>> > + echo -n "$OLD_FWPATH" >/sys/module/firmware_class/parameters/path
>>
>> Odd I am pretty sure I tested this and it worked for me. Wonder what
>> it could have been... What shell are you using? I used bash.
>
> Seems to work the same way for me whether I use bash (interactive) or
> dash (script interpreter, /bin/sh). But there's no visual difference
> between " \n" and "\n"; that's why I used od to show a hex dump in my
> previous mail.
So odd, I'll test again with my qemu setup to verify again.
Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] test_firmware: fix setting old custom fw path back on exit, second try
2018-04-03 20:12 ` mcgrof
@ 2018-04-03 20:12 ` Luis R. Rodriguez
0 siblings, 0 replies; 8+ messages in thread
From: Luis R. Rodriguez @ 2018-04-03 20:12 UTC (permalink / raw)
On Tue, Apr 3, 2018 at 1:10 PM, Ben Hutchings
<ben.hutchings@codethink.co.uk> wrote:
> On Tue, 2018-04-03@12:54 -0700, Luis R. Rodriguez wrote:
>> On Tue, Apr 3, 2018 at 12:48 PM, Ben Hutchings
>> > <ben.hutchings@codethink.co.uk> wrote:
>> > Commit 65c79230576 tried to clear the custom firmware path on exit by
>> > writing a single space to the firmware_class.path parameter. This
>> > doesn't work because nothing strips this space from the value stored
>> > and fw_get_filesystem_firmware() only ignores zero-length paths.
>> >
>> > Instead, write a null byte.
>> >
>> > Fixes: 0a8adf58475 ("test: add firmware_class loader test")
>> > Fixes: 65c79230576 ("test_firmware: fix setting old custom fw path back on exit")
>> > Signed-off-by: Ben Hutchings <ben.hutchings at codethink.co.uk>
>>
>> Thanks for the patch! Also can you re-send and address Greg and
>> linux-kernel ? There's significant changes to the firmware API on its
>> way to Linus to I think if we want to merge this it should go through
>> Greg at this point as he also merged some new changes I made to these
>> scripts.
>
> OK.
Oh and if you can then base it also on Greg's driver-core tree on the
driver-core-next branch
>> > ---
>> > tools/testing/selftests/firmware/fw_filesystem.sh | 6 ++++--
>> > 1 file changed, 4 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/tools/testing/selftests/firmware/fw_filesystem.sh b/tools/testing/selftests/firmware/fw_filesystem.sh
>> > index f9508e1a4058..6b63b6bf2661 100755
>> > --- a/tools/testing/selftests/firmware/fw_filesystem.sh
>> > +++ b/tools/testing/selftests/firmware/fw_filesystem.sh
>> > @@ -46,9 +46,11 @@ test_finish()
>> > echo "$OLD_TIMEOUT" >/sys/class/firmware/timeout
>> > fi
>> > if [ "$OLD_FWPATH" = "" ]; then
>> > - OLD_FWPATH=" "
>> > + # A zero-length write won't work; write a null byte
>> > + printf '\000' >/sys/module/firmware_class/parameters/path
>> > + else
>> > + echo -n "$OLD_FWPATH" >/sys/module/firmware_class/parameters/path
>>
>> Odd I am pretty sure I tested this and it worked for me. Wonder what
>> it could have been... What shell are you using? I used bash.
>
> Seems to work the same way for me whether I use bash (interactive) or
> dash (script interpreter, /bin/sh). But there's no visual difference
> between " \n" and "\n"; that's why I used od to show a hex dump in my
> previous mail.
So odd, I'll test again with my qemu setup to verify again.
Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-04-03 20:12 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-03 19:48 [PATCH] test_firmware: fix setting old custom fw path back on exit, second try ben.hutchings
2018-04-03 19:48 ` Ben Hutchings
2018-04-03 19:54 ` mcgrof
2018-04-03 19:54 ` Luis R. Rodriguez
2018-04-03 20:10 ` ben.hutchings
2018-04-03 20:10 ` Ben Hutchings
2018-04-03 20:12 ` mcgrof
2018-04-03 20:12 ` Luis R. Rodriguez
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).