linux-kselftest.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: gregkh@linuxfoundation.org (Greg KH)
Subject: [PATCH v4 1/2] char: sparc64: Add privileged ADI driver
Date: Sat, 21 Apr 2018 11:04:49 +0200	[thread overview]
Message-ID: <20180421090449.GA8194@kroah.com> (raw)
Message-ID: <20180421090449.4izXeVYZglefBPnQdpFvANy6P3_F1Rd-qDTFoSxcj3I@z> (raw)
In-Reply-To: <20180420205221.488589-2-tom.hromatka@oracle.com>

On Fri, Apr 20, 2018@02:52:20PM -0600, Tom Hromatka wrote:
> --- /dev/null
> +++ b/drivers/char/adi.c
> @@ -0,0 +1,240 @@
> +// SPDX-License-Identifier: GPL-2.0

Good, but:

> +MODULE_LICENSE("GPL");

That's the wrong line :(

Read include/linux/module.h for the correct string to put here for a
GPL version 2 only module.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2018-04-21  9:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-20 20:52 [PATCH v4 0/2] sparc64: Add privileged ADI driver tom.hromatka
2018-04-20 20:52 ` Tom Hromatka
2018-04-20 20:52 ` [PATCH v4 1/2] char: " tom.hromatka
2018-04-20 20:52   ` Tom Hromatka
2018-04-21  9:04   ` gregkh [this message]
2018-04-21  9:04     ` Greg KH
2018-04-22 21:52     ` tom.hromatka
2018-04-22 21:52       ` Tom Hromatka
2018-04-20 20:52 ` [PATCH v4 2/2] selftests: sparc64: char: Selftest for " tom.hromatka
2018-04-20 20:52   ` Tom Hromatka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180421090449.GA8194@kroah.com \
    --to=gregkh@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).