* [PATCH driver-core 1/2] test_firmware: Install all scripts
@ 2018-04-04 20:37 ben.hutchings
2018-04-04 20:37 ` Ben Hutchings
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: ben.hutchings @ 2018-04-04 20:37 UTC (permalink / raw)
List all the scripts invoked by fw_run_tests.sh, so that
"make TARGETS=firmware install" keeps working.
Fixes: 29a1c00ce1df8 ("test_firmware: add simple firmware firmware test ...")
Fixes: b3cf21fae1fe0 ("test_firmware: test three firmware kernel configs ...")
Signed-off-by: Ben Hutchings <ben.hutchings at codethink.co.uk>
---
tools/testing/selftests/firmware/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/firmware/Makefile b/tools/testing/selftests/firmware/Makefile
index 826f38d5dd19..261c81f08606 100644
--- a/tools/testing/selftests/firmware/Makefile
+++ b/tools/testing/selftests/firmware/Makefile
@@ -4,6 +4,7 @@
all:
TEST_PROGS := fw_run_tests.sh
+TEST_FILES := fw_fallback.sh fw_filesystem.sh fw_lib.sh
include ../lib.mk
--
2.16.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH driver-core 1/2] test_firmware: Install all scripts
2018-04-04 20:37 [PATCH driver-core 1/2] test_firmware: Install all scripts ben.hutchings
@ 2018-04-04 20:37 ` Ben Hutchings
2018-04-04 20:38 ` [PATCH driver-core 2/2] test_firmware: fix setting old custom fw path back on exit, second try ben.hutchings
2018-04-18 20:35 ` [PATCH driver-core 1/2] test_firmware: Install all scripts mcgrof
2 siblings, 0 replies; 10+ messages in thread
From: Ben Hutchings @ 2018-04-04 20:37 UTC (permalink / raw)
List all the scripts invoked by fw_run_tests.sh, so that
"make TARGETS=firmware install" keeps working.
Fixes: 29a1c00ce1df8 ("test_firmware: add simple firmware firmware test ...")
Fixes: b3cf21fae1fe0 ("test_firmware: test three firmware kernel configs ...")
Signed-off-by: Ben Hutchings <ben.hutchings at codethink.co.uk>
---
tools/testing/selftests/firmware/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/firmware/Makefile b/tools/testing/selftests/firmware/Makefile
index 826f38d5dd19..261c81f08606 100644
--- a/tools/testing/selftests/firmware/Makefile
+++ b/tools/testing/selftests/firmware/Makefile
@@ -4,6 +4,7 @@
all:
TEST_PROGS := fw_run_tests.sh
+TEST_FILES := fw_fallback.sh fw_filesystem.sh fw_lib.sh
include ../lib.mk
--
2.16.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH driver-core 2/2] test_firmware: fix setting old custom fw path back on exit, second try
2018-04-04 20:37 [PATCH driver-core 1/2] test_firmware: Install all scripts ben.hutchings
2018-04-04 20:37 ` Ben Hutchings
@ 2018-04-04 20:38 ` ben.hutchings
2018-04-04 20:38 ` Ben Hutchings
2018-04-18 20:38 ` mcgrof
2018-04-18 20:35 ` [PATCH driver-core 1/2] test_firmware: Install all scripts mcgrof
2 siblings, 2 replies; 10+ messages in thread
From: ben.hutchings @ 2018-04-04 20:38 UTC (permalink / raw)
Commit 65c79230576 tried to clear the custom firmware path on exit by
writing a single space to the firmware_class.path parameter. This
doesn't work because nothing strips this space from the value stored
and fw_get_filesystem_firmware() only ignores zero-length paths.
Instead, write a null byte.
Fixes: 0a8adf58475 ("test: add firmware_class loader test")
Fixes: 65c79230576 ("test_firmware: fix setting old custom fw path back on exit")
Signed-off-by: Ben Hutchings <ben.hutchings at codethink.co.uk>
---
tools/testing/selftests/firmware/fw_lib.sh | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/tools/testing/selftests/firmware/fw_lib.sh b/tools/testing/selftests/firmware/fw_lib.sh
index 9ea31b57d71a..962d7f4ac627 100755
--- a/tools/testing/selftests/firmware/fw_lib.sh
+++ b/tools/testing/selftests/firmware/fw_lib.sh
@@ -154,11 +154,13 @@ test_finish()
if [ "$HAS_FW_LOADER_USER_HELPER" = "yes" ]; then
echo "$OLD_TIMEOUT" >/sys/class/firmware/timeout
fi
- if [ "$OLD_FWPATH" = "" ]; then
- OLD_FWPATH=" "
- fi
if [ "$TEST_REQS_FW_SET_CUSTOM_PATH" = "yes" ]; then
- echo -n "$OLD_FWPATH" >/sys/module/firmware_class/parameters/path
+ if [ "$OLD_FWPATH" = "" ]; then
+ # A zero-length write won't work; write a null byte
+ printf '\000' >/sys/module/firmware_class/parameters/path
+ else
+ echo -n "$OLD_FWPATH" >/sys/module/firmware_class/parameters/path
+ fi
fi
if [ -f $FW ]; then
rm -f "$FW"
--
2.16.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH driver-core 2/2] test_firmware: fix setting old custom fw path back on exit, second try
2018-04-04 20:38 ` [PATCH driver-core 2/2] test_firmware: fix setting old custom fw path back on exit, second try ben.hutchings
@ 2018-04-04 20:38 ` Ben Hutchings
2018-04-18 20:38 ` mcgrof
1 sibling, 0 replies; 10+ messages in thread
From: Ben Hutchings @ 2018-04-04 20:38 UTC (permalink / raw)
Commit 65c79230576 tried to clear the custom firmware path on exit by
writing a single space to the firmware_class.path parameter. This
doesn't work because nothing strips this space from the value stored
and fw_get_filesystem_firmware() only ignores zero-length paths.
Instead, write a null byte.
Fixes: 0a8adf58475 ("test: add firmware_class loader test")
Fixes: 65c79230576 ("test_firmware: fix setting old custom fw path back on exit")
Signed-off-by: Ben Hutchings <ben.hutchings at codethink.co.uk>
---
tools/testing/selftests/firmware/fw_lib.sh | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/tools/testing/selftests/firmware/fw_lib.sh b/tools/testing/selftests/firmware/fw_lib.sh
index 9ea31b57d71a..962d7f4ac627 100755
--- a/tools/testing/selftests/firmware/fw_lib.sh
+++ b/tools/testing/selftests/firmware/fw_lib.sh
@@ -154,11 +154,13 @@ test_finish()
if [ "$HAS_FW_LOADER_USER_HELPER" = "yes" ]; then
echo "$OLD_TIMEOUT" >/sys/class/firmware/timeout
fi
- if [ "$OLD_FWPATH" = "" ]; then
- OLD_FWPATH=" "
- fi
if [ "$TEST_REQS_FW_SET_CUSTOM_PATH" = "yes" ]; then
- echo -n "$OLD_FWPATH" >/sys/module/firmware_class/parameters/path
+ if [ "$OLD_FWPATH" = "" ]; then
+ # A zero-length write won't work; write a null byte
+ printf '\000' >/sys/module/firmware_class/parameters/path
+ else
+ echo -n "$OLD_FWPATH" >/sys/module/firmware_class/parameters/path
+ fi
fi
if [ -f $FW ]; then
rm -f "$FW"
--
2.16.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH driver-core 2/2] test_firmware: fix setting old custom fw path back on exit, second try
2018-04-04 20:38 ` [PATCH driver-core 2/2] test_firmware: fix setting old custom fw path back on exit, second try ben.hutchings
2018-04-04 20:38 ` Ben Hutchings
@ 2018-04-18 20:38 ` mcgrof
2018-04-18 20:38 ` Luis R. Rodriguez
2018-04-23 10:45 ` gregkh
1 sibling, 2 replies; 10+ messages in thread
From: mcgrof @ 2018-04-18 20:38 UTC (permalink / raw)
On Wed, Apr 04, 2018 at 10:38:49PM +0200, Ben Hutchings wrote:
> Commit 65c79230576 tried to clear the custom firmware path on exit by
> writing a single space to the firmware_class.path parameter. This
> doesn't work because nothing strips this space from the value stored
> and fw_get_filesystem_firmware() only ignores zero-length paths.
>
> Instead, write a null byte.
>
> Fixes: 0a8adf58475 ("test: add firmware_class loader test")
> Fixes: 65c79230576 ("test_firmware: fix setting old custom fw path back on exit")
> Signed-off-by: Ben Hutchings <ben.hutchings at codethink.co.uk>
Acked-by: Luis R. Rodriguez <mcgrof at kernel.org>
Greg, let me know if you want to take these two in now, or if you want me to
queue them up on my own and then send you what I get in the queue later.
Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH driver-core 2/2] test_firmware: fix setting old custom fw path back on exit, second try
2018-04-18 20:38 ` mcgrof
@ 2018-04-18 20:38 ` Luis R. Rodriguez
2018-04-23 10:45 ` gregkh
1 sibling, 0 replies; 10+ messages in thread
From: Luis R. Rodriguez @ 2018-04-18 20:38 UTC (permalink / raw)
On Wed, Apr 04, 2018@10:38:49PM +0200, Ben Hutchings wrote:
> Commit 65c79230576 tried to clear the custom firmware path on exit by
> writing a single space to the firmware_class.path parameter. This
> doesn't work because nothing strips this space from the value stored
> and fw_get_filesystem_firmware() only ignores zero-length paths.
>
> Instead, write a null byte.
>
> Fixes: 0a8adf58475 ("test: add firmware_class loader test")
> Fixes: 65c79230576 ("test_firmware: fix setting old custom fw path back on exit")
> Signed-off-by: Ben Hutchings <ben.hutchings at codethink.co.uk>
Acked-by: Luis R. Rodriguez <mcgrof at kernel.org>
Greg, let me know if you want to take these two in now, or if you want me to
queue them up on my own and then send you what I get in the queue later.
Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH driver-core 2/2] test_firmware: fix setting old custom fw path back on exit, second try
2018-04-18 20:38 ` mcgrof
2018-04-18 20:38 ` Luis R. Rodriguez
@ 2018-04-23 10:45 ` gregkh
2018-04-23 10:45 ` Greg Kroah-Hartman
1 sibling, 1 reply; 10+ messages in thread
From: gregkh @ 2018-04-23 10:45 UTC (permalink / raw)
On Wed, Apr 18, 2018 at 10:38:09PM +0200, Luis R. Rodriguez wrote:
> On Wed, Apr 04, 2018 at 10:38:49PM +0200, Ben Hutchings wrote:
> > Commit 65c79230576 tried to clear the custom firmware path on exit by
> > writing a single space to the firmware_class.path parameter. This
> > doesn't work because nothing strips this space from the value stored
> > and fw_get_filesystem_firmware() only ignores zero-length paths.
> >
> > Instead, write a null byte.
> >
> > Fixes: 0a8adf58475 ("test: add firmware_class loader test")
> > Fixes: 65c79230576 ("test_firmware: fix setting old custom fw path back on exit")
> > Signed-off-by: Ben Hutchings <ben.hutchings at codethink.co.uk>
>
> Acked-by: Luis R. Rodriguez <mcgrof at kernel.org>
>
> Greg, let me know if you want to take these two in now, or if you want me to
> queue them up on my own and then send you what I get in the queue later.
I can take them now, thanks.
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH driver-core 2/2] test_firmware: fix setting old custom fw path back on exit, second try
2018-04-23 10:45 ` gregkh
@ 2018-04-23 10:45 ` Greg Kroah-Hartman
0 siblings, 0 replies; 10+ messages in thread
From: Greg Kroah-Hartman @ 2018-04-23 10:45 UTC (permalink / raw)
On Wed, Apr 18, 2018@10:38:09PM +0200, Luis R. Rodriguez wrote:
> On Wed, Apr 04, 2018@10:38:49PM +0200, Ben Hutchings wrote:
> > Commit 65c79230576 tried to clear the custom firmware path on exit by
> > writing a single space to the firmware_class.path parameter. This
> > doesn't work because nothing strips this space from the value stored
> > and fw_get_filesystem_firmware() only ignores zero-length paths.
> >
> > Instead, write a null byte.
> >
> > Fixes: 0a8adf58475 ("test: add firmware_class loader test")
> > Fixes: 65c79230576 ("test_firmware: fix setting old custom fw path back on exit")
> > Signed-off-by: Ben Hutchings <ben.hutchings at codethink.co.uk>
>
> Acked-by: Luis R. Rodriguez <mcgrof at kernel.org>
>
> Greg, let me know if you want to take these two in now, or if you want me to
> queue them up on my own and then send you what I get in the queue later.
I can take them now, thanks.
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH driver-core 1/2] test_firmware: Install all scripts
2018-04-04 20:37 [PATCH driver-core 1/2] test_firmware: Install all scripts ben.hutchings
2018-04-04 20:37 ` Ben Hutchings
2018-04-04 20:38 ` [PATCH driver-core 2/2] test_firmware: fix setting old custom fw path back on exit, second try ben.hutchings
@ 2018-04-18 20:35 ` mcgrof
2018-04-18 20:35 ` Luis R. Rodriguez
2 siblings, 1 reply; 10+ messages in thread
From: mcgrof @ 2018-04-18 20:35 UTC (permalink / raw)
On Wed, Apr 04, 2018 at 10:37:13PM +0200, Ben Hutchings wrote:
> List all the scripts invoked by fw_run_tests.sh, so that
> "make TARGETS=firmware install" keeps working.
>
> Fixes: 29a1c00ce1df8 ("test_firmware: add simple firmware firmware test ...")
> Fixes: b3cf21fae1fe0 ("test_firmware: test three firmware kernel configs ...")
> Signed-off-by: Ben Hutchings <ben.hutchings at codethink.co.uk>
Acked-by: Luis R. Rodriguez <mcgrof at kernel.org>
Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2018-04-23 10:45 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-04 20:37 [PATCH driver-core 1/2] test_firmware: Install all scripts ben.hutchings
2018-04-04 20:37 ` Ben Hutchings
2018-04-04 20:38 ` [PATCH driver-core 2/2] test_firmware: fix setting old custom fw path back on exit, second try ben.hutchings
2018-04-04 20:38 ` Ben Hutchings
2018-04-18 20:38 ` mcgrof
2018-04-18 20:38 ` Luis R. Rodriguez
2018-04-23 10:45 ` gregkh
2018-04-23 10:45 ` Greg Kroah-Hartman
2018-04-18 20:35 ` [PATCH driver-core 1/2] test_firmware: Install all scripts mcgrof
2018-04-18 20:35 ` Luis R. Rodriguez
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).