From: mhiramat at kernel.org (Masami Hiramatsu) Subject: [PATCH v7 00/16] tracing: probeevent: Improve fetcharg features Date: Tue, 8 May 2018 13:01:27 +0900 [thread overview] Message-ID: <20180508130127.c9de04e9d9c93a90e9891ae0@kernel.org> (raw) In-Reply-To: <20180507113003.66045d18@gandalf.local.home> On Mon, 7 May 2018 11:30:03 -0400 Steven Rostedt <rostedt at goodmis.org> wrote: > On Sun, 6 May 2018 00:51:43 +0900 > Masami Hiramatsu <mhiramat at kernel.org> wrote: > > > OK, now I think it is a time to introduce new unified interface for dynamic events, > > tracefs/dynamic_events and make uprobe_events and kprobe_events as symbolic-links > > to the new interface file. > > So basically make one file that does all the work? > > I'm not sure we can keep the other files as symbolic links. Because we > don't want the kprobe_events showing up in the uprobe_events file, and > vice versa. We need to keep all this backward compatible. Good catch! Can't we check which file the user opened? If not, even though we can setup a filter in ops->open(). > > But I do like the idea of one file to rule them all, approach. Thanks! > > -- Steve > > > > > > Actually, there is no reason we split those 2 interfaces, since > > both have similar, but very clear syntax differences. > > > > o Uprobe event definition > > p[:[GRP/]EVENT] PATH:OFFSET [FETCHARGS] : Set a uprobe > > r[:[GRP/]EVENT] PATH:OFFSET [FETCHARGS] : Set a return uprobe (uretprobe) > > -:[GRP/]EVENT : Clear uprobe or uretprobe event > > > > o Kprobe event definition > > p[:[GRP/]EVENT] [MOD:]SYM[+offs]|MEMADDR [FETCHARGS] : Set a probe > > r[MAXACTIVE][:[GRP/]EVENT] [MOD:]SYM[+0] [FETCHARGS] : Set a return probe > > -:[GRP/]EVENT : Clear a probe > > > > At first, it is clear that those can share the parser. 2nd, it is easy to > > distinguish those, because Uprobe event must require the PATH which starts > > with '/', on the other hand, Kprobe event must NOT start with '/'. > > (both SYM and MOD will start with alphabet or '_', of course MEMADDR > > will start with digits) > > > > If we can merge those to unified dynamic_events interface, I think > > 'f[:[GRP/]EVENT] SYM(CAST)' is also acceptable, since it is no more > > only for kprobe/uprobe. We can directly add some other dynamic > > events via dynamic_events interface. ;) > > > > Thank you, > > > -- Masami Hiramatsu <mhiramat at kernel.org> -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: mhiramat@kernel.org (Masami Hiramatsu) Subject: [PATCH v7 00/16] tracing: probeevent: Improve fetcharg features Date: Tue, 8 May 2018 13:01:27 +0900 [thread overview] Message-ID: <20180508130127.c9de04e9d9c93a90e9891ae0@kernel.org> (raw) Message-ID: <20180508040127.TFHdigcCWTYX1rbjgX09lkzAEPX4x3hBsnxzSaP8EHw@z> (raw) In-Reply-To: <20180507113003.66045d18@gandalf.local.home> On Mon, 7 May 2018 11:30:03 -0400 Steven Rostedt <rostedt@goodmis.org> wrote: > On Sun, 6 May 2018 00:51:43 +0900 > Masami Hiramatsu <mhiramat@kernel.org> wrote: > > > OK, now I think it is a time to introduce new unified interface for dynamic events, > > tracefs/dynamic_events and make uprobe_events and kprobe_events as symbolic-links > > to the new interface file. > > So basically make one file that does all the work? > > I'm not sure we can keep the other files as symbolic links. Because we > don't want the kprobe_events showing up in the uprobe_events file, and > vice versa. We need to keep all this backward compatible. Good catch! Can't we check which file the user opened? If not, even though we can setup a filter in ops->open(). > > But I do like the idea of one file to rule them all, approach. Thanks! > > -- Steve > > > > > > Actually, there is no reason we split those 2 interfaces, since > > both have similar, but very clear syntax differences. > > > > o Uprobe event definition > > p[:[GRP/]EVENT] PATH:OFFSET [FETCHARGS] : Set a uprobe > > r[:[GRP/]EVENT] PATH:OFFSET [FETCHARGS] : Set a return uprobe (uretprobe) > > -:[GRP/]EVENT : Clear uprobe or uretprobe event > > > > o Kprobe event definition > > p[:[GRP/]EVENT] [MOD:]SYM[+offs]|MEMADDR [FETCHARGS] : Set a probe > > r[MAXACTIVE][:[GRP/]EVENT] [MOD:]SYM[+0] [FETCHARGS] : Set a return probe > > -:[GRP/]EVENT : Clear a probe > > > > At first, it is clear that those can share the parser. 2nd, it is easy to > > distinguish those, because Uprobe event must require the PATH which starts > > with '/', on the other hand, Kprobe event must NOT start with '/'. > > (both SYM and MOD will start with alphabet or '_', of course MEMADDR > > will start with digits) > > > > If we can merge those to unified dynamic_events interface, I think > > 'f[:[GRP/]EVENT] SYM(CAST)' is also acceptable, since it is no more > > only for kprobe/uprobe. We can directly add some other dynamic > > events via dynamic_events interface. ;) > > > > Thank you, > > > -- Masami Hiramatsu <mhiramat at kernel.org> -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-05-08 4:01 UTC|newest] Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-25 12:16 [PATCH v7 00/16] tracing: probeevent: Improve fetcharg features mhiramat 2018-04-25 12:16 ` Masami Hiramatsu 2018-04-25 12:16 ` [PATCH v7 01/16] tracing: probeevent: Cleanup print argument functions mhiramat 2018-04-25 12:16 ` Masami Hiramatsu 2018-04-25 12:17 ` [PATCH v7 02/16] tracing: probeevent: Cleanup argument field definition mhiramat 2018-04-25 12:17 ` Masami Hiramatsu 2018-04-25 12:17 ` [PATCH v7 03/16] tracing: probeevent: Remove NOKPROBE_SYMBOL from print functions mhiramat 2018-04-25 12:17 ` Masami Hiramatsu 2018-04-25 12:18 ` [PATCH v7 04/16] tracing: probeevent: Introduce new argument fetching code mhiramat 2018-04-25 12:18 ` Masami Hiramatsu 2018-04-25 12:18 ` [PATCH v7 05/16] tracing: probeevent: Unify fetch type tables mhiramat 2018-04-25 12:18 ` Masami Hiramatsu 2018-04-25 12:19 ` [PATCH v7 06/16] tracing: probeevent: Return consumed bytes of dynamic area mhiramat 2018-04-25 12:19 ` Masami Hiramatsu 2018-04-25 12:19 ` [PATCH v7 07/16] tracing: probeevent: Append traceprobe_ for exported function mhiramat 2018-04-25 12:19 ` Masami Hiramatsu 2018-04-25 12:19 ` [PATCH v7 08/16] tracing: probeevent: Unify fetch_insn processing common part mhiramat 2018-04-25 12:19 ` Masami Hiramatsu 2018-04-25 12:20 ` [PATCH v7 09/16] tracing: probeevent: Add symbol type mhiramat 2018-04-25 12:20 ` Masami Hiramatsu 2018-04-25 12:20 ` [PATCH v7 10/16] x86: ptrace: Add function argument access API mhiramat 2018-04-25 12:20 ` Masami Hiramatsu 2018-04-25 12:21 ` [PATCH v7 11/16] tracing: probeevent: Add $argN for accessing function args mhiramat 2018-04-25 12:21 ` Masami Hiramatsu 2018-04-25 12:21 ` [PATCH v7 12/16] tracing: probeevent: Add array type support mhiramat 2018-04-25 12:21 ` Masami Hiramatsu 2018-04-25 12:22 ` [PATCH v7 13/16] selftests: ftrace: Add a testcase for symbol type mhiramat 2018-04-25 12:22 ` Masami Hiramatsu 2018-04-25 12:22 ` [PATCH v7 14/16] selftests: ftrace: Add a testcase for $argN with kprobe_event mhiramat 2018-04-25 12:22 ` Masami Hiramatsu 2018-04-25 12:23 ` [PATCH v7 15/16] selftests: ftrace: Add a testcase for array type " mhiramat 2018-04-25 12:23 ` Masami Hiramatsu 2018-04-25 12:23 ` [PATCH v7 16/16] perf-probe: Add array argument support mhiramat 2018-04-25 12:23 ` Masami Hiramatsu 2018-04-27 1:42 ` [PATCH v7 00/16] tracing: probeevent: Improve fetcharg features rostedt 2018-04-27 1:42 ` Steven Rostedt 2018-05-03 22:11 ` rostedt 2018-05-03 22:11 ` Steven Rostedt 2018-05-04 15:48 ` mhiramat 2018-05-04 15:48 ` Masami Hiramatsu 2018-05-04 16:06 ` rostedt 2018-05-04 16:06 ` Steven Rostedt 2018-05-04 17:30 ` naveen.n.rao 2018-05-04 17:30 ` Naveen N. Rao 2018-05-05 2:38 ` mhiramat 2018-05-05 2:38 ` Masami Hiramatsu 2018-05-05 7:46 ` naveen.n.rao 2018-05-05 7:46 ` Naveen N. Rao 2018-05-05 14:32 ` mhiramat 2018-05-05 14:32 ` Masami Hiramatsu 2018-05-07 8:11 ` naveen.n.rao 2018-05-07 8:11 ` Naveen N. Rao 2018-05-07 14:53 ` mhiramat 2018-05-07 14:53 ` Masami Hiramatsu 2018-05-08 10:11 ` naveen.n.rao 2018-05-08 10:11 ` Naveen N. Rao 2018-05-08 15:02 ` mhiramat 2018-05-08 15:02 ` Masami Hiramatsu 2018-05-08 18:01 ` naveen.n.rao 2018-05-08 18:01 ` Naveen N. Rao 2018-05-05 15:51 ` mhiramat 2018-05-05 15:51 ` Masami Hiramatsu 2018-05-07 15:30 ` rostedt 2018-05-07 15:30 ` Steven Rostedt 2018-05-08 4:01 ` mhiramat [this message] 2018-05-08 4:01 ` Masami Hiramatsu 2018-05-07 15:21 ` rostedt 2018-05-07 15:21 ` Steven Rostedt 2018-06-21 20:16 ` rostedt 2018-06-21 20:16 ` Steven Rostedt 2018-06-22 6:04 ` mhiramat 2018-06-22 6:04 ` Masami Hiramatsu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180508130127.c9de04e9d9c93a90e9891ae0@kernel.org \ --to=linux-kselftest@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).