From: joel at joelfernandes.org (Joel Fernandes) Subject: [PATCH v1 1/2] Add polling support to pidfd Date: Mon, 29 Apr 2019 10:07:43 -0400 [thread overview] Message-ID: <20190429140743.GB173743@google.com> (raw) In-Reply-To: <20190429140245.GB233442@google.com> On Mon, Apr 29, 2019 at 10:02:45AM -0400, Joel Fernandes wrote: > On Sun, Apr 28, 2019 at 06:24:06PM +0200, Oleg Nesterov wrote: [snip] > > > > +{ > > > > + struct pid *pid; > > > > + > > > > + lockdep_assert_held(&tasklist_lock); > > > > + > > > > + pid = get_task_pid(task, PIDTYPE_PID); > > > > + wake_up_all(&pid->wait_pidfd); > > > > + put_pid(pid); > > > > Why get/put? > > Yes, pid_task() should do it. Will update it. Thanks! I spoke too soon. We need the task's pid of type PIDTYPE_PID. How else can we get it? This does an atomic_inc on the pid->count, so we need to put_pid() after we are done with it. Did I miss something? thanks, - Joel
WARNING: multiple messages have this Message-ID (diff)
From: joel@joelfernandes.org (Joel Fernandes) Subject: [PATCH v1 1/2] Add polling support to pidfd Date: Mon, 29 Apr 2019 10:07:43 -0400 [thread overview] Message-ID: <20190429140743.GB173743@google.com> (raw) Message-ID: <20190429140743.HcI12Re6p2r7NQqRblh3WVz3p6UNEGbjQ2YdmdlZB0E@z> (raw) In-Reply-To: <20190429140245.GB233442@google.com> On Mon, Apr 29, 2019@10:02:45AM -0400, Joel Fernandes wrote: > On Sun, Apr 28, 2019@06:24:06PM +0200, Oleg Nesterov wrote: [snip] > > > > +{ > > > > + struct pid *pid; > > > > + > > > > + lockdep_assert_held(&tasklist_lock); > > > > + > > > > + pid = get_task_pid(task, PIDTYPE_PID); > > > > + wake_up_all(&pid->wait_pidfd); > > > > + put_pid(pid); > > > > Why get/put? > > Yes, pid_task() should do it. Will update it. Thanks! I spoke too soon. We need the task's pid of type PIDTYPE_PID. How else can we get it? This does an atomic_inc on the pid->count, so we need to put_pid() after we are done with it. Did I miss something? thanks, - Joel
next prev parent reply other threads:[~2019-04-29 14:07 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-25 19:00 [PATCH v1 1/2] Add polling support to pidfd joel 2019-04-25 19:00 ` Joel Fernandes (Google) 2019-04-25 19:00 ` [PATCH v1 2/2] Add selftests for pidfd polling joel 2019-04-25 19:00 ` Joel Fernandes (Google) 2019-04-25 20:00 ` tycho 2019-04-25 20:00 ` Tycho Andersen 2019-04-26 13:47 ` joel 2019-04-26 13:47 ` Joel Fernandes 2019-04-25 21:29 ` christian 2019-04-25 21:29 ` Christian Brauner 2019-04-25 22:07 ` dancol 2019-04-25 22:07 ` Daniel Colascione 2019-04-26 17:26 ` joel 2019-04-26 17:26 ` Joel Fernandes 2019-04-26 19:35 ` dancol 2019-04-26 19:35 ` Daniel Colascione 2019-04-26 20:31 ` joel 2019-04-26 20:31 ` Joel Fernandes 2019-04-26 13:42 ` joel 2019-04-26 13:42 ` Joel Fernandes 2019-04-25 22:24 ` [PATCH v1 1/2] Add polling support to pidfd christian 2019-04-25 22:24 ` Christian Brauner 2019-04-26 14:23 ` joel 2019-04-26 14:23 ` Joel Fernandes 2019-04-26 15:21 ` christian 2019-04-26 15:21 ` Christian Brauner 2019-04-26 15:31 ` christian 2019-04-26 15:31 ` Christian Brauner 2019-04-28 16:24 ` oleg 2019-04-28 16:24 ` Oleg Nesterov 2019-04-29 14:02 ` joel 2019-04-29 14:02 ` Joel Fernandes 2019-04-29 14:07 ` joel [this message] 2019-04-29 14:07 ` Joel Fernandes 2019-04-29 14:25 ` oleg 2019-04-29 14:25 ` Oleg Nesterov 2019-04-29 14:20 ` oleg 2019-04-29 14:20 ` Oleg Nesterov 2019-04-29 16:32 ` joel 2019-04-29 16:32 ` Joel Fernandes 2019-04-30 11:53 ` oleg 2019-04-30 11:53 ` Oleg Nesterov 2019-04-30 12:07 ` oleg 2019-04-30 12:07 ` Oleg Nesterov 2019-04-30 15:49 ` joel 2019-04-30 15:49 ` Joel Fernandes 2019-04-26 14:58 ` christian 2019-04-26 14:58 ` Christian Brauner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190429140743.GB173743@google.com \ --to=linux-kselftest@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).