Linux-kselftest Archive on lore.kernel.org
 help / color / Atom feed
From: Christian Brauner <christian.brauner@ubuntu.com>
To: Adrian Reber <areber@redhat.com>
Cc: Eugene Syromiatnikov <esyr@redhat.com>,
	linux-kernel@vger.kernel.org,
	Christian Brauner <christian@brauner.io>,
	Shuah Khan <shuah@kernel.org>,
	linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v2 0/6] Update clone3 self-tests
Date: Mon, 16 Sep 2019 10:14:14 +0200
Message-ID: <20190916081413.32dmmed6f6yjta26@wittgenstein> (raw)
In-Reply-To: <20190916081247.GC26734@dcbz.redhat.com>

On Mon, Sep 16, 2019 at 10:12:47AM +0200, Adrian Reber wrote:
> On Mon, Sep 16, 2019 at 09:49:34AM +0200, Christian Brauner wrote:
> > On Tue, Sep 10, 2019 at 07:01:30PM +0100, Eugene Syromiatnikov wrote:
> > > Hello.
> > > 
> > > This patch set updates clone3 selftest in several aspects:
> > >  - adding checks for exit_signal invalid values handling;
> > >  - adding clone3 to selftests targets;
> > >  - enabling clone3 tests on all architectures;
> > >  - minor cleanups of the clone3 test.
> > > 
> > > Applied on top of brauer/linux.git/for-next.
> > 
> > So I like this series a lot! Testing is very important.
> > And thanks for catching the clone3() exit_signal problem. This way we
> > got to release a non-broken kernel. :)
> > 
> > Some notes: I dropped the set_tid extension from the core process
> > updates for 5.4 because we ended up in a discussion that made it clear
> > we potentially need the ability to restore pids in multiple pid
> > namespaces. This means we need some more discussion and the patchset is
> > delayed for at least one release.
> > Unfortunately, this also means the test that you have based yours upon
> > does not exist anymore. However, the tests should not be blocked on
> > this. I'd encourage you to talk to Adrian (who is Cced here anyway) and
> > come up with a clone3() test suite I can merge. You can very likely do a
> > Co-Developed-by so no-ones work gets dropped. :)
> > 
> > Ideally I'd like to see:
> > - verifying passing different struct sizes works correctly
> > - verify that flag combinations work correctly
> > - verify that struct members have correct values etc. pp.
> > 
> > We definitely want the exit_signal test as a regression test so it
> > doesn't bite us again!
> > 
> > (Oh, please also add tool/test/selftests/clone3/ to the pidfd/core
> >  process MAINTAINERS entry.)
> 
> Eugene and I have already discussed this. We will resubmit the clone3()
> selftests in the next few days with all our changes combined.

Excellent! Very happy to hear this! :)
Christian

      reply index

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-10 18:01 Eugene Syromiatnikov
2019-09-10 18:01 ` [PATCH v2 1/6] selftests/clone3: convert test modes into an enum Eugene Syromiatnikov
2019-09-10 18:01 ` [PATCH v2 2/6] selftests/clone3: add a check for invalid exit_signal Eugene Syromiatnikov
2019-09-10 18:01 ` [PATCH v2 3/6] selftests/clone3: use uint64_t for flags parameter Eugene Syromiatnikov
2019-09-10 18:02 ` [PATCH v2 4/6] selftests/clone3: fix up format strings Eugene Syromiatnikov
2019-09-10 18:02 ` [PATCH v2 5/6] selftests/clone3: enable clone3 self-tests on all architectures Eugene Syromiatnikov
2019-09-10 18:02 ` [PATCH v2 6/6] selftests: add clone3 to TARGETS Eugene Syromiatnikov
2019-09-16  7:49 ` [PATCH v2 0/6] Update clone3 self-tests Christian Brauner
2019-09-16  8:12   ` Adrian Reber
2019-09-16  8:14     ` Christian Brauner [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190916081413.32dmmed6f6yjta26@wittgenstein \
    --to=christian.brauner@ubuntu.com \
    --cc=areber@redhat.com \
    --cc=christian@brauner.io \
    --cc=esyr@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-kselftest Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-kselftest/0 linux-kselftest/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-kselftest linux-kselftest/ https://lore.kernel.org/linux-kselftest \
		linux-kselftest@vger.kernel.org linux-kselftest@archiver.kernel.org
	public-inbox-index linux-kselftest

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kselftest


AGPL code for this site: git clone https://public-inbox.org/ public-inbox