From: Eugeniu Rosca <erosca@de.adit-jv.com>
To: shuah <shuah@kernel.org>
Cc: Eugeniu Rosca <erosca@de.adit-jv.com>,
"George G. Davis" <george_davis@mentor.com>,
Eugeniu Rosca <roscaeugeniu@gmail.com>,
Jerry Hoemann <jerry.hoemann@hpe.com>,
Colin Ian King <colin.king@canonical.com>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] selftests: watchdog: Validate optional file argument
Date: Tue, 17 Sep 2019 18:54:18 +0200 [thread overview]
Message-ID: <20190917165418.GA21010@vmlxhi-102.adit-jv.com> (raw)
In-Reply-To: <73bab70b-e22c-42b4-cfca-b4e33431b423@kernel.org>
Shuah,
On Tue, Sep 17, 2019 at 09:25:31AM -0600, shuah wrote:
[..]
> I want two patches and the first one with
> Fixes tag.
I am not sure we are on the same page and you don't seem to be receptive
to what I say.
> The reason for that is that the first patch fixes a problem
> in patch that is already in my tree which is fixes a problem.
Here is my understanding of your request:
+--------------+ +--------------+
|1/2 this patch| |1/2 this patch|
| (fix) +----+ (feature) |
+------+-------+ +--------------+
| Fixes
+------v-------+
| [A] |
+------+-------+
| Fixes
+------v-------+
| [B] |
+--------------+
So, you ask to decompose this v2 patch into two parts (fix and feature),
__exactly like it was in v1__, with the reasoning that the bugfix
related part of this patch fixes [A] (which is true), while [A] fixes
another commit [B]. But given that [A] is a feature commit, adding brand
new functionality, there can't be any [B] commit being fixed by [A].
> I am going to mark the patch for stables and the first patch in this
> series.
I do not understand your request. Both current patch and [A] are
scheduled for v5.4. I do not see any relevant patches for linux-stable.
I hope either a clarification or a third opinion will shed more light
onto this totally unproductive dialogue.
[A] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=c3f2490d6e92
("selftests: watchdog: Add optional file argument")
https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/commit/?h=next&id=c3f2490d6e92
("selftests: watchdog: Add optional file argument")
[B] ???
--
Best Regards,
Eugeniu.
next prev parent reply other threads:[~2019-09-17 16:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-16 18:49 [PATCH v2] selftests: watchdog: Validate optional file argument George G. Davis
2019-09-17 1:19 ` shuah
2019-09-17 14:54 ` Eugeniu Rosca
2019-09-17 15:25 ` shuah
2019-09-17 16:54 ` Eugeniu Rosca [this message]
2019-09-17 17:44 ` shuah
2019-09-17 17:50 ` Eugeniu Rosca
2019-09-17 18:05 ` shuah
2019-09-17 18:32 ` George G. Davis
2019-09-17 18:43 ` George G. Davis
2019-09-17 18:51 ` Eugeniu Rosca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190917165418.GA21010@vmlxhi-102.adit-jv.com \
--to=erosca@de.adit-jv.com \
--cc=colin.king@canonical.com \
--cc=george_davis@mentor.com \
--cc=jerry.hoemann@hpe.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=roscaeugeniu@gmail.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).