* [PATCH] selftests: pidfd: Fix undefined reference to pthread_create()
@ 2019-09-24 19:52 Shuah Khan
2019-09-24 20:01 ` Christian Brauner
0 siblings, 1 reply; 2+ messages in thread
From: Shuah Khan @ 2019-09-24 19:52 UTC (permalink / raw)
To: christian, shuah; +Cc: Shuah Khan, linux-kernel, linux-kselftest
Fix build failure:
undefined reference to `pthread_create'
collect2: error: ld returned 1 exit status
Fix CFLAGS to include pthread correctly.
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
---
tools/testing/selftests/pidfd/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/pidfd/Makefile b/tools/testing/selftests/pidfd/Makefile
index 464c9b76148f..7550f08822a3 100644
--- a/tools/testing/selftests/pidfd/Makefile
+++ b/tools/testing/selftests/pidfd/Makefile
@@ -1,5 +1,5 @@
# SPDX-License-Identifier: GPL-2.0-only
-CFLAGS += -g -I../../../../usr/include/ -lpthread
+CFLAGS += -g -I../../../../usr/include/ -pthread
TEST_GEN_PROGS := pidfd_test pidfd_open_test pidfd_poll_test pidfd_wait
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] selftests: pidfd: Fix undefined reference to pthread_create()
2019-09-24 19:52 [PATCH] selftests: pidfd: Fix undefined reference to pthread_create() Shuah Khan
@ 2019-09-24 20:01 ` Christian Brauner
0 siblings, 0 replies; 2+ messages in thread
From: Christian Brauner @ 2019-09-24 20:01 UTC (permalink / raw)
To: Shuah Khan; +Cc: shuah, linux-kernel, linux-kselftest
On Tue, Sep 24, 2019 at 01:52:37PM -0600, Shuah Khan wrote:
> Fix build failure:
>
> undefined reference to `pthread_create'
> collect2: error: ld returned 1 exit status
>
> Fix CFLAGS to include pthread correctly.
>
> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
Reviewed-by: Christian Brauner <christian.brauner@ubuntu.com>
Thanks, Shuah!
Queued-up in my fixes branch and will be included after the merge window
closes. I'll also add a fixes tag and a cc for stable since this should
very likely be backported.
Christian
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-24 20:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-24 19:52 [PATCH] selftests: pidfd: Fix undefined reference to pthread_create() Shuah Khan
2019-09-24 20:01 ` Christian Brauner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).