From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Quentin Monnet <quentin@isovalent.com>
Cc: Michal Rostecki <mrostecki@opensuse.org>,
bpf@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>, Andrii Nakryiko <andriin@fb.com>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Shuah Khan <shuah@kernel.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH bpf-next v2 2/5] bpftool: Make probes which emit dmesg warnings optional
Date: Fri, 21 Feb 2020 14:44:29 -0800 [thread overview]
Message-ID: <20200221224428.plbxav3scv6og6kv@ast-mbp> (raw)
In-Reply-To: <7ab56bb6-0ddb-2c3c-d116-fc01feddba5e@isovalent.com>
On Fri, Feb 21, 2020 at 11:28:05AM +0000, Quentin Monnet wrote:
>
> "trace" sounds too generic. If filters are applied again to prog and map
> types in the future (as you had in v1), this would catch tracepoint and
> raw_tracepoint program types and stack_trace map type. Or if new helpers
> with "trace" in their name are added, we skip them too. Can we use something
> more specific, probably "trace_printk"?
+1
> Thanks for the patch! While I understand you want to keep the changes you
> have done to use regex, I do not really think they bring much in this
> version of the patch. As we only want to filter out two specific helpers, it
> seems to me that it would be much simpler to just compare helper names
> instead of introducing regular expressions that are not used otherwise. What
> do you think?
+1
I was thinking the same.
Or filter by specific integer id of the helper.
next prev parent reply other threads:[~2020-02-21 22:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 3:16 [PATCH bpf-next v2 0/5] bpftool: Make probes which emit dmesg warnings optional Michal Rostecki
2020-02-21 3:16 ` [PATCH bpf-next v2 1/5] bpftool: Move out sections to separate functions Michal Rostecki
2020-02-21 11:27 ` Quentin Monnet
2020-02-21 3:16 ` [PATCH bpf-next v2 2/5] bpftool: Make probes which emit dmesg warnings optional Michal Rostecki
2020-02-21 11:28 ` Quentin Monnet
2020-02-21 22:44 ` Alexei Starovoitov [this message]
2020-02-25 12:18 ` Michal Rostecki
2020-02-21 3:16 ` [PATCH bpf-next v2 3/5] bpftool: Update documentation of "bpftool feature" command Michal Rostecki
2020-02-21 11:28 ` Quentin Monnet
2020-02-21 3:16 ` [PATCH bpf-next v2 4/5] bpftool: Update bash completion for " Michal Rostecki
2020-02-21 11:29 ` Quentin Monnet
2020-02-21 3:17 ` [PATCH bpf-next v2 5/5] selftests/bpf: Add test " Michal Rostecki
2020-02-21 11:28 ` Quentin Monnet
2020-02-25 13:25 ` Michal Rostecki
2020-02-25 13:55 ` Michal Rostecki
2020-02-25 14:54 ` Quentin Monnet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200221224428.plbxav3scv6og6kv@ast-mbp \
--to=alexei.starovoitov@gmail.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kafai@fb.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mrostecki@opensuse.org \
--cc=netdev@vger.kernel.org \
--cc=quentin@isovalent.com \
--cc=shuah@kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).