From: Quentin Monnet <quentin@isovalent.com>
To: Michal Rostecki <mrostecki@opensuse.org>, bpf@vger.kernel.org
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>, Andrii Nakryiko <andriin@fb.com>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Shuah Khan <shuah@kernel.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH bpf-next v2 4/5] bpftool: Update bash completion for "bpftool feature" command
Date: Fri, 21 Feb 2020 11:29:30 +0000 [thread overview]
Message-ID: <7e37246c-a154-1cd6-fbae-ed29497903e8@isovalent.com> (raw)
In-Reply-To: <20200221031702.25292-5-mrostecki@opensuse.org>
2020-02-21 04:16 UTC+0100 ~ Michal Rostecki <mrostecki@opensuse.org>
> Update bash completion for "bpftool feature" command with the new
> argument: "full".
>
> Signed-off-by: Michal Rostecki <mrostecki@opensuse.org>
> ---
> tools/bpf/bpftool/bash-completion/bpftool | 27 ++++++++++++++++-------
> 1 file changed, 19 insertions(+), 8 deletions(-)
>
> diff --git a/tools/bpf/bpftool/bash-completion/bpftool b/tools/bpf/bpftool/bash-completion/bpftool
> index 754d8395e451..f2bcc4bacee2 100644
> --- a/tools/bpf/bpftool/bash-completion/bpftool
> +++ b/tools/bpf/bpftool/bash-completion/bpftool
> @@ -981,14 +981,25 @@ _bpftool()
> feature)
> case $command in
> probe)
> - [[ $prev == "prefix" ]] && return 0
> - if _bpftool_search_list 'macros'; then
> - COMPREPLY+=( $( compgen -W 'prefix' -- "$cur" ) )
> - else
> - COMPREPLY+=( $( compgen -W 'macros' -- "$cur" ) )
> - fi
> - _bpftool_one_of_list 'kernel dev'
> - return 0
> + case $prev in
> + $command)
> + COMPREPLY+=( $( compgen -W 'kernel dev full macros' -- \
> + "$cur" ) )
> + return 0
> + ;;
> + prefix)
> + return 0
> + ;;
> + macros)
> + COMPREPLY+=( $( compgen -W 'prefix' -- "$cur" ) )
> + return 0
I have not tested, but I think because of the "return 0" this will
propose only "prefix" after "macros". But "kernel" or "dev" should also
be in the list.
Maybe just add "_bpftool_once_attr 'full'" under the
"_bpftool_one_of_list 'kernel dev'" instead of changing to the "case
$prev in" structure?
> + ;;
> + *)
> + _bpftool_one_of_list 'kernel dev'
> + _bpftool_once_attr 'full macros'
> + return 0
> + ;;
> + esac
> ;;
> *)
> [[ $prev == $object ]] && \
>
next prev parent reply other threads:[~2020-02-21 11:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 3:16 [PATCH bpf-next v2 0/5] bpftool: Make probes which emit dmesg warnings optional Michal Rostecki
2020-02-21 3:16 ` [PATCH bpf-next v2 1/5] bpftool: Move out sections to separate functions Michal Rostecki
2020-02-21 11:27 ` Quentin Monnet
2020-02-21 3:16 ` [PATCH bpf-next v2 2/5] bpftool: Make probes which emit dmesg warnings optional Michal Rostecki
2020-02-21 11:28 ` Quentin Monnet
2020-02-21 22:44 ` Alexei Starovoitov
2020-02-25 12:18 ` Michal Rostecki
2020-02-21 3:16 ` [PATCH bpf-next v2 3/5] bpftool: Update documentation of "bpftool feature" command Michal Rostecki
2020-02-21 11:28 ` Quentin Monnet
2020-02-21 3:16 ` [PATCH bpf-next v2 4/5] bpftool: Update bash completion for " Michal Rostecki
2020-02-21 11:29 ` Quentin Monnet [this message]
2020-02-21 3:17 ` [PATCH bpf-next v2 5/5] selftests/bpf: Add test " Michal Rostecki
2020-02-21 11:28 ` Quentin Monnet
2020-02-25 13:25 ` Michal Rostecki
2020-02-25 13:55 ` Michal Rostecki
2020-02-25 14:54 ` Quentin Monnet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e37246c-a154-1cd6-fbae-ed29497903e8@isovalent.com \
--to=quentin@isovalent.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kafai@fb.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mrostecki@opensuse.org \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).