* Re: [RFC][PATCH 12/11] selftest/ftrace: Fix function trigger test to handle trace not disabling the tracer
[not found] ` <20200318111345.0516642e@gandalf.local.home>
@ 2020-03-18 16:35 ` Shuah Khan
2020-03-19 13:04 ` Masami Hiramatsu
0 siblings, 1 reply; 2+ messages in thread
From: Shuah Khan @ 2020-03-18 16:35 UTC (permalink / raw)
To: Steven Rostedt
Cc: LKML, Ingo Molnar, Andrew Morton, Peter Zijlstra,
Masami Hiramatsu, Alexei Starovoitov, Peter Wu, Jonathan Corbet,
Tom Zanussi, linux-kselftest, skhan
On Wed, Mar 18, 2020 at 9:13 AM Steven Rostedt <rostedt@goodmis.org> wrote:
>
>
> From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
>
> The ftrace selftest "ftrace - test for function traceon/off triggers"
> enables all events and reads the trace file. Now that the trace file does
> not disable tracing, and will attempt to continually read new data that is
> added, the selftest gets stuck reading the trace file. This is because the
> data added to the trace file will fill up quicker than the reading of it.
>
> By only enabling scheduling events, the read can keep up with the writes.
> Instead of enabling all events, only enable the scheduler events.
>
> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> ---
> .../selftests/ftrace/test.d/ftrace/func_traceonoff_triggers.tc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
+ linux-kselttest and my LF email.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [RFC][PATCH 12/11] selftest/ftrace: Fix function trigger test to handle trace not disabling the tracer
2020-03-18 16:35 ` [RFC][PATCH 12/11] selftest/ftrace: Fix function trigger test to handle trace not disabling the tracer Shuah Khan
@ 2020-03-19 13:04 ` Masami Hiramatsu
0 siblings, 0 replies; 2+ messages in thread
From: Masami Hiramatsu @ 2020-03-19 13:04 UTC (permalink / raw)
To: Shuah Khan
Cc: Steven Rostedt, LKML, Ingo Molnar, Andrew Morton, Peter Zijlstra,
Masami Hiramatsu, Alexei Starovoitov, Peter Wu, Jonathan Corbet,
Tom Zanussi, linux-kselftest, skhan
On Wed, 18 Mar 2020 10:35:29 -0600
Shuah Khan <shuahkhan@gmail.com> wrote:
> On Wed, Mar 18, 2020 at 9:13 AM Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> >
> > From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
> >
> > The ftrace selftest "ftrace - test for function traceon/off triggers"
> > enables all events and reads the trace file. Now that the trace file does
> > not disable tracing, and will attempt to continually read new data that is
> > added, the selftest gets stuck reading the trace file. This is because the
> > data added to the trace file will fill up quicker than the reading of it.
> >
> > By only enabling scheduling events, the read can keep up with the writes.
> > Instead of enabling all events, only enable the scheduler events.
> >
> > Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Looks good to me.
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Thanks!
> > ---
> > .../selftests/ftrace/test.d/ftrace/func_traceonoff_triggers.tc | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> + linux-kselttest and my LF email.
>
> thanks,
> -- Shuah
--
Masami Hiramatsu <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-19 13:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200317213222.421100128@goodmis.org>
[not found] ` <20200318111345.0516642e@gandalf.local.home>
2020-03-18 16:35 ` [RFC][PATCH 12/11] selftest/ftrace: Fix function trigger test to handle trace not disabling the tracer Shuah Khan
2020-03-19 13:04 ` Masami Hiramatsu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).