Linux-kselftest Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v2] Kernel selftests: Add check if tpm devices are supported
@ 2020-05-19 12:07 Nikita Sobolev
  2020-05-19 12:16 ` Petr Vorel
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Nikita Sobolev @ 2020-05-19 12:07 UTC (permalink / raw)
  To: Shuah Khan, linux-kselftest
  Cc: Jarkko Sakkinen, Tadeusz Struk, Joey Pabalinas, Petr Vorel,
	linux-kernel, linux-integrity, Jason Gunthorpe, Peter Huewe,
	Alexey Brodkin, Eugeniy Paltsev, linux-snps-arc, Nikita Sobolev

tpm2 tests set uses /dev/tpm0 and /dev/tpmrm0 without check if they
are available. In case, when these devices are not available test
fails, but expected behaviour is skipped test.

Signed-off-by: Nikita Sobolev <Nikita.Sobolev@synopsys.com>
---
Changes for v2:
    - Coding Style cleanup

 tools/testing/selftests/tpm2/test_smoke.sh | 5 +++++
 tools/testing/selftests/tpm2/test_space.sh | 5 +++++
 2 files changed, 10 insertions(+)

diff --git a/tools/testing/selftests/tpm2/test_smoke.sh b/tools/testing/selftests/tpm2/test_smoke.sh
index 8155c2ea7ccb..663062701d5a 100755
--- a/tools/testing/selftests/tpm2/test_smoke.sh
+++ b/tools/testing/selftests/tpm2/test_smoke.sh
@@ -1,6 +1,11 @@
 #!/bin/bash
 # SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause)
 
+# Kselftest framework requirement - SKIP code is 4.
+ksft_skip=4
+
+[ -f /dev/tpm0 ] || exit $ksft_skip
+
 python -m unittest -v tpm2_tests.SmokeTest
 python -m unittest -v tpm2_tests.AsyncTest
 
diff --git a/tools/testing/selftests/tpm2/test_space.sh b/tools/testing/selftests/tpm2/test_space.sh
index a6f5e346635e..36c9d030a1c6 100755
--- a/tools/testing/selftests/tpm2/test_space.sh
+++ b/tools/testing/selftests/tpm2/test_space.sh
@@ -1,4 +1,9 @@
 #!/bin/bash
 # SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause)
 
+# Kselftest framework requirement - SKIP code is 4.
+ksft_skip=4
+
+[ -f /dev/tpmrm0 ] || exit $ksft_skip
+
 python -m unittest -v tpm2_tests.SpaceTest
-- 
2.16.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] Kernel selftests: Add check if tpm devices are supported
  2020-05-19 12:07 [PATCH v2] Kernel selftests: Add check if tpm devices are supported Nikita Sobolev
@ 2020-05-19 12:16 ` Petr Vorel
  2020-05-19 12:19 ` Petr Vorel
  2020-05-19 19:00 ` Jarkko Sakkinen
  2 siblings, 0 replies; 4+ messages in thread
From: Petr Vorel @ 2020-05-19 12:16 UTC (permalink / raw)
  To: Nikita Sobolev
  Cc: Shuah Khan, linux-kselftest, Jarkko Sakkinen, Tadeusz Struk,
	Joey Pabalinas, linux-kernel, linux-integrity, Jason Gunthorpe,
	Peter Huewe, Alexey Brodkin, Eugeniy Paltsev, linux-snps-arc,
	Shuah Khan

Hi Nikita,

> tpm2 tests set uses /dev/tpm0 and /dev/tpmrm0 without check if they
> are available. In case, when these devices are not available test
> fails, but expected behaviour is skipped test.

> Signed-off-by: Nikita Sobolev <Nikita.Sobolev@synopsys.com>
Reviewed-by: Petr Vorel <pvorel@suse.cz>

Thanks for v2, but I see v1 already merged in next tree since February.
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20200518&id=b32694cd0724d4ceca2c62cc7c3d3a8d1ffa11fc

Kind regards,
Petr

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] Kernel selftests: Add check if tpm devices are supported
  2020-05-19 12:07 [PATCH v2] Kernel selftests: Add check if tpm devices are supported Nikita Sobolev
  2020-05-19 12:16 ` Petr Vorel
@ 2020-05-19 12:19 ` Petr Vorel
  2020-05-19 19:00 ` Jarkko Sakkinen
  2 siblings, 0 replies; 4+ messages in thread
From: Petr Vorel @ 2020-05-19 12:19 UTC (permalink / raw)
  To: Nikita Sobolev
  Cc: Shuah Khan, linux-kselftest, Jarkko Sakkinen, Tadeusz Struk,
	Joey Pabalinas, linux-kernel, linux-integrity, Jason Gunthorpe,
	Peter Huewe, Alexey Brodkin, Eugeniy Paltsev, linux-snps-arc,
	Shuah Khan

> tpm2 tests set uses /dev/tpm0 and /dev/tpmrm0 without check if they
> are available. In case, when these devices are not available test
> fails, but expected behaviour is skipped test.

> Signed-off-by: Nikita Sobolev <Nikita.Sobolev@synopsys.com>
OK, I see it was also reverted by Jarkko

https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20200518&id=aaa2d92efe1f972567f1691b423ab8dc606ab3a9

I wonder if only wrong shell syntax (self.flags = flags) is a problem.

Kind regards,
Petr

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] Kernel selftests: Add check if tpm devices are supported
  2020-05-19 12:07 [PATCH v2] Kernel selftests: Add check if tpm devices are supported Nikita Sobolev
  2020-05-19 12:16 ` Petr Vorel
  2020-05-19 12:19 ` Petr Vorel
@ 2020-05-19 19:00 ` Jarkko Sakkinen
  2 siblings, 0 replies; 4+ messages in thread
From: Jarkko Sakkinen @ 2020-05-19 19:00 UTC (permalink / raw)
  To: Nikita Sobolev
  Cc: Shuah Khan, linux-kselftest, Tadeusz Struk, Joey Pabalinas,
	Petr Vorel, linux-kernel, linux-integrity, Jason Gunthorpe,
	Peter Huewe, Alexey Brodkin, Eugeniy Paltsev, linux-snps-arc

On Tue, May 19, 2020 at 03:07:43PM +0300, Nikita Sobolev wrote:
> tpm2 tests set uses /dev/tpm0 and /dev/tpmrm0 without check if they
> are available. In case, when these devices are not available test
> fails, but expected behaviour is skipped test.
> 
> Signed-off-by: Nikita Sobolev <Nikita.Sobolev@synopsys.com>

See

https://lore.kernel.org/linux-kselftest/20200519134838.GA17129@linux.intel.com/T/#mf762512a67f0b23db5663d6d67746cb94b812931

The comments about the fixes tag and acronym spelling were not
addressed. The code change looks great tho now, thanks.

/Jarkko

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-19 12:07 [PATCH v2] Kernel selftests: Add check if tpm devices are supported Nikita Sobolev
2020-05-19 12:16 ` Petr Vorel
2020-05-19 12:19 ` Petr Vorel
2020-05-19 19:00 ` Jarkko Sakkinen

Linux-kselftest Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-kselftest/0 linux-kselftest/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-kselftest linux-kselftest/ https://lore.kernel.org/linux-kselftest \
		linux-kselftest@vger.kernel.org
	public-inbox-index linux-kselftest

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kselftest


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git