From: Steven Rostedt <rostedt@goodmis.org>
To: Alexander Gordeev <agordeev@linux.ibm.com>
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Christian Brauner <christian.brauner@ubuntu.com>,
Masami Hiramatsu <mhiramat@kernel.org>
Subject: Re: [PATCH] selftests/ftrace: remove _do_fork() leftovers
Date: Fri, 23 Oct 2020 09:35:23 -0400 [thread overview]
Message-ID: <20201023093523.65c495f8@gandalf.local.home> (raw)
In-Reply-To: <1603443123-17457-1-git-send-email-agordeev@linux.ibm.com>
On Fri, 23 Oct 2020 10:52:03 +0200
Alexander Gordeev <agordeev@linux.ibm.com> wrote:
> diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-notrace-pid.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-notrace-pid.tc
> index acb17ce..0ddb948 100644
> --- a/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-notrace-pid.tc
> +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-notrace-pid.tc
> @@ -39,7 +39,7 @@ do_test() {
> disable_tracing
>
> echo do_execve* > set_ftrace_filter
> - echo *do_fork >> set_ftrace_filter
> + echo kernel_clone >> set_ftrace_filter
>
> echo $PID > set_ftrace_notrace_pid
> echo function > current_tracer
> diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-pid.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-pid.tc
> index 9f0a968..71319b3 100644
> --- a/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-pid.tc
> +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-pid.tc
> @@ -39,7 +39,7 @@ do_test() {
> disable_tracing
>
> echo do_execve* > set_ftrace_filter
> - echo *do_fork >> set_ftrace_filter
> + echo kernel_clone >> set_ftrace_filter
>
> echo $PID > set_ftrace_pid
> echo function > current_tracer
The issue I have with this, is that I run these tests on older kernels too,
and tests that use to work on older kernels should still work. In fact,
this fails on the kernel I'm currently adding new changes to!
Perhaps we should have:
# older kernels have do_fork, but newer kernels have kernel_clone
echo kernel_clone >> set_ftrace_filter || echo *do_fork >> set_ftrace_filter
The above still seems to work for me.
-- Steve
next prev parent reply other threads:[~2020-10-23 13:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 8:52 [PATCH] selftests/ftrace: remove _do_fork() leftovers Alexander Gordeev
2020-10-23 10:48 ` Masami Hiramatsu
2020-10-23 13:35 ` Steven Rostedt [this message]
2020-10-23 15:12 ` Alexander Gordeev
2020-10-23 15:49 ` Steven Rostedt
2020-10-23 15:51 ` Steven Rostedt
2020-10-27 21:55 ` Shuah Khan
2020-10-28 2:46 ` Steven Rostedt
2020-10-28 2:47 ` Steven Rostedt
2020-10-24 1:31 ` Masami Hiramatsu
2020-10-26 16:03 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201023093523.65c495f8@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=agordeev@linux.ibm.com \
--cc=christian.brauner@ubuntu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mhiramat@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).