From: Shuah Khan <skhan@linuxfoundation.org>
To: Steven Rostedt <rostedt@goodmis.org>,
Alexander Gordeev <agordeev@linux.ibm.com>
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Christian Brauner <christian.brauner@ubuntu.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] selftests/ftrace: remove _do_fork() leftovers
Date: Tue, 27 Oct 2020 15:55:32 -0600 [thread overview]
Message-ID: <cedad9bf-ba6b-78ad-644f-ce5074f2fbed@linuxfoundation.org> (raw)
In-Reply-To: <20201023115111.1c0e8768@gandalf.local.home>
On 10/23/20 9:51 AM, Steven Rostedt wrote:
> On Fri, 23 Oct 2020 11:49:48 -0400
> Steven Rostedt <rostedt@goodmis.org> wrote:
>
>> On Fri, 23 Oct 2020 17:12:44 +0200
>> Alexander Gordeev <agordeev@linux.ibm.com> wrote:
>>
>>>> Perhaps we should have:
>>>>
>>>> # older kernels have do_fork, but newer kernels have kernel_clone
>>>> echo kernel_clone >> set_ftrace_filter || echo *do_fork >> set_ftrace_filter
>>>
>>> Would you suggest to do the same with all occurences in
>>> eea11285dab3 ("tracing: switch to kernel_clone()")?
>>> Otherwise it does not really make sense to just fix couple
>>> of tests out of dozens.
>>
>> Yes. I haven't pulled in the updated tests, so I haven't hit the errors yet
>> (nor have I merged my work with the switch to the new name yet). So those
>> will most definitely break my tests.
>>
>> But because it's a more generic issue, we should have a way to find what to
>> use. Perhaps add to the test.d/functions, something like:
>>
>> FUNCTION_FORK=`(if grep '\bkernel_clone\b' /proc/kallsyms > /dev/null; then
>> echo kernel_clone; else echo '_do_fork'; fi)`
>>
>> and use $FUNCTION_FORK everywhere that references it.
>>
>>
>
> Let me pull in the latest changes, and whip up a patch that works on both
> the older kernels as well as the newer ones.
>
> -- Steve
>
Assume this is handled by
selftests/ftrace: Use $FUNCTION_FORK to reference kernel fork function
https://patchwork.kernel.org/project/linux-kselftest/patch/20201026162032.124c728d@gandalf.local.home/
Just making sure.
thanks,
-- Shuah
next prev parent reply other threads:[~2020-10-27 21:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 8:52 [PATCH] selftests/ftrace: remove _do_fork() leftovers Alexander Gordeev
2020-10-23 10:48 ` Masami Hiramatsu
2020-10-23 13:35 ` Steven Rostedt
2020-10-23 15:12 ` Alexander Gordeev
2020-10-23 15:49 ` Steven Rostedt
2020-10-23 15:51 ` Steven Rostedt
2020-10-27 21:55 ` Shuah Khan [this message]
2020-10-28 2:46 ` Steven Rostedt
2020-10-28 2:47 ` Steven Rostedt
2020-10-24 1:31 ` Masami Hiramatsu
2020-10-26 16:03 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cedad9bf-ba6b-78ad-644f-ce5074f2fbed@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=agordeev@linux.ibm.com \
--cc=christian.brauner@ubuntu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).