linux-kselftest.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Correct .gitignore in several places for kselftest outputs
@ 2021-01-28  3:37 Erik Hollensbe
  2021-01-28  3:37 ` [PATCH] Correct leftover directories from make kselftest Erik Hollensbe
  0 siblings, 1 reply; 6+ messages in thread
From: Erik Hollensbe @ 2021-01-28  3:37 UTC (permalink / raw)
  To: linux-kselftest; +Cc: shuah

Sincerely hope I did this right; first time contributor, learning the
patch workflow. I took the opportunity to fix two .gitignore files that
were leaving stale worktree/index outputs after running `make kselftest`
against recent mainline (76c057c84d286140c6c416c3b4ba832cd1d8984e).

Thanks for your time!



^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] Correct leftover directories from make kselftest
  2021-01-28  3:37 Correct .gitignore in several places for kselftest outputs Erik Hollensbe
@ 2021-01-28  3:37 ` Erik Hollensbe
  2021-02-09  0:17   ` Shuah Khan
  0 siblings, 1 reply; 6+ messages in thread
From: Erik Hollensbe @ 2021-01-28  3:37 UTC (permalink / raw)
  To: linux-kselftest; +Cc: shuah, Erik Hollensbe

Here are some directories that are created/filled as a part of the make
kselftest process, but not ignored.

Signed-off-by: Erik Hollensbe <erik@hollensbe.org>
---
 tools/testing/selftests/gpio/.gitignore   | 1 +
 tools/testing/selftests/timens/.gitignore | 1 +
 2 files changed, 2 insertions(+)

diff --git a/tools/testing/selftests/gpio/.gitignore b/tools/testing/selftests/gpio/.gitignore
index 4c69408f3e84..640b5cb4ed4e 100644
--- a/tools/testing/selftests/gpio/.gitignore
+++ b/tools/testing/selftests/gpio/.gitignore
@@ -1,2 +1,3 @@
 # SPDX-License-Identifier: GPL-2.0-only
 gpio-mockup-chardev
+tools-gpio
diff --git a/tools/testing/selftests/timens/.gitignore b/tools/testing/selftests/timens/.gitignore
index 2e43851b47c1..95e97d7bc336 100644
--- a/tools/testing/selftests/timens/.gitignore
+++ b/tools/testing/selftests/timens/.gitignore
@@ -7,3 +7,4 @@ procfs
 timens
 timer
 timerfd
+futex
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] Correct leftover directories from make kselftest
  2021-01-28  3:37 ` [PATCH] Correct leftover directories from make kselftest Erik Hollensbe
@ 2021-02-09  0:17   ` Shuah Khan
  2021-02-09  0:28     ` Shuah Khan
                       ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Shuah Khan @ 2021-02-09  0:17 UTC (permalink / raw)
  To: Erik Hollensbe, linux-kselftest; +Cc: shuah, Shuah Khan

On 1/27/21 8:37 PM, Erik Hollensbe wrote:
> Here are some directories that are created/filled as a part of the make
> kselftest process, but not ignored.
> 
> Signed-off-by: Erik Hollensbe <erik@hollensbe.org>
> ---
>   tools/testing/selftests/gpio/.gitignore   | 1 +
>   tools/testing/selftests/timens/.gitignore | 1 +
>   2 files changed, 2 insertions(+)
> 
> diff --git a/tools/testing/selftests/gpio/.gitignore b/tools/testing/selftests/gpio/.gitignore
> index 4c69408f3e84..640b5cb4ed4e 100644
> --- a/tools/testing/selftests/gpio/.gitignore
> +++ b/tools/testing/selftests/gpio/.gitignore
> @@ -1,2 +1,3 @@
>   # SPDX-License-Identifier: GPL-2.0-only
>   gpio-mockup-chardev
> +tools-gpio
> diff --git a/tools/testing/selftests/timens/.gitignore b/tools/testing/selftests/timens/.gitignore
> index 2e43851b47c1..95e97d7bc336 100644
> --- a/tools/testing/selftests/timens/.gitignore
> +++ b/tools/testing/selftests/timens/.gitignore
> @@ -7,3 +7,4 @@ procfs
>   timens
>   timer
>   timerfd
> +futex
> 

Thank you for the patch.

Can you split these into two patches? make separate patches for gpio
and timens.

Gives you more practice. :)

thanks,
-- Shuah

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] Correct leftover directories from make kselftest
  2021-02-09  0:17   ` Shuah Khan
@ 2021-02-09  0:28     ` Shuah Khan
  2021-02-09 10:09     ` [PATCH] selftests/gpio: Adjust .gitignore to ignore tools-gpio build dir Erik Hollensbe
  2021-02-09 10:36     ` [PATCH] Correct leftover directories from make kselftest Erik Hollensbe
  2 siblings, 0 replies; 6+ messages in thread
From: Shuah Khan @ 2021-02-09  0:28 UTC (permalink / raw)
  To: Erik Hollensbe, linux-kselftest; +Cc: shuah, Tobias Klauser, Shuah Khan

On 2/8/21 5:17 PM, Shuah Khan wrote:
> On 1/27/21 8:37 PM, Erik Hollensbe wrote:
>> Here are some directories that are created/filled as a part of the make
>> kselftest process, but not ignored.
>>
>> Signed-off-by: Erik Hollensbe <erik@hollensbe.org>
>> ---
>>   tools/testing/selftests/gpio/.gitignore   | 1 +
>>   tools/testing/selftests/timens/.gitignore | 1 +
>>   2 files changed, 2 insertions(+)
>>
>> diff --git a/tools/testing/selftests/gpio/.gitignore 
>> b/tools/testing/selftests/gpio/.gitignore
>> index 4c69408f3e84..640b5cb4ed4e 100644
>> --- a/tools/testing/selftests/gpio/.gitignore
>> +++ b/tools/testing/selftests/gpio/.gitignore
>> @@ -1,2 +1,3 @@
>>   # SPDX-License-Identifier: GPL-2.0-only
>>   gpio-mockup-chardev
>> +tools-gpio
>> diff --git a/tools/testing/selftests/timens/.gitignore 
>> b/tools/testing/selftests/timens/.gitignore
>> index 2e43851b47c1..95e97d7bc336 100644
>> --- a/tools/testing/selftests/timens/.gitignore
>> +++ b/tools/testing/selftests/timens/.gitignore
>> @@ -7,3 +7,4 @@ procfs
>>   timens
>>   timer
>>   timerfd
>> +futex
>>
> 
> Thank you for the patch.
> 
> Can you split these into two patches? make separate patches for gpio
> and timens.
> 

Please send me just the gpio patch. I already applied this patch that
fixes timens .gitignore.

https://patchwork.kernel.org/project/linux-kselftest/patch/20201218165651.4538-1-tklauser@distanz.ch/

thanks,
-- Shuah

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] selftests/gpio: Adjust .gitignore to ignore tools-gpio build dir
  2021-02-09  0:17   ` Shuah Khan
  2021-02-09  0:28     ` Shuah Khan
@ 2021-02-09 10:09     ` Erik Hollensbe
  2021-02-09 10:36     ` [PATCH] Correct leftover directories from make kselftest Erik Hollensbe
  2 siblings, 0 replies; 6+ messages in thread
From: Erik Hollensbe @ 2021-02-09 10:09 UTC (permalink / raw)
  To: linux-kselftest; +Cc: shuah, skhan, Erik Hollensbe

This patch merely add this to gitignore, noticed while running the
selftests.

Signed-off-by: Erik Hollensbe <linux@hollensbe.org>
---
 tools/testing/selftests/gpio/.gitignore | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/gpio/.gitignore b/tools/testing/selftests/gpio/.gitignore
index 4c69408f3e84..640b5cb4ed4e 100644
--- a/tools/testing/selftests/gpio/.gitignore
+++ b/tools/testing/selftests/gpio/.gitignore
@@ -1,2 +1,3 @@
 # SPDX-License-Identifier: GPL-2.0-only
 gpio-mockup-chardev
+tools-gpio
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] Correct leftover directories from make kselftest
  2021-02-09  0:17   ` Shuah Khan
  2021-02-09  0:28     ` Shuah Khan
  2021-02-09 10:09     ` [PATCH] selftests/gpio: Adjust .gitignore to ignore tools-gpio build dir Erik Hollensbe
@ 2021-02-09 10:36     ` Erik Hollensbe
  2 siblings, 0 replies; 6+ messages in thread
From: Erik Hollensbe @ 2021-02-09 10:36 UTC (permalink / raw)
  To: Shuah Khan, Erik Hollensbe, linux-kselftest; +Cc: shuah

On Mon Feb 8, 2021 at 4:17 PM PST, Shuah Khan wrote:
> Thank you for the patch.
>
> Can you split these into two patches? make separate patches for gpio
> and timens.
>
> Gives you more practice. :)

I sent one for gpio; under a different email address (this one), it does
reference the initial patch, however.

Hope that works. Thanks for letting me practice! :D

-Erik

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-02-09 10:40 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-28  3:37 Correct .gitignore in several places for kselftest outputs Erik Hollensbe
2021-01-28  3:37 ` [PATCH] Correct leftover directories from make kselftest Erik Hollensbe
2021-02-09  0:17   ` Shuah Khan
2021-02-09  0:28     ` Shuah Khan
2021-02-09 10:09     ` [PATCH] selftests/gpio: Adjust .gitignore to ignore tools-gpio build dir Erik Hollensbe
2021-02-09 10:36     ` [PATCH] Correct leftover directories from make kselftest Erik Hollensbe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).