* [PATCH] selftests: sched: Add more core schedule prctl calls
@ 2023-03-22 20:37 Ivan Orlov
2023-03-27 19:55 ` Shuah Khan
0 siblings, 1 reply; 2+ messages in thread
From: Ivan Orlov @ 2023-03-22 20:37 UTC (permalink / raw)
To: shuah
Cc: Ivan Orlov, linux-kselftest, linux-kernel, himadrispandya,
linux-kernel-mentees
The core sched kselftest makes prctl calls only with correct
parameters. This patch will extend this test with more core
schedule prctl calls with wrong parameters to increase code
coverage.
Signed-off-by: Ivan Orlov <ivan.orlov0322@gmail.com>
---
tools/testing/selftests/sched/cs_prctl_test.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/tools/testing/selftests/sched/cs_prctl_test.c b/tools/testing/selftests/sched/cs_prctl_test.c
index 25e0d95d3713..df8e4629b3b5 100644
--- a/tools/testing/selftests/sched/cs_prctl_test.c
+++ b/tools/testing/selftests/sched/cs_prctl_test.c
@@ -334,6 +334,14 @@ int main(int argc, char *argv[])
validate(get_cs_cookie(pid) != 0);
validate(get_cs_cookie(pid) == get_cs_cookie(procs[pidx].thr_tids[0]));
+ printf("\n## Try to pass wrong subcommand PR_SCHED_CORE_MAX = %d to prctl (shouldn't succeed)\n", PR_SCHED_CORE_MAX);
+ validate(_prctl(PR_SCHED_CORE, PR_SCHED_CORE_MAX, 0, PIDTYPE_PGID, 0) < 0
+ && errno == EINVAL);
+
+ printf("\n## Try to pass not-null uaddr with forbidden command (shouldn't succeed)\n");
+ validate(_prctl(PR_SCHED_CORE, PR_SCHED_CORE_SHARE_TO, 0, PIDTYPE_PGID, 1) < 0
+ && errno == EINVAL);
+
if (errors) {
printf("TESTS FAILED. errors: %d\n", errors);
res = 10;
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] selftests: sched: Add more core schedule prctl calls
2023-03-22 20:37 [PATCH] selftests: sched: Add more core schedule prctl calls Ivan Orlov
@ 2023-03-27 19:55 ` Shuah Khan
0 siblings, 0 replies; 2+ messages in thread
From: Shuah Khan @ 2023-03-27 19:55 UTC (permalink / raw)
To: Ivan Orlov, shuah
Cc: linux-kselftest, linux-kernel, himadrispandya,
linux-kernel-mentees, Shuah Khan
Hi Ivan,
On 3/22/23 14:37, Ivan Orlov wrote:
> The core sched kselftest makes prctl calls only with correct
> parameters. This patch will extend this test with more core
> schedule prctl calls with wrong parameters to increase code
> coverage.
>
> Signed-off-by: Ivan Orlov <ivan.orlov0322@gmail.com>
Thank you for the patch.
> ---
> tools/testing/selftests/sched/cs_prctl_test.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/tools/testing/selftests/sched/cs_prctl_test.c b/tools/testing/selftests/sched/cs_prctl_test.c
> index 25e0d95d3713..df8e4629b3b5 100644
> --- a/tools/testing/selftests/sched/cs_prctl_test.c
> +++ b/tools/testing/selftests/sched/cs_prctl_test.c
> @@ -334,6 +334,14 @@ int main(int argc, char *argv[])
> validate(get_cs_cookie(pid) != 0);
> validate(get_cs_cookie(pid) == get_cs_cookie(procs[pidx].thr_tids[0]));
>
> + printf("\n## Try to pass wrong subcommand PR_SCHED_CORE_MAX = %d to prctl (shouldn't succeed)\n", PR_SCHED_CORE_MAX);
This message is unnecessary. validate() prints an error message.
> + validate(_prctl(PR_SCHED_CORE, PR_SCHED_CORE_MAX, 0, PIDTYPE_PGID, 0) < 0
> + && errno == EINVAL);
> +
> + printf("\n## Try to pass not-null uaddr with forbidden command (shouldn't succeed)\n");
Same here.
> + validate(_prctl(PR_SCHED_CORE, PR_SCHED_CORE_SHARE_TO, 0, PIDTYPE_PGID, 1) < 0
> + && errno == EINVAL);
> +
> if (errors) {
> printf("TESTS FAILED. errors: %d\n", errors);
> res = 10;
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-27 19:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-22 20:37 [PATCH] selftests: sched: Add more core schedule prctl calls Ivan Orlov
2023-03-27 19:55 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).