[PATCH] selftests/ftrace: Add CONFIG_SAMPLE_FTRACE_DIRECT=m kconfig

[PATCH] selftests/ftrace: Add CONFIG_SAMPLE_FTRACE_DIRECT=m kconfig

[Xiao Yang]

ftrace-direct.tc and kprobe-direct.tc require CONFIG_SAMPLE_FTRACE_DIRECT=m
so add it to config file which is used by merge_config.sh.

Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
---
 tools/testing/selftests/ftrace/config | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/ftrace/config b/tools/testing/selftests/ftrace/config
index c2c8de4fafff..e59d985eeff0 100644
--- a/tools/testing/selftests/ftrace/config
+++ b/tools/testing/selftests/ftrace/config
@@ -11,5 +11,6 @@ CONFIG_PREEMPTIRQ_DELAY_TEST=m
 CONFIG_MODULES=y
 CONFIG_MODULE_UNLOAD=y
 CONFIG_SAMPLES=y
+CONFIG_SAMPLE_FTRACE_DIRECT=m
 CONFIG_SAMPLE_TRACE_PRINTK=m
 CONFIG_KALLSYMS_ALL=y
-- 
2.25.1

Re: [PATCH] selftests/ftrace: Add CONFIG_SAMPLE_FTRACE_DIRECT=m kconfig

[Steven Rostedt]

On Sun, 5 Apr 2020 09:44:57 +0800
Xiao Yang <yangx.jy@cn.fujitsu.com> wrote:

> ftrace-direct.tc and kprobe-direct.tc require CONFIG_SAMPLE_FTRACE_DIRECT=m
> so add it to config file which is used by merge_config.sh.


Shuah,

Care to take this in your tree?

Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

-- Steve

> 
> Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
> ---
>  tools/testing/selftests/ftrace/config | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/ftrace/config b/tools/testing/selftests/ftrace/config
> index c2c8de4fafff..e59d985eeff0 100644
> --- a/tools/testing/selftests/ftrace/config
> +++ b/tools/testing/selftests/ftrace/config
> @@ -11,5 +11,6 @@ CONFIG_PREEMPTIRQ_DELAY_TEST=m
>  CONFIG_MODULES=y
>  CONFIG_MODULE_UNLOAD=y
>  CONFIG_SAMPLES=y
> +CONFIG_SAMPLE_FTRACE_DIRECT=m
>  CONFIG_SAMPLE_TRACE_PRINTK=m
>  CONFIG_KALLSYMS_ALL=y

Re: [PATCH] selftests/ftrace: Add CONFIG_SAMPLE_FTRACE_DIRECT=m kconfig

[Shuah Khan]

On 4/6/20 7:23 AM, Steven Rostedt wrote:
> On Sun, 5 Apr 2020 09:44:57 +0800
> Xiao Yang <yangx.jy@cn.fujitsu.com> wrote:
> 
>> ftrace-direct.tc and kprobe-direct.tc require CONFIG_SAMPLE_FTRACE_DIRECT=m
>> so add it to config file which is used by merge_config.sh.
> 
> 
> Shuah,
> 
> Care to take this in your tree?
> 
> Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> 

Yes. I will apply this for next rc.

thanks,
-- Shuah

Re: [PATCH] selftests/ftrace: Add CONFIG_SAMPLE_FTRACE_DIRECT=m kconfig

[Shuah Khan]

Hi Xiao Yang,

On 4/6/20 8:52 AM, Shuah Khan wrote:
> On 4/6/20 7:23 AM, Steven Rostedt wrote:
>> On Sun, 5 Apr 2020 09:44:57 +0800
>> Xiao Yang <yangx.jy@cn.fujitsu.com> wrote:
>>
>>> ftrace-direct.tc and kprobe-direct.tc require 
>>> CONFIG_SAMPLE_FTRACE_DIRECT=m
>>> so add it to config file which is used by merge_config.sh.
>>
>>
>> Shuah,
>>
>> Care to take this in your tree?
>>
>> Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
>>
> 

I took this patch and sending it in my pull request. Please
make sure your commit logs don't wrap in your future patches.
It makes it easier to read commit logs.

"Without CONFIG_DYNAMIC_FTRACE, some tests get failure because required
     filter 
files(set_ftrace_filter/available_filter_functions/stack_trace_filter)
     are missing.  So implement check_filter_file() and make all related 
tests
     check required filter files by it.

     BTW: set_ftrace_filter and available_filter_functions are 
introduced together
     so just check either of them."


thanks,
-- Shuah