Linux-kselftest Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] selftests:mptcp: fix empty optstring
@ 2020-04-02  6:52 Li Zhijian
  2020-04-02  7:21 ` Matthieu Baerts
  2020-05-11  4:47 ` Li Zhijian
  0 siblings, 2 replies; 4+ messages in thread
From: Li Zhijian @ 2020-04-02  6:52 UTC (permalink / raw)
  To: shuah, linux-kselftest; +Cc: linux-kernel, matthieu.baerts, Li Zhijian

From: Li Zhijian <lizhijian@cn.fujitsu.com>

Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
---
 tools/testing/selftests/net/mptcp/pm_netlink.sh | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tools/testing/selftests/net/mptcp/pm_netlink.sh b/tools/testing/selftests/net/mptcp/pm_netlink.sh
index 9172746b6cf0..8c7998c64d9e 100755
--- a/tools/testing/selftests/net/mptcp/pm_netlink.sh
+++ b/tools/testing/selftests/net/mptcp/pm_netlink.sh
@@ -8,8 +8,7 @@ usage() {
 	echo "Usage: $0 [ -h ]"
 }
 
-
-while getopts "$optstring" option;do
+while getopts "h" option;do
 	case "$option" in
 	"h")
 		usage $0
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] selftests:mptcp: fix empty optstring
  2020-04-02  6:52 [PATCH] selftests:mptcp: fix empty optstring Li Zhijian
@ 2020-04-02  7:21 ` Matthieu Baerts
  2020-05-11  4:47 ` Li Zhijian
  1 sibling, 0 replies; 4+ messages in thread
From: Matthieu Baerts @ 2020-04-02  7:21 UTC (permalink / raw)
  To: Li Zhijian, shuah, linux-kselftest; +Cc: linux-kernel, Li Zhijian

On 02/04/2020 08:52, Li Zhijian wrote:
> From: Li Zhijian <lizhijian@cn.fujitsu.com>
> 
> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>

LGTM, thanks Li!

Reviewed-by: Matthieu Baerts <matthieu.baerts@tessares.net>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] selftests:mptcp: fix empty optstring
  2020-04-02  6:52 [PATCH] selftests:mptcp: fix empty optstring Li Zhijian
  2020-04-02  7:21 ` Matthieu Baerts
@ 2020-05-11  4:47 ` Li Zhijian
  2020-05-22 15:00   ` shuah
  1 sibling, 1 reply; 4+ messages in thread
From: Li Zhijian @ 2020-05-11  4:47 UTC (permalink / raw)
  To: shuah; +Cc: Li Zhijian, linux-kselftest, linux-kernel, matthieu.baerts

ping


On 4/2/20 2:52 PM, Li Zhijian wrote:
> From: Li Zhijian <lizhijian@cn.fujitsu.com>
>
> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
> ---
>   tools/testing/selftests/net/mptcp/pm_netlink.sh | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/net/mptcp/pm_netlink.sh b/tools/testing/selftests/net/mptcp/pm_netlink.sh
> index 9172746b6cf0..8c7998c64d9e 100755
> --- a/tools/testing/selftests/net/mptcp/pm_netlink.sh
> +++ b/tools/testing/selftests/net/mptcp/pm_netlink.sh
> @@ -8,8 +8,7 @@ usage() {
>   	echo "Usage: $0 [ -h ]"
>   }
>   
> -
> -while getopts "$optstring" option;do
> +while getopts "h" option;do
>   	case "$option" in
>   	"h")
>   		usage $0




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] selftests:mptcp: fix empty optstring
  2020-05-11  4:47 ` Li Zhijian
@ 2020-05-22 15:00   ` shuah
  0 siblings, 0 replies; 4+ messages in thread
From: shuah @ 2020-05-22 15:00 UTC (permalink / raw)
  To: Li Zhijian, David S. Miller
  Cc: Li Zhijian, linux-kselftest, linux-kernel, matthieu.baerts,
	netdev, shuah

On 5/10/20 10:47 PM, Li Zhijian wrote:
> ping
> 
> 
> On 4/2/20 2:52 PM, Li Zhijian wrote:
>> From: Li Zhijian <lizhijian@cn.fujitsu.com>
>>
>> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
>> ---
>>   tools/testing/selftests/net/mptcp/pm_netlink.sh | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/tools/testing/selftests/net/mptcp/pm_netlink.sh 
>> b/tools/testing/selftests/net/mptcp/pm_netlink.sh
>> index 9172746b6cf0..8c7998c64d9e 100755
>> --- a/tools/testing/selftests/net/mptcp/pm_netlink.sh
>> +++ b/tools/testing/selftests/net/mptcp/pm_netlink.sh
>> @@ -8,8 +8,7 @@ usage() {
>>       echo "Usage: $0 [ -h ]"
>>   }
>> -
>> -while getopts "$optstring" option;do
>> +while getopts "h" option;do
>>       case "$option" in
>>       "h")
>>           usage $0
> 
> 
> 
> 

Li Zhijian,

You are missing netdev and net maintainer.
Adding netdev and Dave M.

net tests go through net tree and need review/Ack from Dave M.

Dave! Please review and let me know if you want me to take this through
kselftest tree.

thanks,
-- Shuah

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-02  6:52 [PATCH] selftests:mptcp: fix empty optstring Li Zhijian
2020-04-02  7:21 ` Matthieu Baerts
2020-05-11  4:47 ` Li Zhijian
2020-05-22 15:00   ` shuah

Linux-kselftest Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-kselftest/0 linux-kselftest/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-kselftest linux-kselftest/ https://lore.kernel.org/linux-kselftest \
		linux-kselftest@vger.kernel.org
	public-inbox-index linux-kselftest

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kselftest


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git