archive mirror
 help / color / mirror / Atom feed
From: Jonathan Corbet <>
To: Marco Elver <>, Harinder Singh <>
Subject: Re: [PATCH v4 3/7] Documentation: KUnit: Added KUnit Architecture
Date: Thu, 16 Dec 2021 16:15:20 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Marco Elver <> writes:

> In response to the other email: Adding binary blobs just creates
> problems, for comparing different versions, and general bloating the
> whole repo, where better alternatives exist.
> I suppose an ASCII diagram is a bit primitive. :-)
> However, SVG files on the other hand are not binary blobs, they are
> text-markup based (XML), and e.g. diffing them often provides useful
> information about what changed. SVG also has the benefit of being
> vector graphics, and not being limited to one resolution.
> Looking at the diagram you added, I think this can easily be turned
> into vector graphics, and most likely will not use up 24KiB as a
> result.

I agree with all of this; we shouldn't be adding binary images to the
docs, and we've decided at other times that SVG is generally the best
compromise there.

Thanks, Marco, for pointing this out and producing an alternative.

Once this is all settled, do you want it to go through the docs tree?


  parent reply	other threads:[~2021-12-16 23:15 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-16  5:59 [PATCH v4 0/7] Documentation: KUnit: Rework KUnit documentation Harinder Singh
2021-12-16  5:59 ` [PATCH v4 1/7] Documentation: KUnit: Rewrite main page Harinder Singh
2021-12-16  5:59 ` [PATCH v4 2/7] Documentation: KUnit: Rewrite getting started Harinder Singh
2021-12-16  5:59 ` [PATCH v4 3/7] Documentation: KUnit: Added KUnit Architecture Harinder Singh
2021-12-16 10:15   ` Marco Elver
2021-12-16 13:16     ` Marco Elver
2021-12-16 23:15     ` Jonathan Corbet [this message]
2021-12-17  4:56       ` Harinder Singh
2021-12-17  5:07         ` Brendan Higgins
2021-12-16  5:59 ` [PATCH v4 4/7] Documentation: kunit: Reorganize documentation related to running tests Harinder Singh
2021-12-16  5:59 ` [PATCH v4 5/7] Documentation: KUnit: Rework writing page to focus on writing tests Harinder Singh
2021-12-16  5:59 ` [PATCH v4 6/7] Documentation: KUnit: Restyle Test Style and Nomenclature page Harinder Singh
2021-12-16  5:59 ` [PATCH v4 7/7] Documentation: KUnit: Restyled Frequently Asked Questions Harinder Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).