Re: [PATCH v4 3/7] Documentation: KUnit: Added KUnit Architecture

[Brendan Higgins <brendanhiggins@google.com>]

On Thu, Dec 16, 2021 at 11:57 PM Harinder Singh <sharinder@google.com> wrote:
>
> Hello Jonathan and Marco,
>
>
> On Fri, Dec 17, 2021 at 4:45 AM Jonathan Corbet <corbet@lwn.net> wrote:
> >
> > Marco Elver <elver@google.com> writes:
> >
> > > In response to the other email: Adding binary blobs just creates
> > > problems, for comparing different versions, and general bloating the
> > > whole repo, where better alternatives exist.
> > >
> > > I suppose an ASCII diagram is a bit primitive. :-)
> > >
> > > However, SVG files on the other hand are not binary blobs, they are
> > > text-markup based (XML), and e.g. diffing them often provides useful
> > > information about what changed. SVG also has the benefit of being
> > > vector graphics, and not being limited to one resolution.
> > >
> > > Looking at the diagram you added, I think this can easily be turned
> > > into vector graphics, and most likely will not use up 24KiB as a
> > > result.
> >
> > I agree with all of this; we shouldn't be adding binary images to the
> > docs, and we've decided at other times that SVG is generally the best
> > compromise there.
> >
> I did not realize that .SVG is in XML format and preferred over .PNG.
> Thanks for pointing this out. I replaced .SVG with .PNG.
>
> > Thanks, Marco, for pointing this out and producing an alternative.
> >
> A big thanks to Marco for creating  this .SVG file for the documentation :-)
>
> > Once this is all settled, do you want it to go through the docs tree?
> >
> Yeah! that's the plan.

Yep, please take this through the docs tree.

I will send out my Reviewed-by on the other patches shortly.