Linux-kselftest Archive on lore.kernel.org
 help / color / Atom feed
From: shuah <shuah@kernel.org>
To: Eugene Syromiatnikov <esyr@redhat.com>,
	linux-kernel@vger.kernel.org,
	Christian Brauner <christian@brauner.io>,
	linux-kselftest@vger.kernel.org
Cc: Adrian Reber <areber@redhat.com>, shuah <shuah@kernel.org>
Subject: Re: [PATCH 6/6] selftests: add clone3 to TARGETS
Date: Mon, 16 Sep 2019 10:48:37 -0600
Message-ID: <8bbd08bf-3500-40c7-ca15-06d0c84b596f@kernel.org> (raw)
In-Reply-To: <af8501d68f99c38232f9c462877ff562011c8bb5.1568116761.git.esyr@redhat.com>

On 9/10/19 6:03 AM, Eugene Syromiatnikov wrote:
> * tools/testing/selftests/Makefile (TARGETS): Add clone3.

Again. No filenames in the commit log. Please add more detail.


"Adding clone3() tests to kselftest default run and details
on what this tests"

This will be helpful to users.

> 
> Signed-off-by: Eugene Syromiatnikov <esyr@redhat.com>
> ---
>   tools/testing/selftests/Makefile | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
> index 25b43a8c..05163e4 100644
> --- a/tools/testing/selftests/Makefile
> +++ b/tools/testing/selftests/Makefile
> @@ -4,6 +4,7 @@ TARGETS += bpf
>   TARGETS += breakpoints
>   TARGETS += capabilities
>   TARGETS += cgroup
> +TARGETS += clone3
>   TARGETS += cpufreq
>   TARGETS += cpu-hotplug
>   TARGETS += drivers/dma-buf
> 

Please make sure the test doesn't hang and all the use-cases listed
in the kselftest.rst are supported.

make kselftest
make -C tools/testing/selftests
O= and KBUILD_OUTPUT cases as well as running make directly
in the clode3 dir.

Please include test output and usage instructions if any to this
commit log as this is the patch that enables it in the default run.

thanks,
-- Shuah

      reply index

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-10 12:02 [PATCH 0/6] Update clone3 self-tests Eugene Syromiatnikov
2019-09-10 12:03 ` [PATCH 1/6] selftests/clone3: convert test modes into an enum Eugene Syromiatnikov
2019-09-16 16:28   ` shuah
2019-09-10 12:03 ` [PATCH 2/6] selftests/clone3: add a check for invalid exit_signal Eugene Syromiatnikov
2019-09-16 16:37   ` shuah
2019-09-10 12:03 ` [PATCH 3/6] selftests/clone3: use uint64_t for flags parameter Eugene Syromiatnikov
2019-09-16 16:40   ` shuah
2019-09-10 12:03 ` [PATCH 4/6] selftests/clone3: fix up format strings Eugene Syromiatnikov
2019-09-16 16:41   ` shuah
2019-09-10 12:03 ` [PATCH 5/6] selftests/clone3: enable clone3 self-tests on all architectures Eugene Syromiatnikov
2019-09-16 16:44   ` shuah
2019-09-10 12:03 ` [PATCH 6/6] selftests: add clone3 to TARGETS Eugene Syromiatnikov
2019-09-16 16:48   ` shuah [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8bbd08bf-3500-40c7-ca15-06d0c84b596f@kernel.org \
    --to=shuah@kernel.org \
    --cc=areber@redhat.com \
    --cc=christian@brauner.io \
    --cc=esyr@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-kselftest Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-kselftest/0 linux-kselftest/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-kselftest linux-kselftest/ https://lore.kernel.org/linux-kselftest \
		linux-kselftest@vger.kernel.org linux-kselftest@archiver.kernel.org
	public-inbox-index linux-kselftest

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kselftest


AGPL code for this site: git clone https://public-inbox.org/ public-inbox