linux-kselftest.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Gow <davidgow@google.com>
To: Jeremy Kerr <jk@codeconstruct.com.au>
Cc: Matt Johnston <matt@codeconstruct.com.au>,
	Brendan Higgins <brendanhiggins@google.com>,
	"open list:KERNEL SELFTEST FRAMEWORK" 
	<linux-kselftest@vger.kernel.org>,
	Daniel Latypov <dlatypov@google.com>,
	KUnit Development <kunit-dev@googlegroups.com>
Subject: Re: [PATCH net-next 1/2] mctp: test: disallow MCTP_TEST when building as a module
Date: Tue, 12 Oct 2021 12:38:41 +0800	[thread overview]
Message-ID: <CABVgOS=evHzhP5k9EshZM4MG+Zt9qDwn11tf2Q7EaYgVwdWGOQ@mail.gmail.com> (raw)
In-Reply-To: <de7b75062fbc19824111685a9b8119545ee83e35.camel@codeconstruct.com.au>

On Mon, Oct 11, 2021 at 10:10 AM Jeremy Kerr <jk@codeconstruct.com.au> wrote:
>
> Hi David,
>
> > In any case, thanks a lot -- this is awesome.
>
> Oh neat, glad it's useful!
>
> I'm happy to keep hacking on this if it's in a direction that makes
> sense for kunit in general. As an approximate plan, I can fix the UML
> breakages, then work on some resulting simplifications for tree-wide
> initialisers (we'd no longer need the null-terminated arrays of suites
> everywhere, for example).
>
+dlatypov, +kunit-dev

Yeah, we think this would be a much better direction for KUnit to go
for modules. If you're happy to work on it, that'd be great! Brendan,
Daniel (CCed), and I would be more than willing to help out with
questions, reviews, etc, as well.

On the other hand, if you're really busy and you'd rather we pick this
up, improved module support has been on the to-do list for ages, so we
could bump it up the list a bit and finish it off.

The UML breakages were mostly pretty simple: our default config
doesn't require module support at all, so the various functions should
just need to go behind the appropriate #ifdefs. A quick way to test it
is just to run './tools/testing/kunit/kunit.py run' from the kernel
source directory, which will configure, build, and run everything in
the .kunit builddir.

Cheers,
-- David

  reply	other threads:[~2021-10-12  4:38 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-02  2:26 [PATCH net-next 1/2] mctp: test: disallow MCTP_TEST when building as a module Jeremy Kerr
2021-10-02  2:26 ` [PATCH net-next 2/2] mctp: test: defer mdev setup until we've registered Jeremy Kerr
2021-10-02  3:16   ` David Gow
2021-10-03  3:24     ` Jeremy Kerr
2021-10-02  3:10 ` [PATCH net-next 1/2] mctp: test: disallow MCTP_TEST when building as a module David Gow
2021-10-04  2:21   ` Jeremy Kerr
2021-10-06  8:01     ` David Gow
2021-10-11  2:10       ` Jeremy Kerr
2021-10-12  4:38         ` David Gow [this message]
2021-10-12 19:38           ` Brendan Higgins
2021-10-12 20:27           ` Daniel Latypov
2021-10-13 19:16             ` Daniel Latypov
2021-10-12 19:52     ` Brendan Higgins
2021-10-21  6:17       ` Jeremy Kerr
2021-10-21  7:06         ` David Gow
2021-10-25 20:54           ` Brendan Higgins
2022-01-06 10:53           ` Jeremy Kerr
2022-01-28  7:41             ` David Gow
2022-01-28  7:54               ` David Gow
2021-10-02 13:01 ` David Miller
2021-10-03  2:22   ` Jeremy Kerr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABVgOS=evHzhP5k9EshZM4MG+Zt9qDwn11tf2Q7EaYgVwdWGOQ@mail.gmail.com' \
    --to=davidgow@google.com \
    --cc=brendanhiggins@google.com \
    --cc=dlatypov@google.com \
    --cc=jk@codeconstruct.com.au \
    --cc=kunit-dev@googlegroups.com \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=matt@codeconstruct.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).