From: Jeremy Kerr <jk@codeconstruct.com.au>
To: David Gow <davidgow@google.com>
Cc: Networking <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Matt Johnston <matt@codeconstruct.com.au>,
Brendan Higgins <brendanhiggins@google.com>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH net-next 2/2] mctp: test: defer mdev setup until we've registered
Date: Sun, 03 Oct 2021 11:24:30 +0800 [thread overview]
Message-ID: <d5ada7b46f4abc2c5a7ecf0af0e50e356685a25b.camel@codeconstruct.com.au> (raw)
In-Reply-To: <CABVgOSkuN7XPPvnBQFm_h80eFpx_fT0veDPxMefVbiNa_ZQG8g@mail.gmail.com>
Hi David,
> Haha -- you sent this just as I'd come up with the same patch here.
> :-)
>
> With these changes, alongside the rt->dev == NULL in
> mctp_route_release() crash fix mentioned in [1], the tests all pass
> on
> my system. (They also pass under KASAN, which bodes well.)
Awesome, thanks for checking these out. I've since sent a v2 with the
fixes integrated, in order to not break davem's build.
I've refined the rt->dev == NULL case a little; rather than allowing
->dev == NULL in the core code (which should never happen), I've
modified the test's route refcounting so that the route destroy path
should only ever hit the test's own destructor instead (which allows
!rt->dev cases). This means we can keep the ->dev != NULL assumption in
the core, and still handle tests where our fake route->dev is unset.
Cheers,
Jeremy
next prev parent reply other threads:[~2021-10-03 3:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-02 2:26 [PATCH net-next 1/2] mctp: test: disallow MCTP_TEST when building as a module Jeremy Kerr
2021-10-02 2:26 ` [PATCH net-next 2/2] mctp: test: defer mdev setup until we've registered Jeremy Kerr
2021-10-02 3:16 ` David Gow
2021-10-03 3:24 ` Jeremy Kerr [this message]
2021-10-02 3:10 ` [PATCH net-next 1/2] mctp: test: disallow MCTP_TEST when building as a module David Gow
2021-10-04 2:21 ` Jeremy Kerr
2021-10-06 8:01 ` David Gow
2021-10-11 2:10 ` Jeremy Kerr
2021-10-12 4:38 ` David Gow
2021-10-12 19:38 ` Brendan Higgins
2021-10-12 20:27 ` Daniel Latypov
2021-10-13 19:16 ` Daniel Latypov
2021-10-12 19:52 ` Brendan Higgins
2021-10-21 6:17 ` Jeremy Kerr
2021-10-21 7:06 ` David Gow
2021-10-25 20:54 ` Brendan Higgins
2022-01-06 10:53 ` Jeremy Kerr
2022-01-28 7:41 ` David Gow
2022-01-28 7:54 ` David Gow
2021-10-02 13:01 ` David Miller
2021-10-03 2:22 ` Jeremy Kerr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5ada7b46f4abc2c5a7ecf0af0e50e356685a25b.camel@codeconstruct.com.au \
--to=jk@codeconstruct.com.au \
--cc=brendanhiggins@google.com \
--cc=davem@davemloft.net \
--cc=davidgow@google.com \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=matt@codeconstruct.com.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).