From: anders.roxell at linaro.org (Anders Roxell) Subject: [PATCH 2/2] selftests/filesystems: remove Makefile warning Date: Thu, 19 Apr 2018 10:22:01 +0200 [thread overview] Message-ID: <CADYN=9Lw0S8yhnRn3u+0A8Cc3R91V=3PBytU1c+Ns3TNPdB1xw@mail.gmail.com> (raw) In-Reply-To: <21de28f0-41c2-feac-1fec-63a2d76a2398@kernel.org> On 18 April 2018 at 16:54, Shuah Khan <shuah at kernel.org> wrote: > On 04/18/2018 01:52 AM, Anders Roxell wrote: >> When overriding the 'clean' target make throws up warnings: >> Makefile:9: warning: overriding recipe for target 'clean' >> ../lib.mk:98: warning: ignoring old recipe for target 'clean' >> >> In current code we change from TEST_PROGS to TEST_GEN_PROGS and that >> does that we can remove the target 'clean' and 'all'. >> >> Fixes: 10924bc64487 ("selftests: move dnotify_test from Documentation/filesystems") >> Signed-off-by: Anders Roxell <anders.roxell at linaro.org> >> --- >> tools/testing/selftests/filesystems/Makefile | 6 +----- >> 1 file changed, 1 insertion(+), 5 deletions(-) >> >> diff --git a/tools/testing/selftests/filesystems/Makefile b/tools/testing/selftests/filesystems/Makefile >> index 427a401aae5c..a55ac3ac09ad 100644 >> --- a/tools/testing/selftests/filesystems/Makefile >> +++ b/tools/testing/selftests/filesystems/Makefile >> @@ -1,9 +1,5 @@ >> # SPDX-License-Identifier: GPL-2.0 >> -TEST_PROGS := dnotify_test devpts_pts >> +TEST_GEN_PROGS := dnotify_test devpts_pts >> CFLAGS += -I../../../../usr/include/ >> -all: $(TEST_PROGS) >> >> include ../lib.mk >> - >> -clean: >> - rm -fr $(TEST_PROGS) >> > > Hi Anders, > > Michael sent in a patch to fix the problem already. It is in linux-kselftest fixes > branch for 4.17-rc2 > > Classifying dnotify_test to TEST_GEN_PROGS_EXTENDED as Michael is the correct way > to handle this problem. It allows the test to be built and installed and it won't > be run in the main kselftest run. Why don't we want to run them in the main kselftest run? Is the rationale documented somewhere/somehow? If they are long running tests or intrusive tests, can we document with a printout like: === Test ${foo} - SKIPPED (${short_rationale}) === === Test dnotify_test - SKIPPED (long run) === === Test devpts_pts - SKIPPED (intrusive run) === Should there be a variable to turn them on from the main kselftest run? Cheers, Anders > > thanks, > -- Shuah -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: anders.roxell@linaro.org (Anders Roxell) Subject: [PATCH 2/2] selftests/filesystems: remove Makefile warning Date: Thu, 19 Apr 2018 10:22:01 +0200 [thread overview] Message-ID: <CADYN=9Lw0S8yhnRn3u+0A8Cc3R91V=3PBytU1c+Ns3TNPdB1xw@mail.gmail.com> (raw) Message-ID: <20180419082201.NW1GcC74YY35JfoYfBZLdYGzzi0WqsyrzdtE9a0dlro@z> (raw) In-Reply-To: <21de28f0-41c2-feac-1fec-63a2d76a2398@kernel.org> On 18 April 2018@16:54, Shuah Khan <shuah@kernel.org> wrote: > On 04/18/2018 01:52 AM, Anders Roxell wrote: >> When overriding the 'clean' target make throws up warnings: >> Makefile:9: warning: overriding recipe for target 'clean' >> ../lib.mk:98: warning: ignoring old recipe for target 'clean' >> >> In current code we change from TEST_PROGS to TEST_GEN_PROGS and that >> does that we can remove the target 'clean' and 'all'. >> >> Fixes: 10924bc64487 ("selftests: move dnotify_test from Documentation/filesystems") >> Signed-off-by: Anders Roxell <anders.roxell at linaro.org> >> --- >> tools/testing/selftests/filesystems/Makefile | 6 +----- >> 1 file changed, 1 insertion(+), 5 deletions(-) >> >> diff --git a/tools/testing/selftests/filesystems/Makefile b/tools/testing/selftests/filesystems/Makefile >> index 427a401aae5c..a55ac3ac09ad 100644 >> --- a/tools/testing/selftests/filesystems/Makefile >> +++ b/tools/testing/selftests/filesystems/Makefile >> @@ -1,9 +1,5 @@ >> # SPDX-License-Identifier: GPL-2.0 >> -TEST_PROGS := dnotify_test devpts_pts >> +TEST_GEN_PROGS := dnotify_test devpts_pts >> CFLAGS += -I../../../../usr/include/ >> -all: $(TEST_PROGS) >> >> include ../lib.mk >> - >> -clean: >> - rm -fr $(TEST_PROGS) >> > > Hi Anders, > > Michael sent in a patch to fix the problem already. It is in linux-kselftest fixes > branch for 4.17-rc2 > > Classifying dnotify_test to TEST_GEN_PROGS_EXTENDED as Michael is the correct way > to handle this problem. It allows the test to be built and installed and it won't > be run in the main kselftest run. Why don't we want to run them in the main kselftest run? Is the rationale documented somewhere/somehow? If they are long running tests or intrusive tests, can we document with a printout like: === Test ${foo} - SKIPPED (${short_rationale}) === === Test dnotify_test - SKIPPED (long run) === === Test devpts_pts - SKIPPED (intrusive run) === Should there be a variable to turn them on from the main kselftest run? Cheers, Anders > > thanks, > -- Shuah -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-04-19 8:22 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-18 7:52 [PATCH 1/2] selftests/filesystems: devpts_pts included wrong header anders.roxell 2018-04-18 7:52 ` Anders Roxell 2018-04-18 7:52 ` [PATCH 2/2] selftests/filesystems: remove Makefile warning anders.roxell 2018-04-18 7:52 ` Anders Roxell 2018-04-18 14:54 ` shuah 2018-04-18 14:54 ` Shuah Khan 2018-04-18 20:32 ` anders.roxell 2018-04-18 20:32 ` Anders Roxell 2018-04-19 8:22 ` anders.roxell [this message] 2018-04-19 8:22 ` Anders Roxell 2018-04-19 8:56 ` anders.roxell 2018-04-19 8:56 ` Anders Roxell 2018-05-02 14:05 ` [PATCH 1/2] selftests/filesystems: devpts_pts included wrong header christian.brauner 2018-05-02 14:05 ` Christian Brauner 2018-05-04 19:42 ` shuah 2018-05-04 19:42 ` Shuah Khan 2018-05-10 17:26 ` shuah 2018-05-10 17:26 ` Shuah Khan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CADYN=9Lw0S8yhnRn3u+0A8Cc3R91V=3PBytU1c+Ns3TNPdB1xw@mail.gmail.com' \ --to=linux-kselftest@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).