From: Brendan Higgins <brendanhiggins@google.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: David Gow <davidgow@google.com>, Shuah Khan <shuah@kernel.org>,
Kees Cook <keescook@chromium.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
KUnit Development <kunit-dev@googlegroups.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH linux-kselftest/test v2] lib/list-test: add a test for the 'list' doubly linked list
Date: Wed, 16 Oct 2019 13:48:33 -0700 [thread overview]
Message-ID: <CAFd5g46tNs=E5+_H4H9_aSwPJ7XVbCLTUSH6JYmmFK3QxW6Vdg@mail.gmail.com> (raw)
In-Reply-To: <20191011145519.7b7a1d16ecdead9bec212c01@linux-foundation.org>
On Fri, Oct 11, 2019 at 2:55 PM Andrew Morton <akpm@linux-foundation.org> wrote:
>
> On Fri, 11 Oct 2019 14:37:25 -0700 David Gow <davidgow@google.com> wrote:
>
> > On Fri, Oct 11, 2019 at 2:05 PM Andrew Morton <akpm@linux-foundation.org> wrote:
> > >
> > > <looks at kunit>
> > >
> > > Given that everything runs at late_initcall time, shouldn't everything
> > > be __init, __initdata etc so all the code and data doesn't hang around
> > > for ever?
> > >
> >
> > That's an interesting point. We haven't done this for KUnit tests to
> > date, and there is certainly a possibility down the line that we may
> > want to be able to run these tests in other circumstances. (There's
> > some work being done to allow KUnit and KUnit tests to be built as
> > modules here: https://lkml.org/lkml/2019/10/8/628 for example.) Maybe
> > it'd be worth having macros which wrap __init/__initdata etc as a way
> > of futureproofing tests against such a change?
> >
> > Either way, I suspect this is something that should probably be
> > considered for KUnit as a whole, rather than on a test-by-test basis.
>
> Sure, a new set of macros for this makes sense. Can be retrofitted any
> time.
>
> There might be a way of loading all of list_test.o into a discardable
> section at link time instead of sprinkling annotation all over the .c
> code.
I created a bug to track this here:
https://bugzilla.kernel.org/show_bug.cgi?id=205217
next prev parent reply other threads:[~2019-10-16 20:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 18:56 [PATCH linux-kselftest/test v2] lib/list-test: add a test for the 'list' doubly linked list David Gow
2019-10-11 21:05 ` Andrew Morton
2019-10-11 21:07 ` Andrew Morton
2019-10-11 21:37 ` David Gow
2019-10-11 21:55 ` Andrew Morton
2019-10-16 20:48 ` Brendan Higgins [this message]
2019-10-16 21:48 ` David Gow
2019-10-17 0:32 ` Andrew Morton
2019-10-18 21:24 ` shuah
2019-10-18 21:21 ` shuah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFd5g46tNs=E5+_H4H9_aSwPJ7XVbCLTUSH6JYmmFK3QxW6Vdg@mail.gmail.com' \
--to=brendanhiggins@google.com \
--cc=akpm@linux-foundation.org \
--cc=davidgow@google.com \
--cc=keescook@chromium.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).