From: Daniel Latypov <dlatypov@google.com>
To: "Maíra Canal" <mairacanal@riseup.net>
Cc: Brendan Higgins <brendanhiggins@google.com>,
davidgow@google.com, airlied@linux.ie, daniel@ffwll.ch,
davem@davemloft.net, kuba@kernel.org, jose.exposito89@gmail.com,
javierm@redhat.com, andrealmeid@riseup.net,
melissa.srw@gmail.com, siqueirajordao@riseup.net,
Isabella Basso <isabbasso@riseup.net>,
magalilemes00@gmail.com, tales.aparecida@gmail.com,
linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] kunit: Use KUNIT_EXPECT_MEMEQ macro
Date: Tue, 2 Aug 2022 15:29:33 -0700 [thread overview]
Message-ID: <CAGS_qxrbs0K3J5+u3_setrd2NOqE4ADCmuGG-i+5KNoeBb9g6w@mail.gmail.com> (raw)
In-Reply-To: <20220802212621.420840-4-mairacanal@riseup.net>
On Tue, Aug 2, 2022 at 2:27 PM Maíra Canal <mairacanal@riseup.net> wrote:
>
> Use KUNIT_EXPECT_MEMEQ to compare memory blocks in replacement of the
> KUNIT_EXPECT_EQ macro. Therefor, the statement
>
> KUNIT_EXPECT_EQ(test, memcmp(foo, bar, size), 0);
>
> is replaced by:
>
> KUNIT_EXPECT_MEMEQ(test, foo, bar, size);
>
> Signed-off-by: Maíra Canal <mairacanal@riseup.net>
Acked-by: Daniel Latypov <dlatypov@google.com>
I didn't go and find the appropriate commit from the drm tree to base
this on, so I couldn't apply it locally.
But looking at the diff itself, looks good!
prev parent reply other threads:[~2022-08-02 22:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 21:26 [PATCH v2 0/3] Introduce KUNIT_EXPECT_MEMEQ and KUNIT_EXPECT_MEMNEQ macros Maíra Canal
2022-08-02 21:26 ` [PATCH v2 1/3] kunit: " Maíra Canal
2022-08-02 22:24 ` Daniel Latypov
2022-08-02 21:26 ` [PATCH v2 2/3] kunit: Add KUnit memory block assertions to the example_all_expect_macros_test Maíra Canal
2022-08-02 21:57 ` Daniel Latypov
2022-08-02 21:26 ` [PATCH v2 3/3] kunit: Use KUNIT_EXPECT_MEMEQ macro Maíra Canal
2022-08-02 22:29 ` Daniel Latypov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGS_qxrbs0K3J5+u3_setrd2NOqE4ADCmuGG-i+5KNoeBb9g6w@mail.gmail.com \
--to=dlatypov@google.com \
--cc=airlied@linux.ie \
--cc=andrealmeid@riseup.net \
--cc=brendanhiggins@google.com \
--cc=daniel@ffwll.ch \
--cc=davem@davemloft.net \
--cc=davidgow@google.com \
--cc=isabbasso@riseup.net \
--cc=javierm@redhat.com \
--cc=jose.exposito89@gmail.com \
--cc=kuba@kernel.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=magalilemes00@gmail.com \
--cc=mairacanal@riseup.net \
--cc=melissa.srw@gmail.com \
--cc=siqueirajordao@riseup.net \
--cc=tales.aparecida@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).