From: keescook at chromium.org (Kees Cook)
Subject: [PATCH v3 1/7] lib/test_printf: Add empty module_exit function
Date: Tue, 2 Apr 2019 14:24:59 -0700 [thread overview]
Message-ID: <CAGXu5jKs5PZquDwj3B_7P6UH7aahawDkTdf2RWooiuj1uJy4WQ@mail.gmail.com> (raw)
In-Reply-To: <20190306214226.14598-2-tobin@kernel.org>
On Wed, Mar 6, 2019 at 1:43 PM Tobin C. Harding <tobin at kernel.org> wrote:
>
> Currently the test_printf module does not have an exit function, this
> prevents the module from being unloaded. If we cannot unload the
> module we cannot run the tests a second time.
>
> Add an empty exit function.
>
> Signed-off-by: Tobin C. Harding <tobin at kernel.org>
Acked-by: Kees Cook <keescook at chromium.org>
-Kees
> ---
> lib/test_printf.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/lib/test_printf.c b/lib/test_printf.c
> index 659b6cc0d483..601e8519319a 100644
> --- a/lib/test_printf.c
> +++ b/lib/test_printf.c
> @@ -615,5 +615,11 @@ test_printf_init(void)
>
> module_init(test_printf_init);
>
> +static void __exit test_printf_exit(void)
> +{
> +}
> +
> +module_exit(test_printf_exit);
> +
> MODULE_AUTHOR("Rasmus Villemoes <linux at rasmusvillemoes.dk>");
> MODULE_LICENSE("GPL");
> --
> 2.20.1
>
--
Kees Cook
WARNING: multiple messages have this Message-ID (diff)
From: keescook@chromium.org (Kees Cook)
Subject: [PATCH v3 1/7] lib/test_printf: Add empty module_exit function
Date: Tue, 2 Apr 2019 14:24:59 -0700 [thread overview]
Message-ID: <CAGXu5jKs5PZquDwj3B_7P6UH7aahawDkTdf2RWooiuj1uJy4WQ@mail.gmail.com> (raw)
Message-ID: <20190402212459._faUnKrBTCiUeEnhZH3FNq8DKmqF9QggTq9rBifSwRQ@z> (raw)
In-Reply-To: <20190306214226.14598-2-tobin@kernel.org>
On Wed, Mar 6, 2019@1:43 PM Tobin C. Harding <tobin@kernel.org> wrote:
>
> Currently the test_printf module does not have an exit function, this
> prevents the module from being unloaded. If we cannot unload the
> module we cannot run the tests a second time.
>
> Add an empty exit function.
>
> Signed-off-by: Tobin C. Harding <tobin at kernel.org>
Acked-by: Kees Cook <keescook at chromium.org>
-Kees
> ---
> lib/test_printf.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/lib/test_printf.c b/lib/test_printf.c
> index 659b6cc0d483..601e8519319a 100644
> --- a/lib/test_printf.c
> +++ b/lib/test_printf.c
> @@ -615,5 +615,11 @@ test_printf_init(void)
>
> module_init(test_printf_init);
>
> +static void __exit test_printf_exit(void)
> +{
> +}
> +
> +module_exit(test_printf_exit);
> +
> MODULE_AUTHOR("Rasmus Villemoes <linux at rasmusvillemoes.dk>");
> MODULE_LICENSE("GPL");
> --
> 2.20.1
>
--
Kees Cook
next prev parent reply other threads:[~2019-04-02 21:24 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-06 21:42 [PATCH v3 0/7] lib/string: Add strscpy_pad() function tobin
2019-03-06 21:42 ` Tobin C. Harding
2019-03-06 21:42 ` [PATCH v3 1/7] lib/test_printf: Add empty module_exit function tobin
2019-03-06 21:42 ` Tobin C. Harding
2019-04-02 21:24 ` keescook [this message]
2019-04-02 21:24 ` Kees Cook
2019-03-06 21:42 ` [PATCH v3 2/7] kselftest: Add test runner creation script tobin
2019-03-06 21:42 ` Tobin C. Harding
2019-04-02 21:27 ` keescook
2019-04-02 21:27 ` Kees Cook
2019-04-02 21:33 ` rdunlap
2019-04-02 21:33 ` Randy Dunlap
2019-04-04 23:16 ` me
2019-04-04 23:16 ` Tobin C. Harding
2019-03-06 21:42 ` [PATCH v3 3/7] kselftest/lib: Use new shell runner to define tests tobin
2019-03-06 21:42 ` Tobin C. Harding
2019-04-02 21:29 ` keescook
2019-04-02 21:29 ` Kees Cook
2019-04-02 21:45 ` keescook
2019-04-02 21:45 ` Kees Cook
2019-04-02 21:51 ` keescook
2019-04-02 21:51 ` Kees Cook
2019-03-06 21:42 ` [PATCH v3 4/7] kselftest: Add test module framework header tobin
2019-03-06 21:42 ` Tobin C. Harding
2019-04-02 21:31 ` keescook
2019-04-02 21:31 ` Kees Cook
2019-03-06 21:42 ` [PATCH v3 5/7] lib: Use new kselftest header tobin
2019-03-06 21:42 ` Tobin C. Harding
2019-04-02 21:32 ` keescook
2019-04-02 21:32 ` Kees Cook
2019-03-06 21:42 ` [PATCH v3 6/7] lib/string: Add strscpy_pad() function tobin
2019-03-06 21:42 ` Tobin C. Harding
2019-04-02 21:35 ` keescook
2019-04-02 21:35 ` Kees Cook
2019-03-06 21:42 ` [PATCH v3 7/7] lib: Add test module for strscpy_pad tobin
2019-03-06 21:42 ` Tobin C. Harding
2019-04-02 21:36 ` keescook
2019-04-02 21:36 ` Kees Cook
2019-03-06 21:49 ` [PATCH v3 0/7] lib/string: Add strscpy_pad() function me
2019-03-06 21:49 ` Tobin C. Harding
2019-03-07 21:18 ` me
2019-03-07 21:18 ` Tobin C. Harding
2019-03-07 22:43 ` keescook
2019-03-07 22:43 ` Kees Cook
2019-03-08 5:23 ` me
2019-03-08 5:23 ` Tobin C. Harding
2019-03-08 16:18 ` keescook
2019-03-08 16:18 ` Kees Cook
2019-04-02 21:37 ` keescook
2019-04-02 21:37 ` Kees Cook
2019-04-03 0:25 ` me
2019-04-03 0:25 ` Tobin C. Harding
2019-04-03 0:29 ` shuah
2019-04-03 0:29 ` shuah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGXu5jKs5PZquDwj3B_7P6UH7aahawDkTdf2RWooiuj1uJy4WQ@mail.gmail.com \
--to=linux-kselftest@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).