From: ys114321 at gmail.com (Y Song) Subject: [PATCH] selftests: bpf: fix urandom_read build issue Date: Thu, 7 Jun 2018 10:52:02 -0700 [thread overview] Message-ID: <CAH3MdRWo0kUYngyAwXP1sOT_XqbxyfTvDd6sNz+qd7LL1T8LUA@mail.gmail.com> (raw) In-Reply-To: <20180607105712.553-1-anders.roxell@linaro.org> On Thu, Jun 7, 2018 at 3:57 AM, Anders Roxell <anders.roxell at linaro.org> wrote: > gcc complains that urandom_read gets built twice. > > gcc -o tools/testing/selftests/bpf/urandom_read > -static urandom_read.c -Wl,--build-id > gcc -Wall -O2 -I../../../include/uapi -I../../../lib -I../../../lib/bpf > -I../../../../include/generated -I../../../include urandom_read.c > urandom_read -lcap -lelf -lrt -lpthread -o > tools/testing/selftests/bpf/urandom_read > gcc: fatal error: input file > ‘tools/testing/selftests/bpf/urandom_read’ is the > same as output file > compilation terminated. > ../lib.mk:110: recipe for target > 'tools/testing/selftests/bpf/urandom_read' failed What is the build/make command to reproduce the above failure? > To fix this issue remove the urandom_read target and so target > TEST_CUSTOM_PROGS gets used. > > Fixes: 81f77fd0deeb ("bpf: add selftest for stackmap with BPF_F_STACK_BUILD_ID") > Signed-off-by: Anders Roxell <anders.roxell at linaro.org> > --- > tools/testing/selftests/bpf/Makefile | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile > index 607ed8729c06..67285591ffd7 100644 > --- a/tools/testing/selftests/bpf/Makefile > +++ b/tools/testing/selftests/bpf/Makefile > @@ -16,10 +16,8 @@ LDLIBS += -lcap -lelf -lrt -lpthread > TEST_CUSTOM_PROGS = $(OUTPUT)/urandom_read > all: $(TEST_CUSTOM_PROGS) > > -$(TEST_CUSTOM_PROGS): urandom_read > - > -urandom_read: urandom_read.c > - $(CC) -o $(TEST_CUSTOM_PROGS) -static $< -Wl,--build-id > +$(TEST_CUSTOM_PROGS): $(OUTPUT)/%: %.c > + $(CC) -o $@ -static $< -Wl,--build-id > > # Order correspond to 'make run_tests' order > TEST_GEN_PROGS = test_verifier test_tag test_maps test_lru_map test_lpm_map test_progs \ > -- > 2.17.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: ys114321@gmail.com (Y Song) Subject: [PATCH] selftests: bpf: fix urandom_read build issue Date: Thu, 7 Jun 2018 10:52:02 -0700 [thread overview] Message-ID: <CAH3MdRWo0kUYngyAwXP1sOT_XqbxyfTvDd6sNz+qd7LL1T8LUA@mail.gmail.com> (raw) Message-ID: <20180607175202.2iIApar9urvD7ppqr7yHx6q_hSX_xxHUg_v57UT_29M@z> (raw) In-Reply-To: <20180607105712.553-1-anders.roxell@linaro.org> On Thu, Jun 7, 2018@3:57 AM, Anders Roxell <anders.roxell@linaro.org> wrote: > gcc complains that urandom_read gets built twice. > > gcc -o tools/testing/selftests/bpf/urandom_read > -static urandom_read.c -Wl,--build-id > gcc -Wall -O2 -I../../../include/uapi -I../../../lib -I../../../lib/bpf > -I../../../../include/generated -I../../../include urandom_read.c > urandom_read -lcap -lelf -lrt -lpthread -o > tools/testing/selftests/bpf/urandom_read > gcc: fatal error: input file > ‘tools/testing/selftests/bpf/urandom_read’ is the > same as output file > compilation terminated. > ../lib.mk:110: recipe for target > 'tools/testing/selftests/bpf/urandom_read' failed What is the build/make command to reproduce the above failure? > To fix this issue remove the urandom_read target and so target > TEST_CUSTOM_PROGS gets used. > > Fixes: 81f77fd0deeb ("bpf: add selftest for stackmap with BPF_F_STACK_BUILD_ID") > Signed-off-by: Anders Roxell <anders.roxell at linaro.org> > --- > tools/testing/selftests/bpf/Makefile | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile > index 607ed8729c06..67285591ffd7 100644 > --- a/tools/testing/selftests/bpf/Makefile > +++ b/tools/testing/selftests/bpf/Makefile > @@ -16,10 +16,8 @@ LDLIBS += -lcap -lelf -lrt -lpthread > TEST_CUSTOM_PROGS = $(OUTPUT)/urandom_read > all: $(TEST_CUSTOM_PROGS) > > -$(TEST_CUSTOM_PROGS): urandom_read > - > -urandom_read: urandom_read.c > - $(CC) -o $(TEST_CUSTOM_PROGS) -static $< -Wl,--build-id > +$(TEST_CUSTOM_PROGS): $(OUTPUT)/%: %.c > + $(CC) -o $@ -static $< -Wl,--build-id > > # Order correspond to 'make run_tests' order > TEST_GEN_PROGS = test_verifier test_tag test_maps test_lru_map test_lpm_map test_progs \ > -- > 2.17.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-06-07 17:52 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-06-07 10:57 [PATCH] selftests: bpf: fix urandom_read build issue anders.roxell 2018-06-07 10:57 ` Anders Roxell 2018-06-07 17:52 ` ys114321 [this message] 2018-06-07 17:52 ` Y Song 2018-06-07 19:07 ` anders.roxell 2018-06-07 19:07 ` Anders Roxell 2018-06-07 21:17 ` ys114321 2018-06-07 21:17 ` Y Song 2018-06-07 21:43 ` anders.roxell 2018-06-07 21:43 ` Anders Roxell 2018-06-08 5:08 ` ys114321 2018-06-08 5:08 ` Y Song 2018-06-08 6:45 ` anders.roxell 2018-06-08 6:45 ` Anders Roxell 2018-06-08 6:51 ` [PATCH v2] " anders.roxell 2018-06-08 6:51 ` Anders Roxell 2018-06-11 10:58 ` daniel 2018-06-11 10:58 ` Daniel Borkmann
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAH3MdRWo0kUYngyAwXP1sOT_XqbxyfTvDd6sNz+qd7LL1T8LUA@mail.gmail.com \ --to=linux-kselftest@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).