From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Kent Gibson <warthog618@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Shuah Khan <shuah@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v11 2/6] gpiolib: allow to specify the firmware node in struct gpio_chip
Date: Thu, 2 Dec 2021 12:57:38 +0200 [thread overview]
Message-ID: <YaimotqSgHzS2wdA@smile.fi.intel.com> (raw)
In-Reply-To: <CAMRc=MdQ+a7UrE7csg3GsiLXYGkzti-wPUwPh5J=7WBj74OVZg@mail.gmail.com>
On Wed, Dec 01, 2021 at 02:11:28PM +0100, Bartosz Golaszewski wrote:
> On Tue, Nov 30, 2021 at 10:04 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
...
> Let me maybe rephrase the problem: currently, for GPIO devices
> instantiating multiple banks created outside of the OF or ACPI
> frameworks (e.g. instantiated manually and configured using a
> hierarchy of software nodes with a single parent swnode and a number
> of child swnodes representing the children), it is impossible to
> assign firmware nodes other than the one representing the top GPIO
> device to the gpiochip child devices.
>
> In fact if we want to drop the OF APIs entirely from gpiolib - this
> would be the right first step as for gpio-sim it actually replaces the
> gc->of_node = some_of_node; assignment that OF-based drivers do for
> sub-nodes defining banks and it does work with device-tree (I verified
> that too) thanks to the fwnode abstraction layer.
In exchange of acknowledgements I confirm that I understood the issue
you are describing. What I still don't like is this band-aid:ish approach.
What we really need is to replace of_node by fwnode in GPIO library once
for all. But it can be done later after your simulation series (or before,
i.o.w. independently), hence I propose to update TODO and do it separately.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-12-02 10:59 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 15:41 [PATCH v11 0/6] gpio-sim: configfs-based GPIO simulator Bartosz Golaszewski
2021-11-30 15:41 ` [PATCH v11 1/6] gpiolib: provide gpiod_remove_hogs() Bartosz Golaszewski
2021-11-30 15:41 ` [PATCH v11 2/6] gpiolib: allow to specify the firmware node in struct gpio_chip Bartosz Golaszewski
2021-11-30 16:14 ` Andy Shevchenko
2021-11-30 16:19 ` Andy Shevchenko
2021-11-30 16:55 ` Andy Shevchenko
2021-11-30 18:32 ` Bartosz Golaszewski
2021-11-30 20:31 ` Andy Shevchenko
2021-11-30 20:25 ` Bartosz Golaszewski
2021-11-30 20:59 ` Andy Shevchenko
2021-11-30 21:04 ` Bartosz Golaszewski
2021-12-01 13:11 ` Bartosz Golaszewski
2021-12-01 13:39 ` Andy Shevchenko
2021-12-01 13:53 ` Bartosz Golaszewski
2021-12-01 14:28 ` Andy Shevchenko
2021-12-01 14:33 ` Andy Shevchenko
2021-12-01 14:36 ` Bartosz Golaszewski
2021-12-01 14:54 ` Andy Shevchenko
2021-12-02 10:57 ` Andy Shevchenko [this message]
2021-12-02 11:24 ` Bartosz Golaszewski
2021-12-02 11:35 ` Andy Shevchenko
2021-12-02 11:37 ` Andy Shevchenko
2021-12-02 13:06 ` Bartosz Golaszewski
2021-12-02 13:44 ` Andy Shevchenko
2021-12-02 13:52 ` Bartosz Golaszewski
2021-12-02 15:40 ` Andy Shevchenko
2021-12-02 17:00 ` Bartosz Golaszewski
2021-12-02 17:29 ` Andy Shevchenko
2021-11-30 15:41 ` [PATCH v11 3/6] gpio: sim: new testing module Bartosz Golaszewski
2021-11-30 15:41 ` [PATCH v11 4/6] selftests: gpio: provide a helper for reading chip info Bartosz Golaszewski
2021-11-30 15:41 ` [PATCH v11 5/6] selftests: gpio: add a helper for reading GPIO line names Bartosz Golaszewski
2021-11-30 15:41 ` [PATCH v11 6/6] selftests: gpio: add test cases for gpio-sim Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaimotqSgHzS2wdA@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=geert@linux-m68k.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).