From: Vitor Massaru Iha <vitor@massaru.org>
To: David Gow <davidgow@google.com>
Cc: KUnit Development <kunit-dev@googlegroups.com>,
Shuah Khan <skhan@linuxfoundation.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Brendan Higgins <brendanhiggins@google.com>,
linux-kernel-mentees@lists.linuxfoundation.org,
Kees Cook <keescook@chromium.org>,
linux@rasmusvillemoes.dk
Subject: Re: [PATCH] lib: kunit_test_overflow: add KUnit test of check_*_overflow functions
Date: Mon, 15 Jun 2020 13:33:48 -0300 [thread overview]
Message-ID: <b16c0402d866f8a8d5b135086ad93a5a2608e939.camel@massaru.org> (raw)
In-Reply-To: <CABVgOSkMv22GDGin8GCqq4Vd=Bff7-VzEycmzKhUeKj9tErD7Q@mail.gmail.com>
On Sat, 2020-06-13 at 14:56 +0800, David Gow wrote:
> On Fri, Jun 12, 2020 at 5:55 AM Vitor Massaru Iha <vitor@massaru.org>
> wrote:
> > This adds the convertion of the runtime tests of check_*_overflow
> > fuctions,
> > from `lib/test_overflow.c`to KUnit tests.
>
> Nit: couple of minor typos here: convertion -> conversion, and
> functions -> functions
>
> > The log similar to the one seen in dmesg running test_overflow can
> > be
> > seen in `test.log`.
> >
> > Signed-off-by: Vitor Massaru Iha <vitor@massaru.org>
>
> I've tested that this builds and runs on my system, and it all seems
> to be working fine!
>
> Tested-by: David Gow <davidgow@google.com>
>
> > ---
> > lib/Kconfig.debug | 17 ++
> > lib/Makefile | 1 +
> > lib/kunit_overflow_test.c | 590
> > ++++++++++++++++++++++++++++++++++++++
> > 3 files changed, 608 insertions(+)
> > create mode 100644 lib/kunit_overflow_test.c
>
> Echoing what Brendan and Kees mentioned, it'd be nicer to have this
> replace the existing test, both because there's no need for redundant
> tests (one will get out-of-date), and so that we can have a nice diff
> showing the changes made as part of the conversion.
>
> Cheers,
> -- David
Thank you David, I will fix your suggestions.
prev parent reply other threads:[~2020-06-15 16:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 21:55 [PATCH] lib: kunit_test_overflow: add KUnit test of check_*_overflow functions Vitor Massaru Iha
2020-06-12 19:06 ` Brendan Higgins
2020-06-12 22:36 ` Kees Cook
2020-06-13 6:51 ` David Gow
2020-06-14 17:48 ` common KUnit Kconfig and file naming (was: Re: [PATCH] lib: kunit_test_overflow: add KUnit test of check_*_overflow functions) Kees Cook
2020-06-16 7:25 ` David Gow
2020-06-16 9:40 ` Alan Maguire
2020-06-17 4:20 ` David Gow
2020-06-18 20:27 ` Brendan Higgins
2020-06-19 3:42 ` Kees Cook
2020-06-19 6:39 ` David Gow
2020-06-19 20:12 ` Brendan Higgins
2020-06-15 16:30 ` [PATCH] lib: kunit_test_overflow: add KUnit test of check_*_overflow functions Vitor Massaru Iha
2020-06-15 18:37 ` Kees Cook
2020-06-13 6:56 ` David Gow
2020-06-15 16:33 ` Vitor Massaru Iha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b16c0402d866f8a8d5b135086ad93a5a2608e939.camel@massaru.org \
--to=vitor@massaru.org \
--cc=brendanhiggins@google.com \
--cc=davidgow@google.com \
--cc=keescook@chromium.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).