Linux-kselftest Archive on
 help / color / Atom feed
From: shuah <>
To: Ilya Leoshkevich <>
	Heiko Carstens <>,
	Vasily Gorbik <>, shuah <>
Subject: Re: [PATCH v2] selftests: fix prepending $(OUTPUT) to $(TEST_PROGS)
Date: Mon, 16 Sep 2019 10:18:42 -0600
Message-ID: <> (raw)
In-Reply-To: <>

On 9/10/19 6:18 AM, Ilya Leoshkevich wrote:
> The current logic prepends $(OUTPUT) only to the first member of
> $(TEST_PROGS). Use $(addprefix) to prepend it to each member.

Can you please send me the error messages you are seeing so I can see
what is being fixed.

> Also, $(OUTPUT) is assumed to end with a / almost everywhere else in
> the kernel, make this the case for kselftest as well.

Why are these two changes in one patch? Does this fix 1a940687e424?
If so how?

> Fixes: 1a940687e424 ("selftests: copy test scripts and test files for make O=dir run")
> Signed-off-by: Ilya Leoshkevich <>
> ---

-- shuah

  reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-10 12:18 Ilya Leoshkevich
2019-09-16 16:18 ` shuah [this message]
2019-09-30 17:50   ` Ilya Leoshkevich

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-kselftest Archive on

Archives are clonable:
	git clone --mirror linux-kselftest/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-kselftest linux-kselftest/ \
	public-inbox-index linux-kselftest

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone public-inbox