From: shuah <shuah@kernel.org>
To: Ilya Leoshkevich <iii@linux.ibm.com>
Cc: linux-kselftest@vger.kernel.org,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>, shuah <shuah@kernel.org>
Subject: Re: [PATCH v2] selftests: fix prepending $(OUTPUT) to $(TEST_PROGS)
Date: Mon, 16 Sep 2019 10:18:42 -0600 [thread overview]
Message-ID: <cb4e3c3c-3ab8-5d21-495f-5f751c79dde6@kernel.org> (raw)
In-Reply-To: <20190910121813.45742-1-iii@linux.ibm.com>
On 9/10/19 6:18 AM, Ilya Leoshkevich wrote:
> The current logic prepends $(OUTPUT) only to the first member of
> $(TEST_PROGS). Use $(addprefix) to prepend it to each member.
>
Can you please send me the error messages you are seeing so I can see
what is being fixed.
> Also, $(OUTPUT) is assumed to end with a / almost everywhere else in
> the kernel, make this the case for kselftest as well.
Why are these two changes in one patch? Does this fix 1a940687e424?
If so how?
>
> Fixes: 1a940687e424 ("selftests: lib.mk: copy test scripts and test files for make O=dir run")
> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
> ---
thanks,
-- shuah
next prev parent reply other threads:[~2019-09-16 16:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-10 12:18 [PATCH v2] selftests: fix prepending $(OUTPUT) to $(TEST_PROGS) Ilya Leoshkevich
2019-09-16 16:18 ` shuah [this message]
2019-09-30 17:50 ` Ilya Leoshkevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb4e3c3c-3ab8-5d21-495f-5f751c79dde6@kernel.org \
--to=shuah@kernel.org \
--cc=gor@linux.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=iii@linux.ibm.com \
--cc=linux-kselftest@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).