From: Joe Perches <joe@perches.com>
To: Tim.Bird@sony.com, brendanhiggins@google.com
Cc: shuah@kernel.org, sergey.senozhatsky.work@gmail.com,
kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, frowand.list@gmail.com,
sboyd@kernel.org, pmladek@suse.com, sergey.senozhatsky@gmail.com,
rostedt@goodmis.org, rdunlap@infradead.org, sfr@canb.auug.org.au
Subject: Re: [PATCH v2] kunit: fix failure to build without printk
Date: Fri, 30 Aug 2019 16:36:05 -0700 [thread overview]
Message-ID: <f4b4e6047ad7e1e3e37e0bcdff74420ebd2596fa.camel@perches.com> (raw)
In-Reply-To: <ECADFF3FD767C149AD96A924E7EA6EAF977A8416@USCULXMSG01.am.sony.com>
On Fri, 2019-08-30 at 23:22 +0000, Tim.Bird@sony.com wrote:
> > -----Original Message-----
> > From: Brendan Higgins
> >
> > On Fri, Aug 30, 2019 at 3:46 PM Joe Perches <joe@perches.com> wrote:
> > > On Fri, 2019-08-30 at 21:58 +0000, Tim.Bird@sony.com wrote:
> > > > > From: Joe Perches
> > > []
> > > > IMHO %pV should be avoided if possible. Just because people are
> > > > doing it doesn't mean it should be used when it is not necessary.
> > >
> > > Well, as the guy that created %pV, I of course
> > > have a different opinion.
> > >
> > > > > then wouldn't it be easier to pass in the
> > > > > > kernel level as a separate parameter and then strip off all printk
> > > > > > headers like this:
> > > > >
> > > > > Depends on whether or not you care for overall
> > > > > object size. Consolidated formats with the
> > > > > embedded KERN_<LEVEL> like suggested are smaller
> > > > > overall object size.
> > > >
> > > > This is an argument I can agree with. I'm generally in favor of
> > > > things that lessen kernel size creep. :-)
> > >
> > > As am I.
> >
> > Sorry, to be clear, we are talking about the object size penalty due
> > to adding a single parameter to a function. Is that right?
>
> Not exactly. The argument is that pre-pending the different KERN_LEVEL
> strings onto format strings can result in several versions of nearly identical strings
> being compiled into the object file. By parameterizing this (that is, adding
> '%s' into the format string, and putting the level into the string as an argument),
> it prevents this duplication of format strings.
>
> I haven't seen the data on duplication of format strings, and how much this
> affects it, but little things can add up. Whether it matters in this case depends
> on whether the format strings that kunit uses are also used elsewhere in the kernel,
> and whether these same format strings are used with multiple kernel message levels.
deduplication can matter as well, but so far
there is little content with kunit_(err|warn|info(=)
kunit/example-test.c: kunit_info(test, "initializing\n");
kunit/test.c: kunit_err(test,
kunit/test.c: kunit_err(test, "%s", fragment->fragment);
kunit/test.c: kunit_err(test, "\n");
kunit/test.c: kunit_err(test, "%s", buf);
kunit/test.c: kunit_err(test, "failed to initialize: %d\n", ret);
kunit/test.c: kunit_err(test, "test case timed out\n");
kunit/test.c: kunit_err(test, "internal error occurred preventing test case from running: %d\n",
kunit/try-catch.c: kunit_err(test, "try timed out\n");
kunit/try-catch.c: kunit_err(test, "wake_up_process() was never called\n");
kunit/try-catch.c: kunit_err(test, "Unknown error: %d\n", exit_code);
Of these, only two do match other kernel uses.
"initializing\n", "failed to initialize: %d\n"
next prev parent reply other threads:[~2019-08-30 23:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 9:31 [PATCH v2] kunit: fix failure to build without printk Brendan Higgins
2019-08-28 9:49 ` Sergey Senozhatsky
2019-08-28 11:50 ` Petr Mladek
2019-08-29 17:01 ` shuah
2019-08-30 4:44 ` Joe Perches
2019-08-30 4:56 ` Joe Perches
2019-08-30 18:38 ` Brendan Higgins
2019-08-30 20:46 ` Joe Perches
2019-08-30 21:58 ` Tim.Bird
2019-08-30 22:46 ` Joe Perches
2019-08-30 23:02 ` Brendan Higgins
2019-08-30 23:22 ` Tim.Bird
2019-08-30 23:36 ` Joe Perches [this message]
2019-08-30 23:37 ` Brendan Higgins
2019-08-30 23:43 ` Joe Perches
2019-08-31 0:06 ` Tim.Bird
2019-09-02 12:52 ` Petr Mladek
2019-09-02 14:39 ` shuah
2019-08-30 23:29 ` Tim.Bird
2019-08-30 5:19 ` Sergey Senozhatsky
2019-08-28 15:52 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4b4e6047ad7e1e3e37e0bcdff74420ebd2596fa.camel@perches.com \
--to=joe@perches.com \
--cc=Tim.Bird@sony.com \
--cc=brendanhiggins@google.com \
--cc=frowand.list@gmail.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sboyd@kernel.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=sfr@canb.auug.org.au \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).