* [PATCH] leds: ktd2692: Fix a typo in the name of a constant
@ 2019-07-21 21:05 Christophe JAILLET
2019-07-21 21:43 ` Pavel Machek
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Christophe JAILLET @ 2019-07-21 21:05 UTC (permalink / raw)
To: jacek.anaszewski, pavel, dmurphy
Cc: linux-leds, linux-kernel, kernel-janitors, Christophe JAILLET
There is a typo in KTD2962_MM_MIN_CURR_THRESHOLD_SCALE. 6 and 9 are
switched in 2962.
Define and use KTD2692_MM_MIN_CURR_THRESHOLD_SCALE instead.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/leds/leds-ktd2692.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/leds/leds-ktd2692.c b/drivers/leds/leds-ktd2692.c
index 45296aaca9da..44db748c570e 100644
--- a/drivers/leds/leds-ktd2692.c
+++ b/drivers/leds/leds-ktd2692.c
@@ -22,7 +22,7 @@
/* Value related the movie mode */
#define KTD2692_MOVIE_MODE_CURRENT_LEVELS 16
#define KTD2692_MM_TO_FL_RATIO(x) ((x) / 3)
-#define KTD2962_MM_MIN_CURR_THRESHOLD_SCALE 8
+#define KTD2692_MM_MIN_CURR_THRESHOLD_SCALE 8
/* Value related the flash mode */
#define KTD2692_FLASH_MODE_TIMEOUT_LEVELS 8
@@ -253,7 +253,7 @@ static void ktd2692_setup(struct ktd2692_context *led)
ktd2692_expresswire_reset(led);
gpiod_direction_output(led->aux_gpio, KTD2692_LOW);
- ktd2692_expresswire_write(led, (KTD2962_MM_MIN_CURR_THRESHOLD_SCALE - 1)
+ ktd2692_expresswire_write(led, (KTD2692_MM_MIN_CURR_THRESHOLD_SCALE - 1)
| KTD2692_REG_MM_MIN_CURR_THRESHOLD_BASE);
ktd2692_expresswire_write(led, KTD2692_FLASH_MODE_CURR_PERCENT(45)
| KTD2692_REG_FLASH_CURRENT_BASE);
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] leds: ktd2692: Fix a typo in the name of a constant
2019-07-21 21:05 [PATCH] leds: ktd2692: Fix a typo in the name of a constant Christophe JAILLET
@ 2019-07-21 21:43 ` Pavel Machek
2019-07-22 8:43 ` Enrico Weigelt, metux IT consult
2019-07-22 20:13 ` Jacek Anaszewski
2 siblings, 0 replies; 4+ messages in thread
From: Pavel Machek @ 2019-07-21 21:43 UTC (permalink / raw)
To: Christophe JAILLET
Cc: jacek.anaszewski, dmurphy, linux-leds, linux-kernel, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 485 bytes --]
On Sun 2019-07-21 23:05:39, Christophe JAILLET wrote:
> There is a typo in KTD2962_MM_MIN_CURR_THRESHOLD_SCALE. 6 and 9 are
> switched in 2962.
>
> Define and use KTD2692_MM_MIN_CURR_THRESHOLD_SCALE instead.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Pavel Machek <pavel@ucw.cz>
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] leds: ktd2692: Fix a typo in the name of a constant
2019-07-21 21:05 [PATCH] leds: ktd2692: Fix a typo in the name of a constant Christophe JAILLET
2019-07-21 21:43 ` Pavel Machek
@ 2019-07-22 8:43 ` Enrico Weigelt, metux IT consult
2019-07-22 20:13 ` Jacek Anaszewski
2 siblings, 0 replies; 4+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2019-07-22 8:43 UTC (permalink / raw)
To: Christophe JAILLET, jacek.anaszewski, pavel, dmurphy
Cc: linux-leds, linux-kernel, kernel-janitors
On 21.07.19 23:05, Christophe JAILLET wrote:
> There is a typo in KTD2962_MM_MIN_CURR_THRESHOLD_SCALE. 6 and 9 are
> switched in 2962.
>
> Define and use KTD2692_MM_MIN_CURR_THRESHOLD_SCALE instead.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/leds/leds-ktd2692.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/leds/leds-ktd2692.c b/drivers/leds/leds-ktd2692.c
> index 45296aaca9da..44db748c570e 100644
> --- a/drivers/leds/leds-ktd2692.c
> +++ b/drivers/leds/leds-ktd2692.c
> @@ -22,7 +22,7 @@
> /* Value related the movie mode */
> #define KTD2692_MOVIE_MODE_CURRENT_LEVELS 16
> #define KTD2692_MM_TO_FL_RATIO(x) ((x) / 3)
> -#define KTD2962_MM_MIN_CURR_THRESHOLD_SCALE 8
> +#define KTD2692_MM_MIN_CURR_THRESHOLD_SCALE 8
>
> /* Value related the flash mode */
> #define KTD2692_FLASH_MODE_TIMEOUT_LEVELS 8
> @@ -253,7 +253,7 @@ static void ktd2692_setup(struct ktd2692_context *led)
> ktd2692_expresswire_reset(led);
> gpiod_direction_output(led->aux_gpio, KTD2692_LOW);
>
> - ktd2692_expresswire_write(led, (KTD2962_MM_MIN_CURR_THRESHOLD_SCALE - 1)
> + ktd2692_expresswire_write(led, (KTD2692_MM_MIN_CURR_THRESHOLD_SCALE - 1)
> | KTD2692_REG_MM_MIN_CURR_THRESHOLD_BASE);
> ktd2692_expresswire_write(led, KTD2692_FLASH_MODE_CURR_PERCENT(45)
> | KTD2692_REG_FLASH_CURRENT_BASE);
>
Reviewed-By: Enrico Weigelt <info@metux.net>
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] leds: ktd2692: Fix a typo in the name of a constant
2019-07-21 21:05 [PATCH] leds: ktd2692: Fix a typo in the name of a constant Christophe JAILLET
2019-07-21 21:43 ` Pavel Machek
2019-07-22 8:43 ` Enrico Weigelt, metux IT consult
@ 2019-07-22 20:13 ` Jacek Anaszewski
2 siblings, 0 replies; 4+ messages in thread
From: Jacek Anaszewski @ 2019-07-22 20:13 UTC (permalink / raw)
To: Christophe JAILLET, pavel, dmurphy
Cc: linux-leds, linux-kernel, kernel-janitors
Hi Christophe,
Thank you for the patch.
On 7/21/19 11:05 PM, Christophe JAILLET wrote:
> There is a typo in KTD2962_MM_MIN_CURR_THRESHOLD_SCALE. 6 and 9 are
> switched in 2962.
>
> Define and use KTD2692_MM_MIN_CURR_THRESHOLD_SCALE instead.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/leds/leds-ktd2692.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/leds/leds-ktd2692.c b/drivers/leds/leds-ktd2692.c
> index 45296aaca9da..44db748c570e 100644
> --- a/drivers/leds/leds-ktd2692.c
> +++ b/drivers/leds/leds-ktd2692.c
> @@ -22,7 +22,7 @@
> /* Value related the movie mode */
> #define KTD2692_MOVIE_MODE_CURRENT_LEVELS 16
> #define KTD2692_MM_TO_FL_RATIO(x) ((x) / 3)
> -#define KTD2962_MM_MIN_CURR_THRESHOLD_SCALE 8
> +#define KTD2692_MM_MIN_CURR_THRESHOLD_SCALE 8
>
> /* Value related the flash mode */
> #define KTD2692_FLASH_MODE_TIMEOUT_LEVELS 8
> @@ -253,7 +253,7 @@ static void ktd2692_setup(struct ktd2692_context *led)
> ktd2692_expresswire_reset(led);
> gpiod_direction_output(led->aux_gpio, KTD2692_LOW);
>
> - ktd2692_expresswire_write(led, (KTD2962_MM_MIN_CURR_THRESHOLD_SCALE - 1)
> + ktd2692_expresswire_write(led, (KTD2692_MM_MIN_CURR_THRESHOLD_SCALE - 1)
> | KTD2692_REG_MM_MIN_CURR_THRESHOLD_BASE);
> ktd2692_expresswire_write(led, KTD2692_FLASH_MODE_CURR_PERCENT(45)
> | KTD2692_REG_FLASH_CURRENT_BASE);
>
Applied.
--
Best regards,
Jacek Anaszewski
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-07-22 20:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-21 21:05 [PATCH] leds: ktd2692: Fix a typo in the name of a constant Christophe JAILLET
2019-07-21 21:43 ` Pavel Machek
2019-07-22 8:43 ` Enrico Weigelt, metux IT consult
2019-07-22 20:13 ` Jacek Anaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).