Linux-LEDs Archive on lore.kernel.org
 help / color / Atom feed
* Re: WARNING in untrack_pfn
       [not found] <000000000000f70a0e0571ad8ffb@google.com>
@ 2019-04-12 11:42 ` syzbot
  2019-04-12 13:01   ` Pavel Machek
  2019-08-13 10:56 ` syzbot
  1 sibling, 1 reply; 6+ messages in thread
From: syzbot @ 2019-04-12 11:42 UTC (permalink / raw)
  To: Julia.Lawall, bp, dan.j.williams, dave.hansen, dave.jiang,
	haozhong.zhang, hpa, jacek.anaszewski, julia.lawall,
	linux-kernel, linux-leds, luto, mingo, pavel, pbonzini, peterz,
	rkrcmar, rpurdie, syzkaller-bugs, tglx, x86

syzbot has bisected this bug to:

commit c68729119f4d2993bec3c9cb999ad76de5aeddba
Author: Julia Lawall <Julia.Lawall@lip6.fr>
Date:   Sat Jul 15 09:58:19 2017 +0000

     leds: tlc591xx: add missing of_node_put

bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=12cda0f3200000
start commit:   23203e3f Merge branch 'akpm' (patches from Andrew)
git tree:       upstream
final crash:    https://syzkaller.appspot.com/x/report.txt?x=11cda0f3200000
console output: https://syzkaller.appspot.com/x/log.txt?x=16cda0f3200000
kernel config:  https://syzkaller.appspot.com/x/.config?x=861a3573f4e78ba1
dashboard link: https://syzkaller.appspot.com/bug?extid=e1a4f80c370d2381e49f
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=17836d15400000

Reported-by: syzbot+e1a4f80c370d2381e49f@syzkaller.appspotmail.com
Fixes: c68729119f4d ("leds: tlc591xx: add missing of_node_put")

For information about bisection process see: https://goo.gl/tpsmEJ#bisection

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: WARNING in untrack_pfn
  2019-04-12 11:42 ` WARNING in untrack_pfn syzbot
@ 2019-04-12 13:01   ` Pavel Machek
  2019-04-12 13:21     ` Julia Lawall
  0 siblings, 1 reply; 6+ messages in thread
From: Pavel Machek @ 2019-04-12 13:01 UTC (permalink / raw)
  To: syzbot
  Cc: Julia.Lawall, bp, dan.j.williams, dave.hansen, dave.jiang,
	haozhong.zhang, hpa, jacek.anaszewski, linux-kernel, linux-leds,
	luto, mingo, pbonzini, peterz, rkrcmar, rpurdie, syzkaller-bugs,
	tglx, x86

[-- Attachment #1: Type: text/plain, Size: 1369 bytes --]

On Fri 2019-04-12 04:42:01, syzbot wrote:
> syzbot has bisected this bug to:
> 
> commit c68729119f4d2993bec3c9cb999ad76de5aeddba
> Author: Julia Lawall <Julia.Lawall@lip6.fr>
> Date:   Sat Jul 15 09:58:19 2017 +0000
> 
>     leds: tlc591xx: add missing of_node_put
> 
> bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=12cda0f3200000
> start commit:   23203e3f Merge branch 'akpm' (patches from Andrew)
> git tree:       upstream
> final crash:    https://syzkaller.appspot.com/x/report.txt?x=11cda0f3200000
> console output: https://syzkaller.appspot.com/x/log.txt?x=16cda0f3200000
> kernel config:  https://syzkaller.appspot.com/x/.config?x=861a3573f4e78ba1
> dashboard link: https://syzkaller.appspot.com/bug?extid=e1a4f80c370d2381e49f
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=17836d15400000
> 
> Reported-by: syzbot+e1a4f80c370d2381e49f@syzkaller.appspotmail.com
> Fixes: c68729119f4d ("leds: tlc591xx: add missing of_node_put")
> 
> For information about bisection process see: https://goo.gl/tpsmEJ#bisection

Can you revert c68729119f4d2993bec3c9cb999ad76de5aeddba on master and
see  if it fixes the problem? Because this is hard to believe...

									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: WARNING in untrack_pfn
  2019-04-12 13:01   ` Pavel Machek
@ 2019-04-12 13:21     ` Julia Lawall
  2019-05-08 12:37       ` Dmitry Vyukov
  0 siblings, 1 reply; 6+ messages in thread
From: Julia Lawall @ 2019-04-12 13:21 UTC (permalink / raw)
  To: Pavel Machek
  Cc: syzbot, Julia.Lawall, bp, dan.j.williams, dave.hansen,
	dave.jiang, haozhong.zhang, hpa, jacek.anaszewski, linux-kernel,
	linux-leds, luto, mingo, pbonzini, peterz, rkrcmar, rpurdie,
	syzkaller-bugs, tglx, x86



On Fri, 12 Apr 2019, Pavel Machek wrote:

> On Fri 2019-04-12 04:42:01, syzbot wrote:
> > syzbot has bisected this bug to:
> >
> > commit c68729119f4d2993bec3c9cb999ad76de5aeddba
> > Author: Julia Lawall <Julia.Lawall@lip6.fr>
> > Date:   Sat Jul 15 09:58:19 2017 +0000
> >
> >     leds: tlc591xx: add missing of_node_put
> >
> > bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=12cda0f3200000
> > start commit:   23203e3f Merge branch 'akpm' (patches from Andrew)
> > git tree:       upstream
> > final crash:    https://syzkaller.appspot.com/x/report.txt?x=11cda0f3200000
> > console output: https://syzkaller.appspot.com/x/log.txt?x=16cda0f3200000
> > kernel config:  https://syzkaller.appspot.com/x/.config?x=861a3573f4e78ba1
> > dashboard link: https://syzkaller.appspot.com/bug?extid=e1a4f80c370d2381e49f
> > syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=17836d15400000
> >
> > Reported-by: syzbot+e1a4f80c370d2381e49f@syzkaller.appspotmail.com
> > Fixes: c68729119f4d ("leds: tlc591xx: add missing of_node_put")
> >
> > For information about bisection process see: https://goo.gl/tpsmEJ#bisection
>
> Can you revert c68729119f4d2993bec3c9cb999ad76de5aeddba on master and
> see  if it fixes the problem? Because this is hard to believe...

Likewise, it seems hard to believe that the change is a problem.  But
could the problem be elsewhere and triggered by this code?

julia

>
> 									Pavel
>
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: WARNING in untrack_pfn
  2019-04-12 13:21     ` Julia Lawall
@ 2019-05-08 12:37       ` Dmitry Vyukov
  0 siblings, 0 replies; 6+ messages in thread
From: Dmitry Vyukov @ 2019-05-08 12:37 UTC (permalink / raw)
  To: Julia Lawall
  Cc: Pavel Machek, syzbot, Borislav Petkov, Dan Williams, Dave Hansen,
	Dave Jiang, Haozhong Zhang, H. Peter Anvin, jacek.anaszewski,
	LKML, linux-leds, Andy Lutomirski, Ingo Molnar, Paolo Bonzini,
	Peter Zijlstra, Radim Krčmář,
	rpurdie, syzkaller-bugs, Thomas Gleixner,
	the arch/x86 maintainers

From: Julia Lawall
Date: Fri, Apr 12, 2019 at 3:21 PM

> On Fri, 12 Apr 2019, Pavel Machek wrote:
>
> > On Fri 2019-04-12 04:42:01, syzbot wrote:
> > > syzbot has bisected this bug to:
> > >
> > > commit c68729119f4d2993bec3c9cb999ad76de5aeddba
> > > Author: Julia Lawall <Julia.Lawall@lip6.fr>
> > > Date:   Sat Jul 15 09:58:19 2017 +0000
> > >
> > >     leds: tlc591xx: add missing of_node_put
> > >
> > > bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=12cda0f3200000
> > > start commit:   23203e3f Merge branch 'akpm' (patches from Andrew)
> > > git tree:       upstream
> > > final crash:    https://syzkaller.appspot.com/x/report.txt?x=11cda0f3200000
> > > console output: https://syzkaller.appspot.com/x/log.txt?x=16cda0f3200000
> > > kernel config:  https://syzkaller.appspot.com/x/.config?x=861a3573f4e78ba1
> > > dashboard link: https://syzkaller.appspot.com/bug?extid=e1a4f80c370d2381e49f
> > > syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=17836d15400000
> > >
> > > Reported-by: syzbot+e1a4f80c370d2381e49f@syzkaller.appspotmail.com
> > > Fixes: c68729119f4d ("leds: tlc591xx: add missing of_node_put")
> > >
> > > For information about bisection process see: https://goo.gl/tpsmEJ#bisection
> >
> > Can you revert c68729119f4d2993bec3c9cb999ad76de5aeddba on master and
> > see  if it fixes the problem? Because this is hard to believe...
>
> Likewise, it seems hard to believe that the change is a problem.  But
> could the problem be elsewhere and triggered by this code?

Looking at the bisection log, this looks like a hard to reproduce,
flaky crash. Most likely the crash did not fire on one of the commits
and that diverted bisection in the wrong direction.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: WARNING in untrack_pfn
       [not found] <000000000000f70a0e0571ad8ffb@google.com>
  2019-04-12 11:42 ` WARNING in untrack_pfn syzbot
@ 2019-08-13 10:56 ` syzbot
  2019-08-13 11:31   ` Pavel Machek
  1 sibling, 1 reply; 6+ messages in thread
From: syzbot @ 2019-08-13 10:56 UTC (permalink / raw)
  To: Julia.Lawall, bp, dan.j.williams, dave.hansen, dave.jiang,
	dvyukov, haozhong.zhang, hpa, jacek.anaszewski, julia.lawall,
	linux-kernel, linux-leds, luto, mingo, pavel, pbonzini, peterz,
	rkrcmar, rpurdie, syzkaller-bugs, tglx, x86

syzbot has found a reproducer for the following crash on:

HEAD commit:    d45331b0 Linux 5.3-rc4
git tree:       upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=16130d4a600000
kernel config:  https://syzkaller.appspot.com/x/.config?x=3d7eaed8496da4da
dashboard link: https://syzkaller.appspot.com/bug?extid=e1a4f80c370d2381e49f
compiler:       clang version 9.0.0 (/home/glider/llvm/clang  
80fee25776c2fb61e74c1ecb1a523375c2500b69)
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=131f8e0e600000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=10e1a1ee600000

The bug was bisected to:

commit c68729119f4d2993bec3c9cb999ad76de5aeddba
Author: Julia Lawall <Julia.Lawall@lip6.fr>
Date:   Sat Jul 15 09:58:19 2017 +0000

     leds: tlc591xx: add missing of_node_put

bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=12cda0f3200000
final crash:    https://syzkaller.appspot.com/x/report.txt?x=11cda0f3200000
console output: https://syzkaller.appspot.com/x/log.txt?x=16cda0f3200000

IMPORTANT: if you fix the bug, please add the following tag to the commit:
Reported-by: syzbot+e1a4f80c370d2381e49f@syzkaller.appspotmail.com
Fixes: c68729119f4d ("leds: tlc591xx: add missing of_node_put")

RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 00000000004432d9
RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000
RBP: ffffffffffffffff R08: 0000000000000000 R09: 00000000004aa942
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000004
R13: 00007ffc1519c410 R14: 0000000000000000 R15: 0000000000000000
WARNING: CPU: 1 PID: 9558 at arch/x86/mm/pat.c:1065 untrack_pfn+0x222/0x370  
arch/x86/mm/pat.c:1064
Kernel panic - not syncing: panic_on_warn set ...
CPU: 1 PID: 9558 Comm: syz-executor347 Not tainted 5.3.0-rc4 #73
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS  
Google 01/01/2011
Call Trace:
  __dump_stack lib/dump_stack.c:77 [inline]
  dump_stack+0x1d8/0x2f8 lib/dump_stack.c:113
  panic+0x25c/0x799 kernel/panic.c:219
  __warn+0x22f/0x230 kernel/panic.c:576
  report_bug+0x190/0x290 lib/bug.c:186
  fixup_bug arch/x86/kernel/traps.c:179 [inline]
  do_error_trap+0xd7/0x440 arch/x86/kernel/traps.c:272
  do_invalid_op+0x36/0x40 arch/x86/kernel/traps.c:291
  invalid_op+0x23/0x30 arch/x86/entry/entry_64.S:1028
RIP: 0010:untrack_pfn+0x222/0x370 arch/x86/mm/pat.c:1064
Code: 4d b0 4c 8d 45 b8 4c 89 ff 31 d2 e8 98 1d 69 00 41 89 c6 31 ff 89 c6  
e8 8c 59 3d 00 45 85 f6 0f 84 af 00 00 00 e8 de 55 3d 00 <0f> 0b eb 63 e8  
d5 55 3d 00 48 b8 00 00 00 00 00 fc ff df 48 89 c1
RSP: 0018:ffff88808dabf9e0 EFLAGS: 00010293
RAX: ffffffff81362ea2 RBX: 1ffff11011b57f3f RCX: ffff8880959ae100
RDX: 0000000000000000 RSI: 00000000ffffffea RDI: 0000000000000000
RBP: ffff88808dabfa40 R08: ffffffff81362e94 R09: ffffed1012bd7598
R10: ffffed1012bd7598 R11: 0000000000000000 R12: 1ffff11012e3dc29
R13: 0000000000000000 R14: 00000000ffffffea R15: ffff8880971ee148
  unmap_single_vma+0x1f4/0x2e0 mm/memory.c:1256
  unmap_vmas+0x1b4/0x2b0 mm/memory.c:1309
  exit_mmap+0x27b/0x530 mm/mmap.c:3145
  __mmput+0x120/0x3a0 kernel/fork.c:1064
  mmput kernel/fork.c:1085 [inline]
  dup_mm+0x31b/0x340 kernel/fork.c:1362
  copy_mm kernel/fork.c:1402 [inline]
  copy_process+0x2563/0x5ac0 kernel/fork.c:2017
  _do_fork+0x13f/0x5b0 kernel/fork.c:2369
  __do_sys_clone kernel/fork.c:2524 [inline]
  __se_sys_clone kernel/fork.c:2505 [inline]
  __x64_sys_clone+0x1ec/0x230 kernel/fork.c:2505
  do_syscall_64+0xfe/0x140 arch/x86/entry/common.c:296
  entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x4432d9
Code: e8 1c 0d 03 00 48 83 c4 18 c3 0f 1f 80 00 00 00 00 48 89 f8 48 89 f7  
48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff  
ff 0f 83 5b 07 fc ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007ffc1519c3b8 EFLAGS: 00000246 ORIG_RAX: 0000000000000038
RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 00000000004432d9
RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000
RBP: ffffffffffffffff R08: 0000000000000000 R09: 00000000004aa942
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000004
R13: 00007ffc1519c410 R14: 0000000000000000 R15: 0000000000000000
Kernel Offset: disabled
Rebooting in 86400 seconds..


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: WARNING in untrack_pfn
  2019-08-13 10:56 ` syzbot
@ 2019-08-13 11:31   ` Pavel Machek
  0 siblings, 0 replies; 6+ messages in thread
From: Pavel Machek @ 2019-08-13 11:31 UTC (permalink / raw)
  To: syzbot
  Cc: Julia.Lawall, bp, dan.j.williams, dave.hansen, dave.jiang,
	dvyukov, haozhong.zhang, hpa, jacek.anaszewski, linux-kernel,
	linux-leds, luto, mingo, pbonzini, peterz, rkrcmar, rpurdie,
	syzkaller-bugs, tglx, x86

[-- Attachment #1: Type: text/plain, Size: 1271 bytes --]

On Tue 2019-08-13 03:56:06, syzbot wrote:
> syzbot has found a reproducer for the following crash on:

Unsigned emails are ugly. Could the "From: " be modified to include
name of responsible person?

> HEAD commit:    d45331b0 Linux 5.3-rc4
> git tree:       upstream
> console output: https://syzkaller.appspot.com/x/log.txt?x=16130d4a600000
> kernel config:  https://syzkaller.appspot.com/x/.config?x=3d7eaed8496da4da
> dashboard link: https://syzkaller.appspot.com/bug?extid=e1a4f80c370d2381e49f
> compiler:       clang version 9.0.0 (/home/glider/llvm/clang
> 80fee25776c2fb61e74c1ecb1a523375c2500b69)
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=131f8e0e600000
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=10e1a1ee600000
> 
> The bug was bisected to:
> 
> commit c68729119f4d2993bec3c9cb999ad76de5aeddba
> Author: Julia Lawall <Julia.Lawall@lip6.fr>
> Date:   Sat Jul 15 09:58:19 2017 +0000
> 
>     leds: tlc591xx: add missing of_node_put

And this looks like mistake. I don't think this commit is causing the
crash. Can you somehow verify?

								Pavel
								
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <000000000000f70a0e0571ad8ffb@google.com>
2019-04-12 11:42 ` WARNING in untrack_pfn syzbot
2019-04-12 13:01   ` Pavel Machek
2019-04-12 13:21     ` Julia Lawall
2019-05-08 12:37       ` Dmitry Vyukov
2019-08-13 10:56 ` syzbot
2019-08-13 11:31   ` Pavel Machek

Linux-LEDs Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-leds/0 linux-leds/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-leds linux-leds/ https://lore.kernel.org/linux-leds \
		linux-leds@vger.kernel.org linux-leds@archiver.kernel.org
	public-inbox-index linux-leds


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-leds


AGPL code for this site: git clone https://public-inbox.org/ public-inbox