* [PATCH] leds: core: Fix warning message when init_data
@ 2020-04-01 9:51 Ricardo Ribalda Delgado
2020-04-01 19:49 ` Jacek Anaszewski
0 siblings, 1 reply; 3+ messages in thread
From: Ricardo Ribalda Delgado @ 2020-04-01 9:51 UTC (permalink / raw)
To: Jacek Anaszewski, Pavel Machek, Dan Murphy, Linus Walleij,
linux-leds, linux-kernel
Cc: Ricardo Ribalda Delgado
The warning message when a led is renamed due to name collition can fail
to show proper original name if init_data is used. Eg:
[ 9.073996] leds-gpio a0040000.leds_0: Led (null) renamed to red_led_1 due to name collision
Fixes: bb4e9af0348d ("leds: core: Add support for composing LED class device names")
Signed-off-by: Ricardo Ribalda Delgado <ribalda@kernel.org>
---
drivers/leds/led-class.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c
index 1fc40e8af75e..3363a6551a70 100644
--- a/drivers/leds/led-class.c
+++ b/drivers/leds/led-class.c
@@ -376,7 +376,7 @@ int led_classdev_register_ext(struct device *parent,
if (ret)
dev_warn(parent, "Led %s renamed to %s due to name collision",
- led_cdev->name, dev_name(led_cdev->dev));
+ proposed_name, dev_name(led_cdev->dev));
if (led_cdev->flags & LED_BRIGHT_HW_CHANGED) {
ret = led_add_brightness_hw_changed(led_cdev);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] leds: core: Fix warning message when init_data
2020-04-01 9:51 [PATCH] leds: core: Fix warning message when init_data Ricardo Ribalda Delgado
@ 2020-04-01 19:49 ` Jacek Anaszewski
2020-04-06 21:13 ` Pavel Machek
0 siblings, 1 reply; 3+ messages in thread
From: Jacek Anaszewski @ 2020-04-01 19:49 UTC (permalink / raw)
To: Ricardo Ribalda Delgado, Pavel Machek, Dan Murphy, Linus Walleij,
linux-leds, linux-kernel
Hi Ricardo,
Thank you for the patch.
On 4/1/20 11:51 AM, Ricardo Ribalda Delgado wrote:
> The warning message when a led is renamed due to name collition can fail
> to show proper original name if init_data is used. Eg:
>
> [ 9.073996] leds-gpio a0040000.leds_0: Led (null) renamed to red_led_1 due to name collision
>
> Fixes: bb4e9af0348d ("leds: core: Add support for composing LED class device names")
> Signed-off-by: Ricardo Ribalda Delgado <ribalda@kernel.org>
> ---
> drivers/leds/led-class.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c
> index 1fc40e8af75e..3363a6551a70 100644
> --- a/drivers/leds/led-class.c
> +++ b/drivers/leds/led-class.c
> @@ -376,7 +376,7 @@ int led_classdev_register_ext(struct device *parent,
>
> if (ret)
> dev_warn(parent, "Led %s renamed to %s due to name collision",
> - led_cdev->name, dev_name(led_cdev->dev));
> + proposed_name, dev_name(led_cdev->dev));
>
> if (led_cdev->flags & LED_BRIGHT_HW_CHANGED) {
> ret = led_add_brightness_hw_changed(led_cdev);
>
Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
--
Best regards,
Jacek Anaszewski
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] leds: core: Fix warning message when init_data
2020-04-01 19:49 ` Jacek Anaszewski
@ 2020-04-06 21:13 ` Pavel Machek
0 siblings, 0 replies; 3+ messages in thread
From: Pavel Machek @ 2020-04-06 21:13 UTC (permalink / raw)
To: Jacek Anaszewski
Cc: Ricardo Ribalda Delgado, Dan Murphy, Linus Walleij, linux-leds,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1491 bytes --]
On Wed 2020-04-01 21:49:00, Jacek Anaszewski wrote:
> Hi Ricardo,
>
> Thank you for the patch.
>
> On 4/1/20 11:51 AM, Ricardo Ribalda Delgado wrote:
> > The warning message when a led is renamed due to name collition can fail
> > to show proper original name if init_data is used. Eg:
> >
> > [ 9.073996] leds-gpio a0040000.leds_0: Led (null) renamed to red_led_1 due to name collision
> >
> > Fixes: bb4e9af0348d ("leds: core: Add support for composing LED class device names")
> > Signed-off-by: Ricardo Ribalda Delgado <ribalda@kernel.org>
> > ---
> > drivers/leds/led-class.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c
> > index 1fc40e8af75e..3363a6551a70 100644
> > --- a/drivers/leds/led-class.c
> > +++ b/drivers/leds/led-class.c
> > @@ -376,7 +376,7 @@ int led_classdev_register_ext(struct device *parent,
> >
> > if (ret)
> > dev_warn(parent, "Led %s renamed to %s due to name collision",
> > - led_cdev->name, dev_name(led_cdev->dev));
> > + proposed_name, dev_name(led_cdev->dev));
> >
> > if (led_cdev->flags & LED_BRIGHT_HW_CHANGED) {
> > ret = led_add_brightness_hw_changed(led_cdev);
> >
>
> Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Thanks, applied.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-06 21:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-01 9:51 [PATCH] leds: core: Fix warning message when init_data Ricardo Ribalda Delgado
2020-04-01 19:49 ` Jacek Anaszewski
2020-04-06 21:13 ` Pavel Machek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).