linux-leds.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Eddie James <eajames@linux.ibm.com>
Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, robh+dt@kernel.org, dmurphy@ti.com,
	jacek.anaszewski@gmail.com, vishwa@linux.ibm.com
Subject: Re: [PATCH 1/2] dt-bindings: leds: pca955x: Add IBM implementation compatible string
Date: Sat, 11 Jul 2020 15:48:14 +0200	[thread overview]
Message-ID: <20200711134814.GB6407@amd> (raw)
In-Reply-To: <20200709201220.13736-2-eajames@linux.ibm.com>

[-- Attachment #1: Type: text/plain, Size: 830 bytes --]

Hi!

> IBM created an implementation of the PCA9552 on a PIC16F
> microcontroller. Document the new compatible string for this device.

Is the implementation opensource?

> Signed-off-by: Eddie James <eajames@linux.ibm.com>

> +++ b/Documentation/devicetree/bindings/leds/leds-pca955x.txt
> @@ -9,6 +9,7 @@ Required properties:
>  	"nxp,pca9550"
>  	"nxp,pca9551"
>  	"nxp,pca9552"
> +	"nxp,pca9552-ibm"
>  	"nxp,pca9553"

Is it good idea to use nxp prefix for something that is
software-defined and not built by nxp?

Would ibm,pca9552 be better, or maybe even sw,pca9552 to indicate that
is not real hardware, but software emulation?

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

  reply	other threads:[~2020-07-11 13:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-09 20:12 [PATCH 0/2] leds: pca955x: Add IBM software implemenation of the PCA9552 chip Eddie James
2020-07-09 20:12 ` [PATCH 1/2] dt-bindings: leds: pca955x: Add IBM implementation compatible string Eddie James
2020-07-11 13:48   ` Pavel Machek [this message]
2020-07-13 14:28     ` Eddie James
2020-07-20 22:25       ` Rob Herring
2020-07-09 20:12 ` [PATCH 2/2] leds: pca955x: Add an IBM software implementation of the PCA9552 chip Eddie James
2020-07-09 20:50   ` Andy Shevchenko
2020-07-13 14:29     ` Eddie James

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200711134814.GB6407@amd \
    --to=pavel@ucw.cz \
    --cc=devicetree@vger.kernel.org \
    --cc=dmurphy@ti.com \
    --cc=eajames@linux.ibm.com \
    --cc=jacek.anaszewski@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=vishwa@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).