From: Pavel Machek <pavel@ucw.cz>
To: Alexandre Courbot <gnurou@gmail.com>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Dan Murphy <dmurphy@ti.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-leds@vger.kernel.org
Subject: Re: [PATCH] leds: add NCT6795D driver
Date: Mon, 20 Jul 2020 15:57:39 +0200 [thread overview]
Message-ID: <20200720135739.GA25390@amd> (raw)
In-Reply-To: <CAAVeFuLxKO9nJ+1GDuAr+-Z_BQMZpEVD46F2j=dZ3hDUv-eE=A@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1117 bytes --]
Hi!
> > According to common LED bindings you should propose a new function
> > if none of the existing ones fits your needs.
> >
> > > This is normally used for motherboard lightning, right? I believe this
> > > is getting common on gaming boards, and we want common support for
> > > that.
> >
> > I agree.
>
> These boards are indeed far from being a rarity so having a function
> for them (maybe named LED_FUNCTION_RGB_HEADER?) makes sense IMHO. I'll
> submit a patch for that with the next revision.
I'd call it something LED_FUNCTION_INTERNALS, and make it clear this
is for illuminating machine internals.
> Speaking of which, after looking at the multicolor patchset it is
> pretty obvious that it would be a much better way to expose this RGB
> header, so I think I will wait until it is merged and adapt the driver
> to use it.
Take a look at LED tree today, or linux-next tommorow. Basics should
be there.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
prev parent reply other threads:[~2020-07-20 13:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 13:41 [PATCH] leds: add NCT6795D driver Alexandre Courbot
2020-07-14 22:33 ` Pavel Machek
2020-07-15 1:54 ` Alexandre Courbot
2020-07-15 19:32 ` Jacek Anaszewski
2020-07-17 1:00 ` Alexandre Courbot
2020-07-17 7:44 ` Pavel Machek
2020-07-17 19:25 ` Jacek Anaszewski
2020-07-20 13:07 ` Alexandre Courbot
2020-07-20 13:57 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200720135739.GA25390@amd \
--to=pavel@ucw.cz \
--cc=dmurphy@ti.com \
--cc=gnurou@gmail.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).