From: Pavel Machek <pavel@ucw.cz>
To: "Marek Behún" <marek.behun@nic.cz>
Cc: netdev@vger.kernel.org, linux-leds@vger.kernel.org,
jacek.anaszewski@gmail.com, "Dan Murphy" <dmurphy@ti.com>,
"Ondřej Jirman" <megous@megous.com>,
"Russell King" <linux@armlinux.org.uk>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Gregory Clement" <gregory.clement@bootlin.com>,
"Andrew Lunn" <andrew@lunn.ch>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC leds + net-next v3 1/2] net: phy: add API for LEDs controlled by PHY HW
Date: Sat, 25 Jul 2020 11:21:24 +0200 [thread overview]
Message-ID: <20200725092124.GA29492@amd> (raw)
In-Reply-To: <20200724164603.29148-2-marek.behun@nic.cz>
[-- Attachment #1: Type: text/plain, Size: 1824 bytes --]
Hi!
> Many PHYs support various HW control modes for LEDs connected directly
> to them.
>
> This code adds a new private LED trigger called phydev-hw-mode. When
> this trigger is enabled for a LED, the various HW control modes which
> the PHY supports for given LED can be get/set via hw_mode sysfs file.
>
> A PHY driver wishing to utilize this API needs to register the LEDs on
> its own and set the .trigger_type member of LED classdev to
> &phy_hw_led_trig_type. It also needs to implement the methods
> .led_iter_hw_mode, .led_set_hw_mode and .led_get_hw_mode in struct
> phydev.
>
> Signed-off-by: Marek Behún <marek.behun@nic.cz>
Nothing too wrong.
New sysfs file will require documentation.
Plus I wonder: should we have single hw_mode file? It seems many
different "bits" fit inside. Would it be possible to split it further,
and have bits saying:
"I want the LED to be on if link is 10Mbps".
"I want the LED to be on if link is 100Mbps".
"I want the LED to be on if link is 1000Mbps".
"I want the LED to blink on tx".
"I want the LED to blink on rx".
?
+ { "1Gbps/100Mbps/10Mbps", { 0x2, -1, -1, -1, -1,
+ { "1Gbps", { 0x7, -1, -1, -1, -1,
+ { "100Mbps-fiber", { -1, 0x5, -1, -1, -1,
+ { "100Mbps-10Mbps", { -1, 0x5, -1, -1, -1,
+ { "1Gbps-100Mbps", { -1, 0x6, -1, -1, -1,
+ { "1Gbps-10Mbps", { -1, -1, 0x6, 0x6, -1,
+ { "100Mbps", { -1, 0x7, -1, -1, -1,
+ { "10Mbps", { -1, -1, 0x7, -1, -1,
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2020-07-25 9:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 16:46 [PATCH RFC leds + net-next v3 0/2] Add support for LEDs on Marvell PHYs Marek Behún
2020-07-24 16:46 ` [PATCH RFC leds + net-next v3 1/2] net: phy: add API for LEDs controlled by PHY HW Marek Behún
2020-07-25 9:21 ` Pavel Machek [this message]
2020-07-25 9:37 ` Marek Behun
2020-07-25 16:22 ` Andrew Lunn
2020-07-24 16:46 ` [PATCH RFC leds + net-next v3 2/2] net: phy: marvell: add support for PHY LEDs via LED class Marek Behún
2020-07-25 9:23 ` Pavel Machek
2020-07-25 9:34 ` Marek Behun
2020-07-25 15:03 ` Andrew Lunn
2020-07-25 17:39 ` Marek Behun
2020-07-25 17:47 ` Andrew Lunn
2020-07-25 17:23 ` Andrew Lunn
2020-07-25 18:02 ` Marek Behun
2020-07-25 18:23 ` Andrew Lunn
2020-07-25 18:48 ` Andrew Lunn
2020-07-25 20:58 ` Marek Behun
2020-08-07 9:11 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200725092124.GA29492@amd \
--to=pavel@ucw.cz \
--cc=andrew@lunn.ch \
--cc=dmurphy@ti.com \
--cc=gregory.clement@bootlin.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=marek.behun@nic.cz \
--cc=megous@megous.com \
--cc=netdev@vger.kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).