From: Pavel Machek <pavel@ucw.cz>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-leds@vger.kernel.org,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Dan Murphy <dmurphy@ti.com>, Milo Kim <milo.kim@ti.com>,
Mathias Nyman <mathias.nyman@nokia.com>
Subject: Re: [PATCH -next] leds: fix LEDS_LP55XX_COMMON dependency and build errors
Date: Tue, 28 Jul 2020 12:26:37 +0200 [thread overview]
Message-ID: <20200728102637.GA30718@amd> (raw)
In-Reply-To: <dba79c02-b7f1-dd75-b364-93d90538cc5e@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 1433 bytes --]
Hi!
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Make LEDS_LP55XX_COMMON depend on I2C to fix build errors:
>
> leds-lp55xx-common.c:(.text+0x9d): undefined reference to `i2c_smbus_read_byte_data'
> leds-lp55xx-common.c:(.text+0x8fc): undefined reference to `i2c_smbus_write_byte_data'
>
> These errors happened when I2C=m and LEDS_LP55XX_COMMON=y, so
> prevent that from being possible.
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Dan Murphy <dmurphy@ti.com>
> Cc: linux-leds@vger.kernel.org
> Cc: Milo Kim <milo.kim@ti.com>
> Cc: Mathias Nyman <mathias.nyman@nokia.com>
git is unhappy with your patch for some reason:
Applying: leds: fix LEDS_LP55XX_COMMON dependency and build errors
error: corrupt patch at line 14
Patch failed at 0001 leds: fix LEDS_LP55XX_COMMON dependency and build
errors
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am
--abort".
I somehow applied it by hand and pushed out. Thanks!
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
prev parent reply other threads:[~2020-07-28 10:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 23:57 [PATCH -next] leds: fix LEDS_LP55XX_COMMON dependency and build errors Randy Dunlap
2020-07-28 10:26 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200728102637.GA30718@amd \
--to=pavel@ucw.cz \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mathias.nyman@nokia.com \
--cc=milo.kim@ti.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).