* [PATCH -next] leds: fix LEDS_LP55XX_COMMON dependency and build errors
@ 2020-07-27 23:57 Randy Dunlap
2020-07-28 10:26 ` Pavel Machek
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2020-07-27 23:57 UTC (permalink / raw)
To: LKML, linux-leds, Jacek Anaszewski, Pavel Machek, Dan Murphy,
Milo Kim, Mathias Nyman
From: Randy Dunlap <rdunlap@infradead.org>
Make LEDS_LP55XX_COMMON depend on I2C to fix build errors:
leds-lp55xx-common.c:(.text+0x9d): undefined reference to `i2c_smbus_read_byte_data'
leds-lp55xx-common.c:(.text+0x8fc): undefined reference to `i2c_smbus_write_byte_data'
These errors happened when I2C=m and LEDS_LP55XX_COMMON=y, so
prevent that from being possible.
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Dan Murphy <dmurphy@ti.com>
Cc: linux-leds@vger.kernel.org
Cc: Milo Kim <milo.kim@ti.com>
Cc: Mathias Nyman <mathias.nyman@nokia.com>
---
drivers/leds/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20200727.orig/drivers/leds/Kconfig
+++ linux-next-20200727/drivers/leds/Kconfig
@@ -399,6 +399,7 @@ config LEDS_LP55XX_COMMON
tristate "Common Driver for TI/National LP5521/5523/55231/5562/8501"
depends on LEDS_CLASS_MULTICOLOR || !LEDS_CLASS_MULTICOLOR
depends on OF
+ depends on I2C
select FW_LOADER
select FW_LOADER_USER_HELPER
help
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -next] leds: fix LEDS_LP55XX_COMMON dependency and build errors
2020-07-27 23:57 [PATCH -next] leds: fix LEDS_LP55XX_COMMON dependency and build errors Randy Dunlap
@ 2020-07-28 10:26 ` Pavel Machek
0 siblings, 0 replies; 2+ messages in thread
From: Pavel Machek @ 2020-07-28 10:26 UTC (permalink / raw)
To: Randy Dunlap
Cc: LKML, linux-leds, Jacek Anaszewski, Dan Murphy, Milo Kim, Mathias Nyman
[-- Attachment #1: Type: text/plain, Size: 1433 bytes --]
Hi!
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Make LEDS_LP55XX_COMMON depend on I2C to fix build errors:
>
> leds-lp55xx-common.c:(.text+0x9d): undefined reference to `i2c_smbus_read_byte_data'
> leds-lp55xx-common.c:(.text+0x8fc): undefined reference to `i2c_smbus_write_byte_data'
>
> These errors happened when I2C=m and LEDS_LP55XX_COMMON=y, so
> prevent that from being possible.
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Dan Murphy <dmurphy@ti.com>
> Cc: linux-leds@vger.kernel.org
> Cc: Milo Kim <milo.kim@ti.com>
> Cc: Mathias Nyman <mathias.nyman@nokia.com>
git is unhappy with your patch for some reason:
Applying: leds: fix LEDS_LP55XX_COMMON dependency and build errors
error: corrupt patch at line 14
Patch failed at 0001 leds: fix LEDS_LP55XX_COMMON dependency and build
errors
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am
--abort".
I somehow applied it by hand and pushed out. Thanks!
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-28 10:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-27 23:57 [PATCH -next] leds: fix LEDS_LP55XX_COMMON dependency and build errors Randy Dunlap
2020-07-28 10:26 ` Pavel Machek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).